Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1007424ybl; Thu, 23 Jan 2020 11:46:16 -0800 (PST) X-Google-Smtp-Source: APXvYqwtjTPiq4ya3kAa30WG6y+u3CGf83cw5mSiz7sxIR0Qi7o6lJBVbCJnruuyDnGtYxNygBPO X-Received: by 2002:aca:1011:: with SMTP id 17mr11735930oiq.72.1579808776138; Thu, 23 Jan 2020 11:46:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579808776; cv=none; d=google.com; s=arc-20160816; b=MgrM16RENbleLlcjxiXEjlsY6+c4b1rPBN5LxPw10vFQmbA5tPR7P3zqXewsvNHm1Y ixD9luFBvf1aYcdd+emqLrlNtEY9prDtfjAdeNfPEjEOvOgQ6ZpcuPJogyJR9NwFXSFS p2gbTqkaWIjhPtcK7hP2yJSaOHseKnnOpP22aDCaIh6dul1b5KjaD59uyf9Eb5QyqUFH TqIaBhybvfVmQbx7URaG2/zzNgptBhEw6pTzjo0UcEn5XTiHDM371cxKCpVHYfSTzxeS KDhHIL4JACxLw8AY/yah16+UL/KL56Ppkc9TXWIJAcO+eFydKGFwtZlfJqHtbSk11vqD mizg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:references:subject:cc:cc:to :from:date:message-id; bh=/tNzB78rHikk6pi7VwlYHiXMtvqtQwB2ELt1FHbIUmc=; b=F80LOd5LRvAqPkKDyfsdL7rHcSs6xeAuAxljT76O0MhnWR77L0Ul0z5s5wau2q8hEt jfclfwDgMiX5855eiOa6zPnSQn4JCyQ1wqovQPOtH9xJnNSvNwWutBArOZEpACePA689 GOIObe1BTgyU0vWA5TvA1VPhPNM2ocz6g8ELruBlu/cCUHaTxsfy1n9JsNtkeu58bFi5 iu7IkDFMuQm3gX587h3bUjSSQzSCjSz+gf89uyc4eu9Ek01PCs5yzRSw5P+4Seo+8kaE atBd5sU3ud87J0qRBWRkLT0A8AusUjGqZ+dHXBjkG2/G6Gq0rSVQSIiBCXQ/7F6yXnlh 3Y+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y23si1611131oti.65.2020.01.23.11.46.03; Thu, 23 Jan 2020 11:46:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729246AbgAWToi (ORCPT + 99 others); Thu, 23 Jan 2020 14:44:38 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:41230 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728809AbgAWToi (ORCPT ); Thu, 23 Jan 2020 14:44:38 -0500 Received: by mail-pf1-f193.google.com with SMTP id w62so2010211pfw.8; Thu, 23 Jan 2020 11:44:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:from:to:cc:cc:subject:references :in-reply-to; bh=/tNzB78rHikk6pi7VwlYHiXMtvqtQwB2ELt1FHbIUmc=; b=mOolKALwoRXFVye+bVx4QTz+N2q6rXGNXrNUXFCzRxHW2hJPXRiM4E9vOJackqemi+ IrZvXxmvqIiRq6HymoTVzLr2zmHTxB3ImDHb74/Kb0ifYuJ40v9sNEIcJB5Q4zNYXunh XLc9yh7A48vekwdMBKUDQ91g6xHlHDx8K7kCdtvkV0c6UE5BaJTYqeehrfCPfe07pjO1 tFEpNj1AEC3pB1NMySPDUED5fv7JLzhJXUmFwINMu8YJKTVeroRhvF/HiWG9FYqId0p5 lKLv7I044s2dn6Re67wKgjBp6xtqizCAgGnunYs8WkfisO/ZBFWR+PaM4gF+fll53uKO P/yg== X-Gm-Message-State: APjAAAUxNsMyuNahsXyneqlNCRxj+RmvjUrZi5j1fBuvty8NfMCH3i8R NZtYEnMDtYrPMWKUrVQbQag= X-Received: by 2002:a63:cc4f:: with SMTP id q15mr422378pgi.159.1579808677392; Thu, 23 Jan 2020 11:44:37 -0800 (PST) Received: from localhost (MIPS-TECHNO.ear1.SanJose1.Level3.net. [4.15.122.74]) by smtp.gmail.com with ESMTPSA id 132sm3930842pgd.76.2020.01.23.11.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jan 2020 11:44:36 -0800 (PST) Message-ID: <5e29f7a4.1c69fb81.6d9f7.9a12@mx.google.com> Date: Thu, 23 Jan 2020 11:44:36 -0800 From: Paul Burton To: Thomas Bogendoerfer CC: Ralf Baechle , Paul Burton , James Hogan , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org CC: linux-mips@vger.kernel.org Subject: Re: [PATCH] MIPS: SGI-IP30: Check for valid pointer before using it References: <20200122131334.21970-1-tbogendoerfer@suse.de> In-Reply-To: <20200122131334.21970-1-tbogendoerfer@suse.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Thomas Bogendoerfer wrote: > Fix issue detected by Smatch: > > ./arch/mips/sgi-ip30/ip30-irq.c:236 heart_domain_free() > warn: variable dereferenced before check 'irqd' (see line 235) Applied to mips-next. > commit c0e79fd89749 > https://git.kernel.org/mips/c/c0e79fd89749 > > Fixes: 7505576d1c1a ("MIPS: add support for SGI Octane (IP30)") > Signed-off-by: Thomas Bogendoerfer > Signed-off-by: Paul Burton Thanks, Paul [ This message was auto-generated; if you believe anything is incorrect then please email paulburton@kernel.org to report it. ]