Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Martin Lau <kafai@fb.com>
To:     Lorenz Bauer <lmb@cloudflare.com>
CC:     Shuah Khan <shuah@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
        "Daniel Borkmann" <daniel@iogearbox.net>,
        Song Liu <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
        Andrii Nakryiko <andriin@fb.com>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf 2/4] selftests: bpf: ignore RST packets for reuseport
 tests
Thread-Topic: [PATCH bpf 2/4] selftests: bpf: ignore RST packets for reuseport
 tests
Thread-Index: AQHV0g6NwgtJo3iSuUOeG+lkP8Lweqf4yxEA
Date:   Thu, 23 Jan 2020 21:53:51 +0000
Message-ID: <20200123215348.zql3d5xpg2if7v6q@kafai-mbp.dhcp.thefacebook.com>
References: <20200123165934.9584-1-lmb@cloudflare.com>
 <20200123165934.9584-3-lmb@cloudflare.com>
In-Reply-To: <20200123165934.9584-3-lmb@cloudflare.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:200::2:d66d]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7872a064-d5ae-48cf-2f0e-08d7a04ebbfb
x-ms-traffictypediagnostic: MN2PR15MB3741:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <MN2PR15MB3741E95DC7D1A210915F123ED50F0@MN2PR15MB3741.namprd15.prod.outlook.com>
x-fb-source: Internal
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-forefront-prvs: 029174C036
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(346002)(376002)(396003)(39860400002)(136003)(189003)(199004)(71200400001)(316002)(6506007)(2906002)(6916009)(8936002)(86362001)(9686003)(186003)(16526019)(7696005)(4326008)(54906003)(55016002)(52116002)(81156014)(4744005)(8676002)(478600001)(66946007)(5660300002)(81166006)(64756008)(1076003)(66476007)(66446008)(66556008);DIR:OUT;SFP:1102;SCL:1;SRVR:MN2PR15MB3741;H:MN2PR15MB3213.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: RKos86YICvFbX/60zuj8itj36fLtC4zj13/Jvxv1zIUGr5V3WnerNyLmN9MpB6QyOCVradUbthQZ4GLcFDEyfGUx+BduKNNJ4FnZo6/BIPvv6sdBvfZYIyAOYTqWlx5461q3Iqugxxmeior4BjcuGP+3kv+lq9C7mfKiJuK4vQmEuHkNrbvuBtpgeERKO7nZKMuzv6yqLi7YJ/kTSeDkICV2kuFN6chIFZ/YvTnNP1bfqKHtcH37xavB8eFzfJ+PQgZ8NbACHrlU524v/4MPst8pG76bLh3voCZc4MHNFVjMAVp3rRKoPNspAVZGtvqxFwAMEPL37SO94OffeU32/LxdTykUgogluGSRnKtuclGw5rRY/unZT/scPJ8hDQqF3CPteGn082CwDtmKTlvXCay2OhUb6iqBPTPJtnJul/2OOFhpd75qbnUPw7S1sw9p
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5A68A724B88B69458192663067C9A9DE@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7872a064-d5ae-48cf-2f0e-08d7a04ebbfb
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2020 21:53:52.1456
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ho9VcVXXhgvypFh488KDbW3+7zuAIXRz7hvlxVoRUAUVZAG+VHOWK6biXmzoJp0E
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR15MB3741
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572
 definitions=2020-01-23_13:2020-01-23,2020-01-23 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 bulkscore=0 clxscore=1015
 priorityscore=1501 mlxscore=0 malwarescore=0 lowpriorityscore=0
 mlxlogscore=560 adultscore=0 spamscore=0 suspectscore=0 impostorscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-1910280000 definitions=main-2001230161
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 23, 2020 at 04:59:31PM +0000, Lorenz Bauer wrote:
> The reuseport tests currently suffer from a race condition: RST
> packets count towards DROP_ERR_SKB_DATA, since they don't contain
> a valid struct cmd. Tests will spuriously fail depending on whether
> check_results is called before or after the RST is processed.
>=20
> Exit the BPF program early if FIN is set.
btw, it needs a Fixes tag.

Patch 4 and Patch 1 also need a Fixes tag.