Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp322000ybl; Fri, 24 Jan 2020 00:43:28 -0800 (PST) X-Google-Smtp-Source: APXvYqxOr2BjAcT1xv13H9acHdyCvqL0ZVyFWPks0bxkchzd/khI6bBRZePIwlUk2x/XYlITBf7T X-Received: by 2002:a9d:5542:: with SMTP id h2mr1785127oti.146.1579855408032; Fri, 24 Jan 2020 00:43:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579855408; cv=none; d=google.com; s=arc-20160816; b=0+vVz6F10VFCzSnolrd+PwFXPRaAxzf12gnPXPJntph+hdHshSBNCAnk2poCC7o8a0 nmE9ODgpVC+oZKQO/aE+x7Jh7CDa/HQFB4nkbErxPrJvpM6OvvgueQAt9VswFvh6tYn3 Uxoy94lBspa1xvuIu3tLFGM3KAVGMMZfPud/s9EPadWmbKLk/6NyL8AFOwO1LQJZhi8z OVDenfdL7eJQTvhM9Gdtod1dcZ6kuxoPig8CYptbYZZ3O8/ReLu5iK2rGDNov+Z+kBfH PBD8QSKlKDyI85rlPJPSSvJvfOicCgRghy/pOXMs7mEiGHajhA5hnwCx6f8IF3pylkHa HjBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=6X0SbdEbwo5mypIaZ7LnyzNrIDQQaVFKLAmiz1doNUQ=; b=X+1BbcC0xDzbm4PwHc5LrVV6wcSYzlf2W5tAM4b8dNTbNdYltHjPhh/m+YHJ/aQZ4Y H+NHAoCji6dFiPbFJZ0idlwSN03NS8LAoxWAWAvpQwcJzRIuc/YXUUSbXDzCins1JqFS pz4X2rZe5CcqN9bzBao5bJoeScxjJnBXdlpOxCix1d2ES6meKkGOyMt+v+D+g+Z+884m tPXm14QEXr8zloNGAFhmGZ98frhoeM/NUeJPhYb47AIleRE3i87lI0JD/n1IqFoYfNPu Zp5kGFbSfJbioGpL4vx+FyR5WtHT9EleSnHl3DNNjqwN0qm1Gpjsj+fb1HsZQ/+A3bqL tP1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f22si2632118otp.145.2020.01.24.00.43.16; Fri, 24 Jan 2020 00:43:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729604AbgAXI3X (ORCPT + 99 others); Fri, 24 Jan 2020 03:29:23 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:37353 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbgAXI3W (ORCPT ); Fri, 24 Jan 2020 03:29:22 -0500 X-Originating-IP: 88.190.179.123 Received: from localhost (unknown [88.190.179.123]) (Authenticated sender: repk@triplefau.lt) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 1C7C6C0010; Fri, 24 Jan 2020 08:29:18 +0000 (UTC) Date: Fri, 24 Jan 2020 09:37:43 +0100 From: Remi Pommarel To: Neil Armstrong Cc: Kishon Vijay Abraham I , Yue Wang , Kevin Hilman , Lorenzo Pieralisi , Bjorn Helgaas , Martin Blumenstingl , Rob Herring , Jerome Brunet , linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v6 0/7] PCI: amlogic: Make PCIe working reliably on AXG platforms Message-ID: <20200124083743.GY1803@voidbox> References: <20200123232943.10229-1-repk@triplefau.lt> <64b5d857-569a-ab2e-a467-9cdb47cf20e4@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64b5d857-569a-ab2e-a467-9cdb47cf20e4@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Jan 24, 2020 at 09:02:12AM +0100, Neil Armstrong wrote: > Hi, > > On 24/01/2020 00:29, Remi Pommarel wrote: > > PCIe device probing failures have been seen on AXG platforms and were > > due to unreliable clock signal output. Setting HHI_MIPI_CNTL0[26] bit > > in MIPI's PHY registers solved the problem. This bit controls band gap > > reference. > > > > As discussed here [1] one of these shared MIPI/PCIE analog PHY register > > bits was implemented in the clock driver as CLKID_MIPI_ENABLE. This adds > > a PHY driver to control this bit instead, as well as setting the band > > gap one in order to get reliable PCIE communication. > > > > While at it add another PHY driver to control PCIE only PHY registers, > > making AXG code more similar to G12A platform thus allowing to remove > > some specific platform handling in pci-meson driver. > > > > Please note that CLKID_MIPI_ENABLE removable will be done in a different > > serie. > > > > Changes since v5: > > - Add additionalProperties in device tree binding documentation > > - Make analog PHY required > > > > Changes since v4: > > - Rename the shared MIPI/PCIe PHY to analog > > - Chain the MIPI/PCIe PHY to the PCIe one > > > > Changes since v3: > > - Go back to the shared MIPI/PCIe phy driver solution from v2 > > - Remove syscon usage > > - Add all dt-bindings documentation > > > > Changes since v2: > > - Remove shared MIPI/PCIE device driver and use syscon to access register > > in PCIE only driver instead > > - Include devicetree documentation > > > > Changes sinve v1: > > - Move HHI_MIPI_CNTL0 bit control in its own PHY driver > > - Add a PHY driver for PCIE_PHY registers > > - Modify pci-meson.c to make use of both PHYs and remove specific > > handling for AXG and G12A > > > > [1] https://lkml.org/lkml/2019/12/16/119 > > > > Remi Pommarel (7): > > dt-bindings: Add AXG PCIE PHY bindings > > dt-bindings: Add AXG shared MIPI/PCIE analog PHY bindings > > dt-bindings: PCI: meson: Update PCIE bindings documentation > > arm64: dts: meson-axg: Add PCIE PHY nodes > > phy: amlogic: Add Amlogic AXG MIPI/PCIE analog PHY Driver > > phy: amlogic: Add Amlogic AXG PCIE PHY Driver > > PCI: amlogic: Use AXG PCIE > > > > .../bindings/pci/amlogic,meson-pcie.txt | 22 +- > > .../amlogic,meson-axg-mipi-pcie-analog.yaml | 35 ++++ > > .../bindings/phy/amlogic,meson-axg-pcie.yaml | 52 +++++ > > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 16 ++ > > drivers/pci/controller/dwc/pci-meson.c | 116 ++--------- > > drivers/phy/amlogic/Kconfig | 22 ++ > > drivers/phy/amlogic/Makefile | 12 +- > > .../amlogic/phy-meson-axg-mipi-pcie-analog.c | 188 +++++++++++++++++ > > drivers/phy/amlogic/phy-meson-axg-pcie.c | 192 ++++++++++++++++++ > > 9 files changed, 543 insertions(+), 112 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml > > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml > > create mode 100644 drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c > > create mode 100644 drivers/phy/amlogic/phy-meson-axg-pcie.c > > > > You forgot to keep the Reviewed-by/Acked-by tags from the previous reviews. > Indeed, sorry about that, I have just added them. -- Remi