Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp370207ybl; Fri, 24 Jan 2020 01:51:05 -0800 (PST) X-Google-Smtp-Source: APXvYqxkhGUJd4VDI+Dymow/RXpBqOKFfG3lQR5cP9IQ+kemcRRqUcG1nL6m00JYY+aE+SJ6Fr/y X-Received: by 2002:a05:6830:1353:: with SMTP id r19mr2130347otq.288.1579859465753; Fri, 24 Jan 2020 01:51:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579859465; cv=none; d=google.com; s=arc-20160816; b=w68RggQBWV19iLO+EivREP8bjF5uvYanLm3fVepoVsjhcaN267uVmxkoIxjVmIyCV2 8z57ArE/BRb0uxvWurZfs0c9vaWUEZ4K8Crl8kIMhXAKFu/3fS2V31NllwzHQqbdejf0 Q/clpPpmYYXAr7DV1FgeMpTwKSXRUUf72yIbgxhljcxehIOqwPzk7yXGO18rBE3/diH6 Iq+ucsmJevT3AFZz7s/phaXlF6LkFnQpioVELwX/hc79AqL+4Wf2l68wNW4IMdJVlloh cRJLshB1h8fp7fO+1qG0MdwP5Tv6kpqfmQ7rlJCLRHF0fZtGnAVP90ejx7Js6pcx95rI mSNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=9hxHYlrOWreTcT9F0JXhv/b/MPgxcQiCtt+IvAmvNhM=; b=c4iM8tleo6Fb4umu3an4tT2b41llSQRN8zWAk5FTi9MK9gro82238xOx0sV5g+Hh4Z oxwC85eWHnCVnQ46MO/aHY4ndOMNlgY7ojJiTOpne7Slh2qpdlVFpse/OCTLBTfNvndq JfdIJow7KMqipSppXxOW0alSY6Laas55NwGm6oNZ1rVsnnjiPdAtOmdLk/HZVPlRS4Bo LTE2xHWWLlOk7zMKQMPxL8dIJ+94YUVJg7WYC2Hjl3k5MQETHlOWEKHgSuDT29lrLDyZ YW+VFCTbOECsWLo9FGkQcLO2Pi407mwaggTv77YAU+KqXw+ie/ciG1pG9Dk9ZL4oJXUL iYqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=O2xK4ez3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r1si2599440otq.298.2020.01.24.01.50.53; Fri, 24 Jan 2020 01:51:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=O2xK4ez3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387865AbgAXJth (ORCPT + 99 others); Fri, 24 Jan 2020 04:49:37 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:53789 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387821AbgAXJte (ORCPT ); Fri, 24 Jan 2020 04:49:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579859373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9hxHYlrOWreTcT9F0JXhv/b/MPgxcQiCtt+IvAmvNhM=; b=O2xK4ez3rlgi/WD9kF7JdZgX1WdI42HWRlH6RwaE6YgE3NfOF0RxzxHw2RmPSpH3eG8vkA igAYsti0Gm+noXsiDJgJrPbFgOKBO6Qa8OOdU7rV0e/hoWsAMTe7w5TSZMWXqWDoVXb5MJ UbiQ2umuvC7VRekGWdUhK8XWap1R574= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-20-eUteBcnwOQy0V5A0BOZbOw-1; Fri, 24 Jan 2020 04:49:31 -0500 X-MC-Unique: eUteBcnwOQy0V5A0BOZbOw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 85D4D1137840; Fri, 24 Jan 2020 09:49:30 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.43.2.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 49EA087EDC; Fri, 24 Jan 2020 09:49:26 +0000 (UTC) Date: Fri, 24 Jan 2020 10:49:23 +0100 From: Andrew Jones To: Ben Gardon Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Cannon Matthews , Peter Xu , Peter Shier , Oliver Upton Subject: Re: [PATCH v4 01/10] KVM: selftests: Create a demand paging test Message-ID: <20200124094923.phubywl4hwdydnbu@kamzik.brq.redhat.com> References: <20200123180436.99487-1-bgardon@google.com> <20200123180436.99487-2-bgardon@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200123180436.99487-2-bgardon@google.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 23, 2020 at 10:04:27AM -0800, Ben Gardon wrote: ... > +#ifdef __x86_64__ > + vcpu_set_cpuid(vm, VCPU_ID, kvm_get_supported_cpuid()); > +#endif > +#ifdef __aarch64__ > + ucall_init(vm, NULL); > +#endif We don't need the #ifdef around ucall_init anymore, now that architectures that don't need it got stubs. I guess dirty_log_test.c could be cleaned up too. I'll send a patch. Thanks, drew