Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751131AbWBBPFp (ORCPT ); Thu, 2 Feb 2006 10:05:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751136AbWBBPFo (ORCPT ); Thu, 2 Feb 2006 10:05:44 -0500 Received: from smtp.innovsys.com ([66.115.232.196]:48575 "EHLO mail.innovsys.com") by vger.kernel.org with ESMTP id S1751130AbWBBPFk convert rfc822-to-8bit (ORCPT ); Thu, 2 Feb 2006 10:05:40 -0500 X-MimeOLE: Produced By Microsoft Exchange V6.5.7226.0 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Subject: RE: [patch 10/44] generic fls64() Date: Thu, 2 Feb 2006 09:05:33 -0600 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [patch 10/44] generic fls64() Thread-Index: AcYnkFHrC3JXjhzOTROGBLzY99BOuAAeZ/rA From: "Rune Torgersen" To: "Akinobu Mita" , Cc: , , "Ian Molton" , "David Howells" , , "Greg Ungerer" , , "Miles Bader" , "Linus Torvalds" , "Yoshinori Sato" , "Hirokazu Takata" , , , "Ivan Kokshaysky" , "Richard Henderson" , "Chris Zankel" , , , "Andi Kleen" , , , "Russell King" , Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 724 Lines: 27 > From: Akinobu Mita > Sent: Wednesday, February 01, 2006 03:03 > +static inline int fls64(__u64 x) > +{ > + __u32 h = x >> 32; > + if (h) > + return fls(x) + 32; Shouldn't this be return fls(h) + 32; ?? ^^^ > + return fls(x); > +} > + > +#endif /* _ASM_GENERIC_BITOPS_FLS64_H_ */ > > -- > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev > > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/