Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp460790ybl; Fri, 24 Jan 2020 03:40:35 -0800 (PST) X-Google-Smtp-Source: APXvYqzcRHve6whBDs7qPeV+7oWFXrH8bZLSjmrK2ocHC6Yiz5b3cE+JXL9n8iQ57X5mPv/365XC X-Received: by 2002:a05:6808:24e:: with SMTP id m14mr1734111oie.168.1579866034290; Fri, 24 Jan 2020 03:40:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579866034; cv=none; d=google.com; s=arc-20160816; b=ENlS8e8akja+Pbu2yohfBL7js5DeL6Re6LCnt5JXpWZozMZnDsNfM1ZI0g/1y4AcLY N5QAWMUNewMaJ0t8vWk5frslkKu75qxi7OSrbomrZHY82B7ZMitWSF8PSEtdt7A1SkJK y4JwlLjKwVNYCDAyhhIMZQ8ptcHpNR+QCN/AgdzuLBdPF53g5OkHctqM5328xxB43clZ CENhnMK77bxhhyYW4ZipE+BBFIy5M+q2aalL/gpevDIV1L3VwvKCsFZwnZbHBJ1l/fV/ poqaA8RVzusNXy4kqSMhYyRFsyMPqrI4VXVLm7X2fDOGGsXhM8Trel/b9jy4AZJ5fqe7 dcSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=r4zxNmALyQaeSNVgycZmI7UdCPyGJp4Jq4VQMZS6LoA=; b=YcwnMp3M3h1j650fQ/vw4Uo0LPEcUsCGI8Hfv18m68o+HtiLLKzGnRVoQfRvr6I/I/ aLMeODHD50PdOWEJCPhIUpiQLYPQGcQBayeH8x19LMeLPV071OqwsEKYoWnYCjiB2kjx tHv8uAQtOz9ajLyL1wFdp39umfkvWQel08NySdm/926gEZSb3HQ45eb2JiM2hDrZEP5u jitUzszfivahsZ3cBj5LuR2qifNSKWs6I0Xa7LKx8jvtwtOyu4K/kX7qBxdSyl5WD7Tc BHqcUB/C0u7/OThtv9qanyLCKWw3iS092hh+mXasm3+n9MSDsez83+AIm6920M2I3Z0w +52Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AJsoSEak; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i8si1531930oto.253.2020.01.24.03.40.22; Fri, 24 Jan 2020 03:40:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AJsoSEak; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403934AbgAXL0Q (ORCPT + 99 others); Fri, 24 Jan 2020 06:26:16 -0500 Received: from mail-vk1-f195.google.com ([209.85.221.195]:33186 "EHLO mail-vk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403917AbgAXL0M (ORCPT ); Fri, 24 Jan 2020 06:26:12 -0500 Received: by mail-vk1-f195.google.com with SMTP id i78so520309vke.0 for ; Fri, 24 Jan 2020 03:26:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r4zxNmALyQaeSNVgycZmI7UdCPyGJp4Jq4VQMZS6LoA=; b=AJsoSEakroKigcs2LGpzFMwCgIQRExPi/mj4WfXkL5sxCiUUKPgLWLeoUD/zI6wuJD nDnv5X/UovIDv0oVVPK/bOV/r9T3ChUKkgYIYC9t4UWuxU5RAzCwaz4yls51fzKxjmS4 baFvn3RZy1U2BYpwOJBFp0lGTKupCoduCSPuHuVqFe6Zvmvs5v8TAxcMIrCENfbv0gPO T3jUlKF1FWyXmL/HeSFUU3+vCbS1MQg8KiHGmR+XrrP1oi7SRNC4e6IrzGzEjUY/bSrA L8VNNE6vFC1uwo1MYUx997nvmvUQ9J0bM4UZHWPs6E80bkD0AYOSbSd0L/O9g8UGfZY6 bpHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r4zxNmALyQaeSNVgycZmI7UdCPyGJp4Jq4VQMZS6LoA=; b=Ji/UFxEAhiiNZzqvdvZHZZDLX02/pCKoGVJ8toyOxcV8vX5ikZJ0cWDohJwLrzwSPi A/LQq2xFjuZouSW1do3LM5NWGfzx1qNawWUlxGRAjmv8dldfU5lfxsnkdcm3/sP+d0Z8 p6WRmptEigWByu35+X4EUIrHT2mVi593hLhQU2bHQhWsrybOsQiAF8r84NuC7WYEU8Mf cBxAn9BPNFJPDJd8CPk8U02clcqjac6osfRNRbGLV5iA8hWqXgwupm9ehmVauQWWpjc5 syLckMiNmxsNbfYfwF8I9aiBUBZh54Qbvb17+OVZ1sWW4rTAvd69DE8LzrHcOxgzJmDy GM1A== X-Gm-Message-State: APjAAAUyHftdS20udQhaDspqh0W2QgWGXseDmxb8QrLCw8i9b0u5R58d xd1Wti1pfw+DN8qMk5u3gDNV5NzQ6NTtOvzLXqgKmg== X-Received: by 2002:a1f:914b:: with SMTP id t72mr1592935vkd.101.1579865170740; Fri, 24 Jan 2020 03:26:10 -0800 (PST) MIME-Version: 1.0 References: <20200121105858.13325-1-yamada.masahiro@socionext.com> In-Reply-To: <20200121105858.13325-1-yamada.masahiro@socionext.com> From: Ulf Hansson Date: Fri, 24 Jan 2020 12:25:34 +0100 Message-ID: Subject: Re: [PATCH] mmc: sdhci-cadence: remove unneeded 'inline' marker To: Masahiro Yamada Cc: "linux-mmc@vger.kernel.org" , Adrian Hunter , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Jan 2020 at 11:59, Masahiro Yamada wrote: > > 'static inline' in .c files does not make much sense because > functions may or may not be inlined irrespective of the 'inline' > marker. It is just a hint. > > This function is quite small, so very likely to be inlined by the > compiler's optimization (-O2 or -Os), but it is up to the compiler > after all. > > Signed-off-by: Masahiro Yamada Applied for next, thanks! Kind regards Uffe > --- > > drivers/mmc/host/sdhci-cadence.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c > index ae0ec27dd7cc..5827d3751b81 100644 > --- a/drivers/mmc/host/sdhci-cadence.c > +++ b/drivers/mmc/host/sdhci-cadence.c > @@ -158,7 +158,7 @@ static int sdhci_cdns_phy_init(struct sdhci_cdns_priv *priv) > return 0; > } > > -static inline void *sdhci_cdns_priv(struct sdhci_host *host) > +static void *sdhci_cdns_priv(struct sdhci_host *host) > { > struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > > -- > 2.17.1 >