Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp607763ybl; Fri, 24 Jan 2020 06:21:25 -0800 (PST) X-Google-Smtp-Source: APXvYqwMtaumP85RlfOWc3BQ2ZNHQEBwmkOa6LgZ87CA83BQM/S0RV3PNeGHSoX7jxWMRsx82bI1 X-Received: by 2002:aca:a9c5:: with SMTP id s188mr2153475oie.154.1579875685660; Fri, 24 Jan 2020 06:21:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579875685; cv=none; d=google.com; s=arc-20160816; b=V6CiPo3LTX/hSqlEnJR+qLN1BgrjCDF2S0d57OjcTMGjtEBxDqbKr+0UodTVNYSMVw ejycU0XZlUBkWLJ+/QkNolv69f2yjTjrnxCOqNWSYBWuH5OXe86bo2atOaneRDLY6HdX P+f6B2d/fmhLnmtHkhOzmr0FVhGTf304mFzu+XMmj5CVknamRxG2mtlyx3AQ6c2Jxkwa XTkCG4dexqUnoXS+2ctn5X1g+1xlKDahAf5AxCksReyBm8L4cbA2vfPLHndu2W6gp9Gr 7+iAKe3BRBJWV/jXWZfHeg7HbP+eiG9hxd+qG/HkCoEeESCybJkUWkDgW3YaBYBwS/QS Xu4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2mmsCjLT2rRTJyNdR4O0/WlJXuh4vH+sUR57NoOahg0=; b=PnZcdRf8eFvxr43wLRkNrqqZXHQjtZo3nezDPsAMk0POwHz+uMUbGVOIVcZGti7tKS /iUqPj8q+4I2g/Y+TLX3Qh/GQrqjZ8pcy4RjIZB+1jOgXLswsphrEU9AygBpm2HxC8U/ ZAfS8Xb/esGrTeGRQIJWFFSCtHUIylgS/eENOh3+NHsYPJGw1rlqh+ECKn5Q9rokbLXV +6fsISG9lmFeR+UwpLM5m4rpqbN7dzK9lY1wbOUvItuyL3mF4DgT80P/XpHvpAV5/vMA 8thjkn1fkDmMdaQKc9jgHq8uD8sNI4klkcV21hXOjm6mmMpjDgKMZ2oc0cJ2AaUnnpEV vCPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Z5iOOhtu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n11si2824445otk.290.2020.01.24.06.21.13; Fri, 24 Jan 2020 06:21:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Z5iOOhtu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387475AbgAXLA7 (ORCPT + 99 others); Fri, 24 Jan 2020 06:00:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:33208 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387461AbgAXLA5 (ORCPT ); Fri, 24 Jan 2020 06:00:57 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 318342075D; Fri, 24 Jan 2020 11:00:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579863656; bh=hHZ0r5koTcCu61eYNLhQfmBQtmAHcR0VNmlmXonSSHE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z5iOOhtuBtQRt82j4OoBCDrqpST9Rf3zDcHt2o5jOAm4n/c8B+//Wh7moLui6Fa85 lprU4V+9mAR/nK8jO3ahuliXbjdPVRw9ehYWW9C11SPFg1hs1oY4Tz5bvs3tVrrvIy csYab+egRtE3zJx8lfwoCkkqJGPEWNDLZBh4dfBM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Felipe Balbi , Sasha Levin Subject: [PATCH 4.19 039/639] usb: dwc3: add EXTCON dependency for qcom Date: Fri, 24 Jan 2020 10:23:29 +0100 Message-Id: <20200124093052.344471658@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit 3def4031b3e3fbb524cbd01555b057a6cef0d5e6 ] Like the omap back-end, we get a link error with CONFIG_EXTCON=m when building the qcom back-end into the kernel: drivers/usb/dwc3/dwc3-qcom.o: In function `dwc3_qcom_probe': dwc3-qcom.c:(.text+0x13dc): undefined reference to `extcon_get_edev_by_phandle' dwc3-qcom.c:(.text+0x1b18): undefined reference to `devm_extcon_register_notifier' dwc3-qcom.c:(.text+0x1b9c): undefined reference to `extcon_get_state' Do the same thing as OMAP and add an explicit dependency on EXTCON. Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver") Signed-off-by: Arnd Bergmann Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/dwc3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index 518ead12458d0..1a0404fda596b 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -113,7 +113,7 @@ config USB_DWC3_ST config USB_DWC3_QCOM tristate "Qualcomm Platform" - depends on ARCH_QCOM || COMPILE_TEST + depends on EXTCON && (ARCH_QCOM || COMPILE_TEST) depends on OF default USB_DWC3 help -- 2.20.1