Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp609428ybl; Fri, 24 Jan 2020 06:23:07 -0800 (PST) X-Google-Smtp-Source: APXvYqxi0Ce88mgCMSK+0lfXW3XcRXJFtBnA6dzAqffpzw7xNoaMC8f8xDj+4rF9gMSSjqlg3IBx X-Received: by 2002:a9d:470a:: with SMTP id a10mr2977934otf.370.1579875787691; Fri, 24 Jan 2020 06:23:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579875787; cv=none; d=google.com; s=arc-20160816; b=oOApwjo/RV22ePTjohD41qSGdR3riqqYe+/Z16KLoVUJFO9rAAEGlH6QTMJRJBSuV6 1qWeN/e6CWD7xdJ/Ww0CxAvXiXLfH2p8r+H3W6rCmsrZwj9Bt+wgduldJHk8T3dc7vj6 8SHNyFJbqBRZKT7p3ManrFWEuSHDBT+XJaDqvs50Lg79pLafnnAWZNN7HOVSD4RPX7uO jEicWAVMxUxH+sodzqSNgHrPmvgLj95VXZUJVJhqzjx9y7e+hibX7gn+EwtqciFONzDi htYktV7Mcz9enWTp+S23X3ICsZROIaW4jcR82U/kiXenPjOP1ByM9GaHu8dB6TlfWOUJ P+Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=GirotC/DDclXYyGHfSX37ZO7hnnumEq3om8IcFSo7i8=; b=Usy6XM0q3xtkfGVQ4ae1kxbrWMTsF2f2yXekBBTQ8yw2BiOmGCCeIhiX+xR+yT4wwr RFEcDeSuNvMks2VqgwebjOxBDR42YQMARA84KKXzuLF8lbpjRTngBuydhT90Ivq4VO3y m7G2xxHhk0MXq6WwQGahF/Y7OyhOvLor8tR3bMb3z+bG8MqL4sdeWnr4XK8pSk56OPz/ YDXP6z33TsY+OzcvYC/TUUXvYtjaOPG9S02tu8ba6ww8j8wk8HHZqGU7G52UnWKZaDy4 W5HV9xTAQgFJSJHi/VJQcczCZOJbEb5PiMdB6VSJmNCVr2g+NOlVZemqBn/g7f4LhH+P vO9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2mmuYU6S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f89si3161544otf.231.2020.01.24.06.22.56; Fri, 24 Jan 2020 06:23:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2mmuYU6S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388032AbgAXLEU (ORCPT + 99 others); Fri, 24 Jan 2020 06:04:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:38324 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388458AbgAXLEQ (ORCPT ); Fri, 24 Jan 2020 06:04:16 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 857902075D; Fri, 24 Jan 2020 11:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579863856; bh=9kGmsPvxyK6zjwEok+yfdcPPcLazU72h6rWtyF4TURw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2mmuYU6ST7+utOCWHVq+SplFAsoNwdsExmSu+h0TJWQqLClrX9AF8pmVkg2CnBcTX EhArWCYBl5SgwfxWVQV9Eg/SOBMu4ZT73dxn5MMuZTxKTrTw0Gf+NF8W1a9BvzVszC WOm554axvUDDrdnDBfx9czE9uhmws1gsIhs96ScI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yangtao Li , Stephen Boyd , Sasha Levin Subject: [PATCH 4.19 106/639] clk: imx6q: fix refcount leak in imx6q_clocks_init() Date: Fri, 24 Jan 2020 10:24:36 +0100 Message-Id: <20200124093100.633236098@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yangtao Li [ Upstream commit c9ec1d8fef31b5fc9e90e99f9bd685db5caa7c5e ] The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount. Signed-off-by: Yangtao Li Fixes: 2acd1b6f889c ("ARM: i.MX6: implement clocks using common clock framework") Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/imx/clk-imx6q.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c index c509324f63385..8ddf9b1f1677c 100644 --- a/drivers/clk/imx/clk-imx6q.c +++ b/drivers/clk/imx/clk-imx6q.c @@ -424,6 +424,7 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node) np = of_find_compatible_node(NULL, NULL, "fsl,imx6q-anatop"); anatop_base = base = of_iomap(np, 0); WARN_ON(!base); + of_node_put(np); /* Audio/video PLL post dividers do not work on i.MX6q revision 1.0 */ if (clk_on_imx6q() && imx_get_soc_revision() == IMX_CHIP_REVISION_1_0) { -- 2.20.1