Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp613667ybl; Fri, 24 Jan 2020 06:27:44 -0800 (PST) X-Google-Smtp-Source: APXvYqyIy6KyXPRFGlULEqLsu0f2NOgfE9pA78Ztr0SkL0L3dIvKgbJIbA0LWjt4yUSo2lsCC4va X-Received: by 2002:a05:6830:154c:: with SMTP id l12mr2826604otp.275.1579876064032; Fri, 24 Jan 2020 06:27:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579876064; cv=none; d=google.com; s=arc-20160816; b=N58bmrEb5+VghFVmaUYeUgqxBwGO4glvVtbF0BgHWstOQ9xoyFeemLj9kQV/ANZmIr uFrKbRVETuoSN+2XJpH7oe8wBFD9/UlZ+geEDLzkynXEtrkoTAAK4xLMxI2YfUO0Tfgl 8VGU391dhg8IcxFWnber3TVqHn8KZCbtLrix7MR0wYwzh72LdZBUjPGefkOlMUJV3zv2 JBqtlG8BEfKgjiHV7dj8ALC/CW471HF51SEeWtzsSEL34fmLjR1CC71hwtNnS1JBNNxt ZoUMS8f5pKbdbptoj89Zn6a+8y0Wb78GrgvQSay1QZyswjHy+oOb5fEvyP/2nuOdeVku j44g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Tcx8CTZnfa3914Ip/GpiMdQsxGxrh6Pz4AR4L/VbsSw=; b=00u3U/dFkpWJUBFuieoAmR83onUukpBUtj3079ac+lW8Wr9TQty7iXLP5WoMlNDPfB Lu7Fb3whH8ztmOdvRVFmJiVyn0P5kkWjD8ufADjwcOvR6wElWsaQSURCF/euajoJkhGM IeHs149fOnqjFq/1Te3kcs8Kc+NuzgOcPC1dnDTlhdcjMvAR9sp3LdFq5cxt22sgribP ZfyCfpJ3DS3eA36a3Mk3HQi/B8FeZzxs29asQixPwraOSglqTjle1VYJyDZYrcgRwRCu t3mfECjJxEcvko7M7wuM04FfIPMsHThHs2ZqLYUn1KHZ1bF85a6982Ol8/tnaWth2V8W 3yCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yFXBlbqw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l14si3000221otk.225.2020.01.24.06.27.32; Fri, 24 Jan 2020 06:27:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yFXBlbqw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390629AbgAXLSU (ORCPT + 99 others); Fri, 24 Jan 2020 06:18:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:55356 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390623AbgAXLSS (ORCPT ); Fri, 24 Jan 2020 06:18:18 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5405D2075D; Fri, 24 Jan 2020 11:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579864697; bh=+o2ItOrpXjMGegFkdt3WLY/3y07xBRwUnmRwb4ZqWGs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yFXBlbqwOc9S1gLnmHlbLqt8bs0jiMmEf5/sgaweh6N4egGhQkEmOfYvELytU17OD IqjY58bB5UepMk4tQy0mrHrKJEFYua5G65ANn7f0bXGJ/87VDwklZnyHu0Ji2dAR4W JPlh9WOXfTfr1Wa8otec+6i/qe9R4CC27uvcyQcs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Trond Myklebust , Anna Schumaker , Sasha Levin Subject: [PATCH 4.19 327/639] NFS: Dont interrupt file writeout due to fatal errors Date: Fri, 24 Jan 2020 10:28:17 +0100 Message-Id: <20200124093128.083330329@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Trond Myklebust [ Upstream commit 14bebe3c90b326d2a0df78aed5e9de090c71d878 ] When flushing out dirty pages, the fact that we may hit fatal errors is not a reason to stop writeback. Those errors are reported through fsync(), not through the flush mechanism. Fixes: a6598813a4c5b ("NFS: Don't write back further requests if there...") Signed-off-by: Trond Myklebust Signed-off-by: Anna Schumaker Signed-off-by: Sasha Levin --- fs/nfs/write.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/write.c b/fs/nfs/write.c index 117ffd90419e2..e27637fa0f790 100644 --- a/fs/nfs/write.c +++ b/fs/nfs/write.c @@ -646,7 +646,7 @@ out: return ret; out_launder: nfs_write_error_remove_page(req); - return ret; + return 0; } static int nfs_do_writepage(struct page *page, struct writeback_control *wbc, -- 2.20.1