Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp676113ybl; Fri, 24 Jan 2020 07:33:22 -0800 (PST) X-Google-Smtp-Source: APXvYqw8ZTs5FpINtBUHCdy3yFVKdFjCLNbPHXG62TkhBugnl8zqaVCU+6Kht3OrT8LFdzuFdkQg X-Received: by 2002:a9d:d0b:: with SMTP id 11mr3190844oti.287.1579880002600; Fri, 24 Jan 2020 07:33:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579880002; cv=none; d=google.com; s=arc-20160816; b=N36LbYTJvA578onp5UsZSSLrhV1s035ixavvxxye+ZFe77CDlLGh5Bkev0+NogdfAZ ki8IH7meeq+6W3lTaFaV6WewPliKnirjI6Tsea/cUrXPNIYgzhL1t/e0krCbx7WUgdEA sqnb3vSkLDdBmm8lZhkezXuQYLLmgWK3drz+kZB/A5ZDzHr4B42bqDt+RECrlPTbGP1X bFo1Usiyu4pi/eQKLVPjHBHJ5n3Tq6/sSnBgwmplhemy3NDNbcqXEXI/TTDb/kghAFhx eRsAmhH2NbfWgB8gxOKiGmDvcEqTZ93C6uR/y0O6twMWN7yXGH8ws+3YbAfzTqUJ0Isp /i3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=e3HpD4Zc6EveNHZ3dEd/V749ZBiLnHBnBfvMsfmaXEc=; b=r6HdqGMiOnTZaVTpPrz49nNxEDmNTtGusjiq1n2HbuBXiHq631fYKS2THWYE8886oA 0NMZUR9wqAbQqu7FrAnRJNVYFGU10MhhprwBeAf+kfEc4k5nzRwGNBDhvh2Ufi5XCttn G6V/2VA+zN4yIq2UnfIHFtkp4DX1z4gKjL4X2iHgMld4G7IwO6axZdURdfKPQBLdAqA7 GyGptyCL8oo0eiI3kZE5/NGTmvXQsNJo1N8hGvjULyCNLhEBHre0OwUSuOD4dfTmNX4S svfoRdjN0W6OpQhnPcQuoXIUFw7TOnbiL+KvgJ8xHFRxDt0BlkcO/q91wL+qViwH7Cu3 7qkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KOv8Mrj4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l26si2784708oti.152.2020.01.24.07.33.10; Fri, 24 Jan 2020 07:33:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KOv8Mrj4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389155AbgAXKEr (ORCPT + 99 others); Fri, 24 Jan 2020 05:04:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:41178 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388948AbgAXKEo (ORCPT ); Fri, 24 Jan 2020 05:04:44 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7D394218AC; Fri, 24 Jan 2020 10:04:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579860284; bh=QewKoEJlIRAHjoP4tt654qmdwr7ZKQY39OMFwub97Ns=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KOv8Mrj4jrj9LUTL9Tq9YJ8akZbYiCY1tg+SeCL6RkZoLrNaC7wqBshUaLrQSqfbi F38xdf5sT0e5bbrw/FKypKa15OYW5vglHSS0iND1ayaMSXa3RjpCuReO8uS0Hdcgrb WyCdlVSS5nuwQFUmSBdnQefuIt4DKfdUXyZjBWX4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mao Wenan , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 302/343] net: sonic: replace dev_kfree_skb in sonic_send_packet Date: Fri, 24 Jan 2020 10:32:00 +0100 Message-Id: <20200124092959.624669148@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mao Wenan [ Upstream commit 49f6c90bf6805948b597eabb499e500a47cf24be ] sonic_send_packet will be processed in irq or non-irq context, so it would better use dev_kfree_skb_any instead of dev_kfree_skb. Fixes: d9fb9f384292 ("*sonic/natsemi/ns83829: Move the National Semi-conductor drivers") Signed-off-by: Mao Wenan Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/natsemi/sonic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/natsemi/sonic.c b/drivers/net/ethernet/natsemi/sonic.c index 11f472fd5d477..a051dddcbd768 100644 --- a/drivers/net/ethernet/natsemi/sonic.c +++ b/drivers/net/ethernet/natsemi/sonic.c @@ -222,7 +222,7 @@ static int sonic_send_packet(struct sk_buff *skb, struct net_device *dev) laddr = dma_map_single(lp->device, skb->data, length, DMA_TO_DEVICE); if (!laddr) { pr_err_ratelimited("%s: failed to map tx DMA buffer.\n", dev->name); - dev_kfree_skb(skb); + dev_kfree_skb_any(skb); return NETDEV_TX_OK; } -- 2.20.1