Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp717663ybl; Fri, 24 Jan 2020 08:17:43 -0800 (PST) X-Google-Smtp-Source: APXvYqzRjo8GCQlCUYVGFI7I07NUljuoIITZtAp8ptIdbyq0KOTmNPjMBQrkuq6uqHObZsVp7K9j X-Received: by 2002:a05:6830:231d:: with SMTP id u29mr3449247ote.185.1579882663706; Fri, 24 Jan 2020 08:17:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579882663; cv=none; d=google.com; s=arc-20160816; b=tyF84i3oTC/N/AMQtqHSLav5h76qcWSmlfWLl5mFKNZOjCyWy/JuTnthi+ZJESQiVT X2Q9AFTSj3PrrXXCspklSbTA9XK/ESby0o5xD8ytSB6WyeMO2X7sdsQl5i6rlZTs6oOQ RF4LA4ykWpFxwjz/LE3qG2l/j9CN5sOMJROuGHyNuKsoX+qChGLspaCDJXg/44YDGg3r LF25fGtndPUYhFmUIcvFZZTr4QF+P10eNjF3XejjeemuUS5Y+d+j6Qbh+RxgBquoRFue PP6SJkPPkfk1IALc5df8CP5OH+AAveOEP3nOiQtyrf0BrtjXM3Tcp87ib4TKhFZ/E+j4 MeCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=90RNsoV4SbDRJFjXuOiaQKzn/FbnAzU0C0wxFIVNe2k=; b=Z1tqyXRxxxn96fRJJ7Do9iahO4P743m5Q9xc8fkBmRWesNXRVXWCqLDYio3FnPrcpG Q8334NtvpbBfFIcrr9Nw1rxpj9r0HcNRhMu4ejdXpIXl5pbM8Wr9bwvf0cnIwDVs0tai iTjwxlAI8LmvFckw0aRnK/Q8BQ+q9P5cxw3uIWBwYQfJKwU3IPi2QYC/0CM6z2ZOIN14 E6pVtiLqpuaxwoLTKMGZLKJV9X/xtE4L3o4MSsZx9Y8rkK7jJagfWpEH74WeZc8I7TBo 7zy1GZr+0+3kNRznKhP+bkZDm6JqagQTnnodHcbNh36juIjWMqQFyUOKzFIBhbuo9kc5 zPZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="t94HsM/r"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b137si7568oii.63.2020.01.24.08.17.32; Fri, 24 Jan 2020 08:17:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="t94HsM/r"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387406AbgAXLAs (ORCPT + 99 others); Fri, 24 Jan 2020 06:00:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:60910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733286AbgAXLAq (ORCPT ); Fri, 24 Jan 2020 06:00:46 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 799612071A; Fri, 24 Jan 2020 11:00:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579863646; bh=1NsGV94png0klvDL1K/LNL6Q3FdShQSloHuWw/2IpDg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t94HsM/r2o7bPJ7uhNt5VQz69UXz58xEXVn+L7FYITCHil0l60CK8fu46n1sCq6MZ DyW5PrGBdjR1QiYpJWIgpxz+p4HyXh9d1rUF+9c4d1e9p3EqBGEn/gPtB8w8x3ngCr U74upd/ExZLtuYXo5lkXZFuoT5fn3Ve8xbqv/NHk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Leon Romanovsky , Zhu Yanjun , Jason Gunthorpe , Sasha Levin Subject: [PATCH 4.19 036/639] IB/rxe: replace kvfree with vfree Date: Fri, 24 Jan 2020 10:23:26 +0100 Message-Id: <20200124093051.966032768@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhu Yanjun [ Upstream commit 721ad7e643f7002efa398838693f90284ea216d1 ] The buf is allocated by vmalloc_user in the function rxe_queue_init. So it is better to free it by vfree. Fixes: 8700e3e7c485 ("Soft RoCE driver") Reviewed-by: Leon Romanovsky Signed-off-by: Zhu Yanjun Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/sw/rxe/rxe_cq.c | 4 ++-- drivers/infiniband/sw/rxe/rxe_qp.c | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/sw/rxe/rxe_cq.c b/drivers/infiniband/sw/rxe/rxe_cq.c index 2ee4b08b00ea4..a57276f2cb849 100644 --- a/drivers/infiniband/sw/rxe/rxe_cq.c +++ b/drivers/infiniband/sw/rxe/rxe_cq.c @@ -30,7 +30,7 @@ * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE * SOFTWARE. */ - +#include #include "rxe.h" #include "rxe_loc.h" #include "rxe_queue.h" @@ -97,7 +97,7 @@ int rxe_cq_from_init(struct rxe_dev *rxe, struct rxe_cq *cq, int cqe, err = do_mmap_info(rxe, uresp ? &uresp->mi : NULL, context, cq->queue->buf, cq->queue->buf_size, &cq->queue->ip); if (err) { - kvfree(cq->queue->buf); + vfree(cq->queue->buf); kfree(cq->queue); return err; } diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c index c58452daffc74..230697fa31fe3 100644 --- a/drivers/infiniband/sw/rxe/rxe_qp.c +++ b/drivers/infiniband/sw/rxe/rxe_qp.c @@ -34,6 +34,7 @@ #include #include #include +#include #include "rxe.h" #include "rxe_loc.h" @@ -247,7 +248,7 @@ static int rxe_qp_init_req(struct rxe_dev *rxe, struct rxe_qp *qp, &qp->sq.queue->ip); if (err) { - kvfree(qp->sq.queue->buf); + vfree(qp->sq.queue->buf); kfree(qp->sq.queue); return err; } @@ -300,7 +301,7 @@ static int rxe_qp_init_resp(struct rxe_dev *rxe, struct rxe_qp *qp, qp->rq.queue->buf, qp->rq.queue->buf_size, &qp->rq.queue->ip); if (err) { - kvfree(qp->rq.queue->buf); + vfree(qp->rq.queue->buf); kfree(qp->rq.queue); return err; } -- 2.20.1