Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp721202ybl; Fri, 24 Jan 2020 08:21:32 -0800 (PST) X-Google-Smtp-Source: APXvYqxGkHvXFkvctj0t04hCxc50Rfk0TZM+0BdN6Ir/FXG0jY2dBcZ75n81HWRZr/KU/g661PQS X-Received: by 2002:aca:5490:: with SMTP id i138mr25852oib.34.1579882891986; Fri, 24 Jan 2020 08:21:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579882891; cv=none; d=google.com; s=arc-20160816; b=SDUthATKN10ZI2LQFEG5JD91eWlxEW4n+/GuybdM7sDnfMMT4b5tdi3ylibTlhiwEC T7oRUT/4fFRmTIufeTluV3LEUS82jNRHj8EcV3s8fexcWYCe/hlqdw5CMnKrLbeAroY6 Vm8bMh5izpviIyB4NuKwn3ulxC0XbSqKGec0nxHdlDfGA+JmlDLenB7147X2W3ETM9ap 55koNJgt23YPvhBzgEX/xLtlQELXdhx0hCy24aHNraMjoZ1B0dsqcUn4y5vxTaIFGcMU igPaz+CFgb3wAytafHNvsT2P6BGMQeItYuzxJXYqpAOuYUTIQafOHfC23WMumtY1FYrp gn6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=D9usdSF16VUSbMojQKiwPqRcpaPgNgQn3VFrCXgF7yY=; b=b5+Md0hDZTVgD+nM3j1d/gnHbDOnY29PiWhJIOKgYHIlA/FE0mAkb9GR7vbLLOvFYh OSYE6EEza4R8GELUX7vcU/Wg94ISBrrBciKR7ukO2oWc+oJ0MYJq/ZdFKq7RM5U3aT+f yON0+mJCjRLW058rGZ799avwO46iFwXTHjSI8I8tDctpGbywpngO7m9+hKQujIjDvIg8 7uKsYrJ2fWVJNxk6h8YbI0Du4keG4Bse8zZ+SHP6DXPOl131Ru9/DuZgX7jzJluF0MTR 2+p+tIPYHIafXpf8DtGtNxek1cPExXXruTK5SAn8o3ybNNQcK8HPUpEJU2rAX67Kvlql w54A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZGmEckPj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f25si3020431otl.36.2020.01.24.08.21.20; Fri, 24 Jan 2020 08:21:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZGmEckPj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388832AbgAXLG1 (ORCPT + 99 others); Fri, 24 Jan 2020 06:06:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:41108 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730222AbgAXLGZ (ORCPT ); Fri, 24 Jan 2020 06:06:25 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69C4E2071A; Fri, 24 Jan 2020 11:06:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579863985; bh=+usNTdRjwYvntG+3pkqYcKVDxPiWH6pWpC3z81O3kAo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZGmEckPjbNqdi7H/l1AqPzNeBbHQrZdQds2N+TznHhr9Nn755E0O74+Se4dmDPKrB WRhqDOQEx0CqGZ+7xmbsZFoBLe84htIt4uLBVQH52yYyHsTAjQgt/u8/OO+KSqOMm/ 2WrP+0ObQhLmM/Abr3nBER2oIudYrLPaOfDo/qbM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Gal Pressman , Jason Gunthorpe , Sasha Levin Subject: [PATCH 4.19 125/639] RDMA/ocrdma: Fix out of bounds index check in query pkey Date: Fri, 24 Jan 2020 10:24:55 +0100 Message-Id: <20200124093102.963229325@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gal Pressman [ Upstream commit b188940796c7be31c1b8c25a9a0e0842c2e7a49e ] The pkey table size is one element, index should be tested for > 0 instead of > 1. Fixes: fe2caefcdf58 ("RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter") Signed-off-by: Gal Pressman Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c index c158ca9fde6dc..08271fce0b9e4 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c @@ -55,7 +55,7 @@ int ocrdma_query_pkey(struct ib_device *ibdev, u8 port, u16 index, u16 *pkey) { - if (index > 1) + if (index > 0) return -EINVAL; *pkey = 0xffff; -- 2.20.1