Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp817272ybl; Fri, 24 Jan 2020 10:03:58 -0800 (PST) X-Google-Smtp-Source: APXvYqxjtf1EL5hCi16qBgWb/i44U8xTaDNrvZT513Pb9gJfbGYXxzxDshLVdHkYN3n77VQHEgGn X-Received: by 2002:aca:5793:: with SMTP id l141mr46517oib.38.1579889038417; Fri, 24 Jan 2020 10:03:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579889038; cv=none; d=google.com; s=arc-20160816; b=RUTIewM4ynAu5N0VB9av1SV83p1tQb25AHp/xbY1zBFayCxh5FEfWRVJfl3iKmitty kcBpNHP4z8DmgRehct7RZcGh2UfacYdV5dfGXWB8wSvBGE9UFHqCMjPHWAQ9Lj7vdYp8 w+z04h1t6K5oZ73UIVPz3NTPOVcq0OSPYh2jUIGdr9oQxjz50aCIBXlKe4B5vXN6xH8o zhgT/kP0IeFxoSD2TNGOAyQtMyeoNzWACTG54V1Q3Jdn3b7HqKdQJ/qikWOPpZu+k86d 0p75lDTF5FFy+2EPY83e1prds3VDY1moZrowEbTjB9Xmxx69CD3s9FDn5oykkj3l/zIn oI+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SjvtFfGu0FzO/AioFGPcMZzOgWVOw5no4KzhkZtW8/o=; b=gzbT6shCkMVpBqhuAtL47IOzyt8XX2NDfJqcVe0R40Xi3UmxTtleDHkHO/6UArUbFP 9TBX/qqRiMr8EKUstsQcbIpvEMkqf9IuVdlisfOCmG+yRqnxzVZWtLDrzADxvQLgbxdl vMHqadJAq+U6Cbj329QcHupygtmTIOA8AdGF+11plAYCgPFm6COqeOHwYY8KONvZKABe YZTNeXX8UqGTXZ/0wieJ+SvH8XXAQLH6N704a6xlD6r0cUjU0WGKJ9Dl1C4UoOtKrIfd mNJFVmgTB6quSUrJSjFlbmFwGbUhN2MkDxPVkOHnXy+UKXE4I4iZGMGIZDpq6+BGDJDD 8Ptg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iUr0Uebs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k7si3406280otp.22.2020.01.24.10.03.41; Fri, 24 Jan 2020 10:03:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iUr0Uebs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390387AbgAXLTG (ORCPT + 99 others); Fri, 24 Jan 2020 06:19:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:56450 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390738AbgAXLTC (ORCPT ); Fri, 24 Jan 2020 06:19:02 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A99B62075D; Fri, 24 Jan 2020 11:19:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579864742; bh=opLE3wfI+Lp//yznFkRRvzNM6aKCNoVlcd0Pyau7/rU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iUr0UebsIgdpMmE7GsG09mzlYkPMIz0vwHHnCryuhxpMyE9WEd0OJiz+VID+QwCio TVoa7K4lqmV/5yJUI9s2XluewYqvsvq++e8VAaynKONoim3o8J+Uc8QQXyDE4j7hOp Nq6JQ4gSWkygSlZiDwXjVX6CmCqgstNQt3B1NZwE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Felipe Balbi , Sasha Levin Subject: [PATCH 4.19 340/639] usb: gadget: fsl: fix link error against usb-gadget module Date: Fri, 24 Jan 2020 10:28:30 +0100 Message-Id: <20200124093129.746711294@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit 2100e3ca3676e894fa48b8f6f01d01733387fe81 ] The dependency to ensure this driver links correctly fails since it can not be a loadable module: drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_set_peripheral': phy-fsl-usb.c:(.text+0x2224): undefined reference to `usb_gadget_vbus_disconnect' Make the option 'tristate' so it can work correctly. Fixes: 5a8d651a2bde ("usb: gadget: move gadget API functions to udc-core") Signed-off-by: Arnd Bergmann Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index 91ea3083e7ad9..affb5393c4c6d 100644 --- a/drivers/usb/phy/Kconfig +++ b/drivers/usb/phy/Kconfig @@ -20,7 +20,7 @@ config AB8500_USB in host mode, low speed. config FSL_USB2_OTG - bool "Freescale USB OTG Transceiver Driver" + tristate "Freescale USB OTG Transceiver Driver" depends on USB_EHCI_FSL && USB_FSL_USB2 && USB_OTG_FSM=y && PM depends on USB_GADGET || !USB_GADGET # if USB_GADGET=m, this can't be 'y' select USB_PHY -- 2.20.1