Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp862597ybl; Fri, 24 Jan 2020 10:55:06 -0800 (PST) X-Google-Smtp-Source: APXvYqzlQSIRdfvEVzxcnQJ/orRYEVeHwlI95ZeG0ZWLwmiXHm4/m/rndIqvpkS8RyrLd+JqZTtZ X-Received: by 2002:aca:ed81:: with SMTP id l123mr149997oih.129.1579892106537; Fri, 24 Jan 2020 10:55:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579892106; cv=none; d=google.com; s=arc-20160816; b=ReOAibB9xngKWmiHt6zyyTJBKU51aNOutWAPgnxndvd/6kjlLPqkVyjoblIr+N7v3z d2f4m9/cGmNLI4SNwlWao6t6hf40ncJuraiLvKddz8ui5DKaBZU4ITEaVa8kv+OKvGHG abRRqYKNkMr8FBhJMeCjUv2G5YRAwliSw5oTP8DQNuTdMNTZmRsMveBsajEL0TuhQdCg 4Yo3nO6L5VycefqSMlGg8BUQATPNUsH2UbmmcUnY5A0mqoW8VKD6mdwNfgkr5Ga81Blr I4Y2gkO1WrqShxAY1jh4C1RxgaUrcwXu7ASELltYfeFfW545t5LRbeaVeAN9+xus6YyT /Iyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=N2knUXPR56FDgXLj2GUgRQAye+iVatMXCHquY68jO8g=; b=Y37fVlbvueHBlzeGJKAxl/n3sKoGt5TuHg9AxIAGb3uWJuq0hq+AcPDdqf1zQFS8yL 4gV59FMVULkHv0PLsDVmfLqFdIkLmLf9YDXcehQsByY5bwYmeHqGL1jWpOFe9cQho2mQ 1GyVozf8uqZe9tvZwiQZ9WPkzUFRZ9YPwXbW5EPK8IjKBfN0VpZzAzW0R4vXHTSb+taT vM3YwiVPA3jfBogRWF+TSItwigs3dFFj3h8cjWurdRG0AGRLX3KnmG9nex8FW+QhtJqg lcvfqwApSCoXB4YfvNSx7Aq8xgy0GR7U0zAQ9g6IWe7ML9lfWYT5BhnLQ+koUW2xBkUV MS8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pR9E69VK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h21si3363037otr.235.2020.01.24.10.54.54; Fri, 24 Jan 2020 10:55:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pR9E69VK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404059AbgAXL2V (ORCPT + 99 others); Fri, 24 Jan 2020 06:28:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:44430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404049AbgAXL2S (ORCPT ); Fri, 24 Jan 2020 06:28:18 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4130D206D4; Fri, 24 Jan 2020 11:28:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579865297; bh=VZz1Opl8GuC9mzCI6Ek2/0yoM9cZFcxhYqGvex0IluU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pR9E69VKFanTZqgqWgA+jQu76r/Dp3bkJS1pDYAGcMh30+dHihcRnob2nWsI1w6fK IxSopS0YYWSt1aCq6QJNgMH7MmseeRZ/5YnP026tvLGMbGkC7vo0+a63kaMMnMsbmn KVTV9Wbeo1eSxF5Z7J1EYcRdnidNB8JvFjeUTHkU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Steve French , Ronnie Sahlberg , "Eric W. Biederman" , Sasha Levin Subject: [PATCH 4.19 495/639] cifs: fix rmmod regression in cifs.ko caused by force_sig changes Date: Fri, 24 Jan 2020 10:31:05 +0100 Message-Id: <20200124093150.776736298@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steve French [ Upstream commit 247bc9470b1eeefc7b58cdf2c39f2866ba651509 ] Fixes: 72abe3bcf091 ("signal/cifs: Fix cifs_put_tcp_session to call send_sig instead of force_sig") The global change from force_sig caused module unloading of cifs.ko to fail (since the cifsd process could not be killed, "rmmod cifs" now would always fail) Signed-off-by: Steve French Reviewed-by: Ronnie Sahlberg CC: Eric W. Biederman Signed-off-by: Sasha Levin --- fs/cifs/connect.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index a59dcda075343..a8790bf04e95d 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -970,6 +970,7 @@ cifs_demultiplex_thread(void *p) mempool_resize(cifs_req_poolp, length + cifs_min_rcv); set_freezable(); + allow_signal(SIGKILL); while (server->tcpStatus != CifsExiting) { if (try_to_freeze()) continue; -- 2.20.1