Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp879544ybl; Fri, 24 Jan 2020 11:12:33 -0800 (PST) X-Google-Smtp-Source: APXvYqy02X7+iIGiCpUnqO3GiDLMyhMsHh4DTlEMfFJHojpg6n8Pac8f0Q5ciIq0aqanCXbiDeWl X-Received: by 2002:a9d:de9:: with SMTP id 96mr3915676ots.222.1579893153394; Fri, 24 Jan 2020 11:12:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579893153; cv=none; d=google.com; s=arc-20160816; b=0YkYLZshCBYjHCHr5U7mi0VRtkbBHVfTuwVBr9pkBstLcGjFWuVvvsfdqnXgWuPOYr 25ERJEAR0dk3jV7qPprEOcCAW+e3Ns9p81x5ftY0ykZLI59yFf2tn/fQQMW1ef8OViP7 74VY04/Usa75MrAy4lsyk7zeD/XjWtmM/mpJKx/Z8Zo7KNSpqFZsCP4+kVeKj1YbJeUD K1zDyIxpwF6CRfSA8UCQS5ufYuamW7zxdzPsdVdd+VUmkNukFj/E86bnrUWVyv08uCXw bFVNZaH8Wgia/wMfXSU8tqx7NbTLu4lJ1PUOELTbruoxwc9fCobdirWyCN5l4CRmmO+b m0iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Hj1OWAzlfh7XpLl4sRuJ8vdPdCNVophU+qHDxUym3Ug=; b=cg0KC/cNnDr69ALciLAWXgk9qrboJ7TMXALV/a4AxEAPEBbFreRLKIGmsaCbxQEA2Q pdC2LkAdTSqhTl1dRjRcoK1MFVqc33WdFgo9NbqUvQ+HtVMIX84DzTrmOckNA9MA6XWK Sey5yBSGCM415D9b5aODfVQgxKfy76pgOFkmcdxIaYbxlnHRsmkjQ7sgrXo5Y9YvGM9S 1e2Olo1iIkhplcX3Su3hJ4P359BAjZLWEhRCxHw3miS16y2aYSyOdHGeiqqO2de9r0ln stcVqqJSwdG3NS/n/7MEwj9FWF7JIvwYab13OZKnM4Xd84aLoPQPnT0QBvB/TA7Wr3OA 1eCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="R0w/ngml"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w29si3729942oth.313.2020.01.24.11.12.21; Fri, 24 Jan 2020 11:12:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="R0w/ngml"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404358AbgAXLcg (ORCPT + 99 others); Fri, 24 Jan 2020 06:32:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:51356 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404437AbgAXLc0 (ORCPT ); Fri, 24 Jan 2020 06:32:26 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5E0BF20718; Fri, 24 Jan 2020 11:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579865546; bh=x4X64ze7Gkby5ghBKDeSUN+zScMvvgWQel2F1YrZ8vU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R0w/ngmlS26PEI458v2EHIf5ruK4DRsEaJf98yx//hYKqUs2JkArIto/er/mtq/aA 9AkXKRTZOUpnsp/LVMUwNMNscPjQzU2CdV60ISrOt9bCLSyKBhr6+rfgksU9AhQBFQ ptnmxRzuNm/waCNHjlOfo0cS46CkJxGI0AdZGEW8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mao Wenan , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 559/639] net: sonic: replace dev_kfree_skb in sonic_send_packet Date: Fri, 24 Jan 2020 10:32:09 +0100 Message-Id: <20200124093159.342865144@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mao Wenan [ Upstream commit 49f6c90bf6805948b597eabb499e500a47cf24be ] sonic_send_packet will be processed in irq or non-irq context, so it would better use dev_kfree_skb_any instead of dev_kfree_skb. Fixes: d9fb9f384292 ("*sonic/natsemi/ns83829: Move the National Semi-conductor drivers") Signed-off-by: Mao Wenan Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/natsemi/sonic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/natsemi/sonic.c b/drivers/net/ethernet/natsemi/sonic.c index be36f7117d484..5f1875fe47cdf 100644 --- a/drivers/net/ethernet/natsemi/sonic.c +++ b/drivers/net/ethernet/natsemi/sonic.c @@ -232,7 +232,7 @@ static int sonic_send_packet(struct sk_buff *skb, struct net_device *dev) laddr = dma_map_single(lp->device, skb->data, length, DMA_TO_DEVICE); if (!laddr) { pr_err_ratelimited("%s: failed to map tx DMA buffer.\n", dev->name); - dev_kfree_skb(skb); + dev_kfree_skb_any(skb); return NETDEV_TX_OK; } -- 2.20.1