Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp969903ybl; Fri, 24 Jan 2020 12:56:20 -0800 (PST) X-Google-Smtp-Source: APXvYqx3nxbz2NPUCORP7TimziUu9a27epI2md6cS16y2n1xor+aItqnoKoqjpsriFxtFwXwOVPJ X-Received: by 2002:aca:1a17:: with SMTP id a23mr493457oia.84.1579899380493; Fri, 24 Jan 2020 12:56:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579899380; cv=none; d=google.com; s=arc-20160816; b=0B9Mjl3nBPOj2/RjSGc+MUg2f6qsp4pd/tBt/E/6Kenc+UoxF3vSyU4cX8InNVLQDq 70KhWZILeKrNSZMYOSQOHf33+O15RbXmnDq94uizGr075G7pOiRDSnu+x/lIHcTmB4La aHhz7x02j6hZXSvKrazHNOdZVzLj+ha1uR+Gm9TRtue2rhKnPQfLhBN1xob1rXLErvHG eGCbSRPA/kAmpmoS0tWDCo89SYbfv53rDE1iwISjeKV1NvH1aXFI17D4JOs/3QylnVcv T4dIscBKWwA57GYMKoUY2liziX28FvShkniW2oxW7TK0GUth942SAFzmSetOkEo7B17E qtgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=RGn2IHBa7rMucV+pLzAZrr7Jhhs9oxLFIRG0ooqfrjs=; b=LsOyUWvdEpilCzgqi/GOzorJvWOCWY7P4Z5qL6jKSvHfVGBy/IyduRow+xrAXPp1Nr oT8Qnn/Lq01ROGwPDnzE3wViTId7V76eJ889Wz6+0rsiVdWA0Q1DOV8+mAyMzF2PbbWf V9l/lGt2KvGzhAC8JENUQyM/6wsJ2VjrqsM+sEkJUfsJBrgC5PhAxiGz1L7jsgiW2xyV 5W2BIjqLsRRKoYT20UfwNmzliYS/plFXziy+6pIILZNLfjeyg6y/hBvFiUAFGWx4YPju yRxALH6rgmo9UamHJAykMnh9B49LFy3cHjHXzBtYGQJv3gXaqbMezoUyiNvP/5RL4jWe VoSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ls5PpEst; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l189si314628oih.166.2020.01.24.12.56.08; Fri, 24 Jan 2020 12:56:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ls5PpEst; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387854AbgAXQaN (ORCPT + 99 others); Fri, 24 Jan 2020 11:30:13 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:36107 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387536AbgAXQaN (ORCPT ); Fri, 24 Jan 2020 11:30:13 -0500 Received: by mail-wr1-f65.google.com with SMTP id z3so2723520wru.3; Fri, 24 Jan 2020 08:30:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=RGn2IHBa7rMucV+pLzAZrr7Jhhs9oxLFIRG0ooqfrjs=; b=Ls5PpEstrt36pHLjCEV2vP/HZpfjm57O0FCJC3IhuSDlKJKzSXM8caQY1CVM34FgYw 0xDeKYV83in6cpD4ENdBgku7ptoOoeFRMu/CdmMIejkOGP6XdUfK4TSofnNSccd3mWEC nNTtQqaCzMOOzYTmdr6kRnAQPeEAiLVeHkrKzVZTBPOwNasD53e46udhJnukKMfV46qC 0q9opsuFTvHaCZs8tVK/LAtGmdGaaGG2tfrnohaCh6cxx4ukpSbFaBJbJxjDrH5S6/3G hYe3E2YNd41g93v3jh90Mt9ljqWZhTuyDXH40ehB+TgPCjLyRk/gg4DL1E3a5ILTfS0F a4mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RGn2IHBa7rMucV+pLzAZrr7Jhhs9oxLFIRG0ooqfrjs=; b=kwTZTqoqtwEZKbFZVoQkzSUaGPPGJ7mbWli1Kfb79wat6cWzwl3j0xHNiWGlb+xdAS RyITFTtqj9mwWJnuDM9Po9pqEQRSQNHPZ6r+whBiTBdA6saCAlvNZKbSx36uK/PRLM33 pYWiGMyffHNN677feThj/t1MOF3V39B1M1Q/E7mqPRdEe/oldqB9hKpivRHsT9XGB7Xv qXrU66aOR3PyXaC7DIi92cnkTNfdWslfw3v9zzBWBwQCVeqdrSnFdbNJxtmpOetlVCzc XfP6SogMGHdqlIL+Zj5/kTVOqyQKLFrFbjU6or8PQ8roxWaOHyt6HLAs3e9PPl3Es2rk qjqA== X-Gm-Message-State: APjAAAXz9W4QcCbIjVEgYr0otRTVwDzvr4u/5Kbck5cCjpODgFFfWQOA qYMZnthbpOhm201NaHg92IU= X-Received: by 2002:a05:6000:11c6:: with SMTP id i6mr5466569wrx.178.1579883409872; Fri, 24 Jan 2020 08:30:09 -0800 (PST) Received: from debian.home (ip51ccf9cd.speed.planet.nl. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id 205sm1977304wmd.42.2020.01.24.08.30.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jan 2020 08:30:09 -0800 (PST) From: Johan Jonker To: miquel.raynal@bootlin.com Cc: richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org, mark.rutland@arm.com, heiko@sntech.de, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, shawn.lin@rock-chips.com, yifeng.zhao@rock-chips.com Subject: [RFC PATCH v2 00/10] Enable RK3066 NANDC for MK808 Date: Fri, 24 Jan 2020 17:29:51 +0100 Message-Id: <20200124163001.28910-1-jbx6244@gmail.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org DISCLAIMER: Use at your own risk. Status: For testing only! Version: V2 Title: Enable RK3066 NANDC for MK808. The majority of Rockchip devices use a closed source FTL driver to reduce wear leveling. This patch serie proposes an experimental raw NAND controller driver for basic tasks in order to get the bindings and the nodes accepted for in the dts files. What does it do: On module load this driver will reserve its resources. After initialization the MTD framework will then try to detect the type and number of NAND chips. When all conditions are met, it registers it self as MTD device. This driver is then ready to receive user commands such as to read and write NAND pages. Test examples: # dd if=/dev/mtd0 of=dd.bin bs=8192 count=4 # nanddump -a -l 32768 -f nanddump.bin /dev/mtd0 Not tested: NANDC version 9. NAND raw write. RK3066 still has no support for Uboot. Any write command would interfere with data structures made by the boot loader. Etc. Problems: No bad block support. Most devices use a FTL bad block map with tags that must be located on specific page locations which is outside the scope of the raw MTD framework. hynix_nand_init() add extra option NAND_BBM_LASTPAGE for H27UCG8T2ATR-BC. No partition support. A FTL driver will store at random locations and a linear user specific layout does not fit within the generic character of this basic driver. Driver assumes that IO pins are correctly set by the boot loader. Fixed timing setting. RK3228A/RK3228B compatibility version 701 unknown RV1108 nand version unknown Etc. Todo: MLC ? ARM vs arm64 testing move BCH strengths and array size to struct rk_nandc_data Changes V2: Include suggestions by Miquel Raynal Include suggestions by Rob Herring Kconfig: add supported Socs rk3*.dtsi change compatible remove #address-cells and #size-cells; swap clock swap clock-names rockchip,nand-controller.yaml add "rockchip,idb-res-blk-num" property add hash change compatible change doc name swap clock-names rockchip-nand-controller.c add fls(8 * 1024) original intention add more struct rk_nandc_data types add rk_nandc_hw_ecc_setup_helper() add "rockchip,idb-res-blk-num" property add struct rk_nandc_cap add struct rk_nandc_reg_offset change copyright text change dev_err to dev_dbg in rk_nandc_probe() change driver name change of_rk_nandc_match compatible and data change rk_nandc_hw_syndrome_ecc_read_page() error message check return status rk_nandc_hw_syndrome_ecc_read_page() check return status rk_nandc_hw_syndrome_ecc_write_page() fix ./scripts/checkpatch.pl --strict issues fix arm64 compile (untested) fix rk_nandc_chip_init nand_scan move empty line above MODULE_LICENSE() move NAND_ECC_HW below NAND_ECC_HW_SYNDROME move vars from controller to chip structure relocate init_completion() remove nand_to_mtd in rk_nandc_attach_chip() remove page pointer write tag for bootrom rename all defines to RK_NANDC_* rename rk_nand_ctrl replace bank_base calculations by defines replace g_nandc_info[id] replace kmalloc by devm_kzalloc replace uint8_t by u8 replace uint32_t bu u32 replace writel by writel_relaxed replace RK_NANDC_NUM_BANKS by ctrl->cap->max_cs Chris Zhong (1): ARM: dts: rockchip: add nandc node for rk3066a/rk3188 Dingqiang Lin (2): arm64: dts: rockchip: add nandc node for px30 arm64: dts: rockchip: add nandc node for rk3308 Jianqun Xu (1): ARM: dts: rockchip: add nandc nodes for rk3288 Johan Jonker (2): dt-bindings: mtd: add rockchip nand controller bindings ARM: dts: rockchip: rk3066a-mk808: enable nandc node Jon Lin (1): ARM: dts: rockchip: add nandc node for rv1108 Wenping Zhang (1): ARM: dts: rockchip: add nandc node for rk322x Yifeng Zhao (1): mtd: rawnand: rockchip: Add NAND controller driver Zhaoyifeng (1): arm64: dts: rockchip: add nandc node for rk3368 .../bindings/mtd/rockchip,nand-controller.yaml | 92 ++ arch/arm/boot/dts/rk3066a-mk808.dts | 11 + arch/arm/boot/dts/rk322x.dtsi | 9 + arch/arm/boot/dts/rk3288.dtsi | 20 + arch/arm/boot/dts/rk3xxx.dtsi | 9 + arch/arm/boot/dts/rv1108.dtsi | 9 + arch/arm64/boot/dts/rockchip/px30.dtsi | 12 + arch/arm64/boot/dts/rockchip/rk3308.dtsi | 9 + arch/arm64/boot/dts/rockchip/rk3368.dtsi | 9 + drivers/mtd/nand/raw/Kconfig | 9 + drivers/mtd/nand/raw/Makefile | 1 + drivers/mtd/nand/raw/rockchip-nand-controller.c | 1307 ++++++++++++++++++++ 12 files changed, 1497 insertions(+) create mode 100644 Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml create mode 100644 drivers/mtd/nand/raw/rockchip-nand-controller.c -- 2.11.0