Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   Andy Lutomirski <luto@amacapital.net>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH] x86: Don't clare __force_order in kaslr_64.c
Date:   Fri, 24 Jan 2020 10:24:19 -0800
Message-Id: <E184715B-30CD-4951-BAF4-E95135AEE938@amacapital.net>
References: <20200124181811.4780-1-hjl.tools@gmail.com>
Cc:     linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        Yu-cheng Yu <yu-cheng.yu@intel.com>
In-Reply-To: <20200124181811.4780-1-hjl.tools@gmail.com>
To:     "H.J. Lu" <hjl.tools@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Jan 24, 2020, at 10:18 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>=20
> =EF=BB=BFGCC 10 changed the default to -fno-common, which leads to
>=20
>  LD      arch/x86/boot/compressed/vmlinux
> ld: arch/x86/boot/compressed/pgtable_64.o:(.bss+0x0): multiple definition o=
f `__force_order'; arch/x86/boot/compressed/kaslr_64.o:(.bss+0x0): first def=
ined here
> make[2]: *** [arch/x86/boot/compressed/Makefile:119: arch/x86/boot/compres=
sed/vmlinux] Error 1
>=20
> Since __force_order is already provided in pgtable_64.c, there is no
> need to declare __force_order in kaslr_64.c.

Why does anything actually define that variable?  Surely any actual referenc=
es are just an outright bug.  Is it needed for LTO?=