Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [Patch v8 1/7] sched/pelt: Add support to track thermal pressure
To:     Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Peter Zijlstra <peterz@infradead.org>
References: <1579031859-18692-1-git-send-email-thara.gopinath@linaro.org>
 <1579031859-18692-2-git-send-email-thara.gopinath@linaro.org>
 <20200116151724.GR2827@hirez.programming.kicks-ass.net>
 <e5ecad29-11d8-e7ff-27ff-b63ca44fdcd3@arm.com>
Cc:     mingo@redhat.com, ionela.voinescu@arm.com,
        vincent.guittot@linaro.org, rui.zhang@intel.com,
        qperret@google.com, daniel.lezcano@linaro.org,
        viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
        amit.kachhap@gmail.com, javi.merino@kernel.org,
        amit.kucheria@verdurent.com
From:   Thara Gopinath <thara.gopinath@linaro.org>
Message-ID: <5E2B405A.7040405@linaro.org>
Date:   Fri, 24 Jan 2020 14:07:06 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <e5ecad29-11d8-e7ff-27ff-b63ca44fdcd3@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 01/23/2020 02:15 PM, Dietmar Eggemann wrote:
> On 16/01/2020 16:17, Peter Zijlstra wrote:
>> On Tue, Jan 14, 2020 at 02:57:33PM -0500, Thara Gopinath wrote:
>>
>>> diff --git a/kernel/sched/pelt.h b/kernel/sched/pelt.h
>>> index afff644..bf1e17b 100644
>>> --- a/kernel/sched/pelt.h
>>> +++ b/kernel/sched/pelt.h
>>> @@ -7,6 +7,16 @@ int __update_load_avg_cfs_rq(u64 now, struct cfs_rq *cfs_rq);
>>>  int update_rt_rq_load_avg(u64 now, struct rq *rq, int running);
>>>  int update_dl_rq_load_avg(u64 now, struct rq *rq, int running);
>>>  
>>> +#ifdef CONFIG_HAVE_SCHED_THERMAL_PRESSURE
> 
> I assume your plan is to enable this for Arm and Arm64? Otherwise the
> code in 3/7 should also be guarded by this.

Yes. I think it should be enabled for arm and arm64. I can submit a
patch after this series is accepted to enable it.
Nevertheless , I don't understand why is patch 3/7 tied with this.
This portion is the averaging of thermal pressure. Patch 3/7 is to store
and retrieve the instantaneous value.
> 
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index e688dfad0b72..9eb414b2c8b9 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -164,6 +164,7 @@ config ARM64
>         select HAVE_FUNCTION_ARG_ACCESS_API
>         select HAVE_RCU_TABLE_FREE
>         select HAVE_RSEQ
> +       select HAVE_SCHED_THERMAL_PRESSURE
>         select HAVE_STACKPROTECTOR
>         select HAVE_SYSCALL_TRACEPOINTS
> 
> Currently it lives in the 'CPU/Task time and stats accounting' of
> .config which doesn't feel right to me.

It is cpu statistics if you think about it. It is also the same .config
where CONFIG_HAVE_SCHED_AVG_IRQ is defined.
> 
> [...]
> 


-- 
Warm Regards
Thara