Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp996234ybl; Fri, 24 Jan 2020 13:26:15 -0800 (PST) X-Google-Smtp-Source: APXvYqxPOcowl9zrNeuYqtOgVp99KROYhVnZNkOrFg39/KvhyEXGxP+cwu1n0+BVUozoAY+9qloP X-Received: by 2002:aca:220c:: with SMTP id b12mr568700oic.55.1579901174815; Fri, 24 Jan 2020 13:26:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579901174; cv=none; d=google.com; s=arc-20160816; b=1Da5znoDHwE14MDOZhr2TXN9SqOEJsUxVHuyMijjZWU1KjJZ5iuLqebpy34l3SMAtA K75yH4TSW2di+xk57OGLgbMn/FJHOTfIej3TZPYyp7pcXbsKLJtrA0FCw8QQ1l5ltOjP r/nH2TFrwL5qn30u7UTneG+DwJip0kYBn1qwJwPGnVTCTqxaTtn9NMdRAA5BLx0FtK3U CzsEZ3ml5ELnzuvUtT73IIP1fo71kOr/YHp3leA8UM1/04YBsnVXvroUcR+ea0WOLqoL uGmSMW6dG0ELZO7/BjtcZBSS3JCPk4JVA0ch9B/U5MB1roAUsrmZnwNuCJjdYVNYQgZO Jz5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=t65RoraJ97XSNifH3nJWhcpZY1lN6qjNaU0+rNtB6VA=; b=MYj8tw6sOF06V5bvCn7r66iypbDnvAzhKbEUuwU2X7Y2+42tCsE80m6Q3KdB545Apq 2O5XkfJe8VA0MUDKlZavoVpRuJop/2bZZgkDo8ubbUowgRijNgHjG1V3ciJr09VwKtUA b4+/zLm+955/TSjDJcuVlqkVTfMnf4AQRacQYVoP+y6PQuiST98KuDhFZ/y//Wz1AnJx gQb4qp/WSmiyrgaFvs3KKpycc3Ebj5buwRdsqRov1yzJahzUe70S5X6MGm56RDZp4Z5d /ha75P3GQ0r38a7sCgOw2TuxM0IN5WuJH1syUJj9X3Z5WcvQZNFNPNpzm/gmC1CQsvWn Oy2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gins8z7J; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 6si355604oin.93.2020.01.24.13.26.02; Fri, 24 Jan 2020 13:26:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gins8z7J; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389482AbgAXNUS (ORCPT + 99 others); Fri, 24 Jan 2020 08:20:18 -0500 Received: from mail-vs1-f65.google.com ([209.85.217.65]:41454 "EHLO mail-vs1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387897AbgAXNUS (ORCPT ); Fri, 24 Jan 2020 08:20:18 -0500 Received: by mail-vs1-f65.google.com with SMTP id k188so1161596vsc.8 for ; Fri, 24 Jan 2020 05:20:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t65RoraJ97XSNifH3nJWhcpZY1lN6qjNaU0+rNtB6VA=; b=gins8z7JzejJQal9gDEbPpdg5XvecgftPkBOzZDn61Udldh3usgTviD1RSeTs/khVg P6QL2wdgjepWpZPu2K07a0Gi2j30WxCH8luSM9XeXKn2a0tOlWNsCiBvesNyFuoRTa2l l+vIULJyGGwlTBlM48w/mQcMBP9WP2/M/8BvfKaietFwyHD4quO4EfSzZuZDebmtJUKO N78p+V3i2PTQYXQaBm9DxrHQdcBOrL5nyx5ZvfkLk7TND7MMNM/kXvpRBQCuqtQn+Mxh S+P6c2mXdalbk8iIrd+uIIUDrn+lJsAfuy8AVqcNxmXZb29qZ7+MytSuK9cABHt20/c6 vbnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t65RoraJ97XSNifH3nJWhcpZY1lN6qjNaU0+rNtB6VA=; b=O5syL5fhov0OmTX1DCUapUoxlYe7Gaa7DJFoNt7RSApU9DSQi168T943cskmPT3bZ1 /tUl+WvKjdYH5D3h1MmiUSlGNnE830aZRz4RwlC2qx0bEcTtOPCSfF9kqL28McFHq+yF IdhMHUzRUhx+UiIOe4UknsB+ezDZ4RrXH93HJJGf62MHQeMjd2YTXNdcx7n8E+YCD4QD WkYfb+vKPLurxqojNwYQYzX2IWpcv6J4hqX4QDEVt4+z0NKtksO5DhwfY3MqFnus8dwG LaV9OP+b8bOpuS4NUOKE78BUoskajC4rg9y4+ZZ4Cn67D/l4GQAhUqj5VWySACVyfb/x /wOw== X-Gm-Message-State: APjAAAWQoFUFaRk8OJta+uTGG2JKZYjNbJa7V/OKnVKZhnx9eTTT4EMj MOz1nem+urjWU4CEIjppJTu/BrqeMWpYDAVqK+D/sIaM X-Received: by 2002:a67:cc3:: with SMTP id 186mr2203033vsm.200.1579872016966; Fri, 24 Jan 2020 05:20:16 -0800 (PST) MIME-Version: 1.0 References: <20200110134823.14882-1-ludovic.barre@st.com> <6d859def-351e-abd7-0d5f-962ad935dff2@st.com> In-Reply-To: <6d859def-351e-abd7-0d5f-962ad935dff2@st.com> From: Ulf Hansson Date: Fri, 24 Jan 2020 14:19:40 +0100 Message-ID: Subject: Re: [PATCH 0/9] mmc: mmci: sdmmc: add sdr104 support To: Ludovic BARRE Cc: Rob Herring , Srinivas Kandagatla , Maxime Coquelin , Alexandre Torgue , Linux ARM , Linux Kernel Mailing List , DTML , "linux-mmc@vger.kernel.org" , linux-stm32@st-md-mailman.stormreply.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Jan 2020 at 13:55, Ludovic BARRE wrote: > > hi Ulf > > Just a "gentleman ping" on this series > https://lkml.org/lkml/2020/1/10/392 I was just reviewing :-) Thanks for pinging! One overall comment is that I think you can try to work a bit on the changelogs. In some cases you described what the patch does, which is good, but it may lack information about *why* the change is wanted. Overall, the series looks nice. Kind regards Uffe