Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 25 Jan 2020 08:11:07 +0100 (CET)
Message-Id: <20200125.081107.914737890991760251.davem@davemloft.net>
To:     wenwen@cs.uga.edu
Cc:     3chas3@gmail.com, linux-atm-general@lists.sourceforge.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firestream: fix memory leaks
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200125051134.11557-1-wenwen@cs.uga.edu>
References: <20200125051134.11557-1-wenwen@cs.uga.edu>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Wenwen Wang <wenwen@cs.uga.edu>
Date: Sat, 25 Jan 2020 05:11:34 +0000

> @@ -922,6 +923,7 @@ static int fs_open(struct atm_vcc *atm_vcc)
>  			if (((DO_DIRECTION(rxtp) && dev->atm_vccs[vcc->channo])) ||
>  			    ( DO_DIRECTION(txtp) && test_bit (vcc->channo, dev->tx_inuse))) {
>  				printk ("Channel is in use for FS155.\n");
> +				kfree(vcc);
>  				return -EBUSY;
>  			}
>  		}
> -- 

There is another case just below this line:

			    tc, sizeof (struct fs_transmit_config));
		if (!tc) {
			fs_dprintk (FS_DEBUG_OPEN, "fs: can't alloc transmit_config.\n");
			return -ENOMEM;
		}

Please audit the entire function and make sure your patch fixes all of these
missing vcc free cases.

Thank you.