Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200125051134.11557-1-wenwen@cs.uga.edu> <20200125.081107.914737890991760251.davem@davemloft.net>
In-Reply-To: <20200125.081107.914737890991760251.davem@davemloft.net>
From:   Wenwen Wang <wenwen@cs.uga.edu>
Date:   Sat, 25 Jan 2020 09:12:11 -0500
Message-ID: <CAAa=b7ff6xDGFjosX+RVp0=LCD5GHtg_O2gAkcha3OJMD2uaoQ@mail.gmail.com>
Subject: Re: [PATCH] firestream: fix memory leaks
To:     David Miller <davem@davemloft.net>
Cc:     Chas Williams <3chas3@gmail.com>,
        "moderated list:ATM" <linux-atm-general@lists.sourceforge.net>,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Wenwen Wang <wenwen@cs.uga.edu>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Jan 25, 2020 at 2:11 AM David Miller <davem@davemloft.net> wrote:
>
> From: Wenwen Wang <wenwen@cs.uga.edu>
> Date: Sat, 25 Jan 2020 05:11:34 +0000
>
> > @@ -922,6 +923,7 @@ static int fs_open(struct atm_vcc *atm_vcc)
> >                       if (((DO_DIRECTION(rxtp) && dev->atm_vccs[vcc->channo])) ||
> >                           ( DO_DIRECTION(txtp) && test_bit (vcc->channo, dev->tx_inuse))) {
> >                               printk ("Channel is in use for FS155.\n");
> > +                             kfree(vcc);
> >                               return -EBUSY;
> >                       }
> >               }
> > --
>
> There is another case just below this line:
>
>                             tc, sizeof (struct fs_transmit_config));
>                 if (!tc) {
>                         fs_dprintk (FS_DEBUG_OPEN, "fs: can't alloc transmit_config.\n");
>                         return -ENOMEM;
>                 }
>
> Please audit the entire function and make sure your patch fixes all of these
> missing vcc free cases.

Thanks for your comment! I was planning to submit another patch as
this case has different semantics. But, since you have pointed out, I
will revise this patch.

Wenwen

>
> Thank you.