Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] sched/rt: optimize checking group rt scheduler
 constraints
To:     Cyrill Gorcunov <gorcunov@gmail.com>
Cc:     linux-kernel@vger.kernel.org, Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>,
        Ingo Molnar <mingo@redhat.com>, Mel Gorman <mgorman@suse.de>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>
References: <157996383820.4651.11292439232549211693.stgit@buzz>
 <20200125153211.GP2437@uranus>
From:   Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Message-ID: <417d11b4-d5a2-96c2-8007-5e8f90a422cb@yandex-team.ru>
Date:   Sat, 25 Jan 2020 19:15:16 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20200125153211.GP2437@uranus>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-CA
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 25/01/2020 18.32, Cyrill Gorcunov wrote:
> On Sat, Jan 25, 2020 at 05:50:38PM +0300, Konstantin Khlebnikov wrote:
> ...
>> -/* Must be called with tasklist_lock held */
>>   static inline int tg_has_rt_tasks(struct task_group *tg)
>>   {
>> -	struct task_struct *g, *p;
>> +	struct task_struct *task;
>> +	struct css_task_iter it;
>> +	int ret = 0;
>>   
>>   	/*
>>   	 * Autogroups do not have RT tasks; see autogroup_create().
>> @@ -2407,12 +2408,12 @@ static inline int tg_has_rt_tasks(struct task_group *tg)
>>   	if (task_group_is_autogroup(tg))
>>   		return 0;
>>   
>> -	for_each_process_thread(g, p) {
>> -		if (rt_task(p) && task_group(p) == tg)
>> -			return 1;
>> -	}
>> +	css_task_iter_start(&tg->css, 0, &it);
>> +	while (!ret && (task = css_task_iter_next(&it)))
>> +		ret |= rt_task(task);
> 
> Plain 'ret = rt_task(task);' won't work?

Should work too =)

> 
>> +	css_task_iter_end(&it);
>>   
>> -	return 0;
>> +	return ret;
>>   }