Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1991603ybl; Sat, 25 Jan 2020 13:42:45 -0800 (PST) X-Google-Smtp-Source: APXvYqzGInmA/+U7myBnRE+AAEDek57iHH1Cl/NdFheW+nWeHh/icTV6bz1Na8v87GEkD4dJzyTU X-Received: by 2002:a05:6808:98e:: with SMTP id a14mr3197889oic.8.1579988565642; Sat, 25 Jan 2020 13:42:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579988565; cv=none; d=google.com; s=arc-20160816; b=lfWXTzEgurwcSnQYT/jrpQ1Gtj9G5DQED4DSHj62spPxh10eb2DPXJiQKOpOSDv2ze Boxuuov4kjQTExCHbF3ms88klwcmGzf59zUpe/vR3M9xh2c0VxX6xsn6CytjDmwFDRrc lOdNppY/TrVChj6TcJi5s03RAG2kgSNSQgUc448iNrfZGRYrNpEBVWu04fkU1OhdNQPh 1O+WCpx9eY1CKV0kaWu+56JlJfbU5/1o/PZoYQ0Im8iUMvEsFvqmXEtlUxOhE5MieLlc BQNVhUDZWQymYnn5dwI9TaF2OfCHlLOH+uo8x1gFWfAqeRz9wT/6FA/bfksYY0p4viA3 ZKBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ueAc178zlYs2faSWDEfAF3WFHdKuLx2UTSu70l9xbfY=; b=sf1mezIwVD/n0iTJNiHo2wbpd1CTWkqXJhOo/XEuhBa7pX2seRZTy4zkvu9/6mYuzG qevgQxA7Vf9UqwUUOCaJ0MIcCmuwTjI/+IIRTeYJ6Yp+84J3480SMdampJyvWIE6k/9U k3b36Xppitev9XTF3OTGllzseIuoV9FNtpZurhJ+dtFQHAdpagCKx4dWb1tbficBetOG GMVR5GEAVdPgdLPn8w0+yuKVeM7FAzN8N6X2pSAXcBeEDp1bY6X6zsPhz5Asj5+5h97m RgBn7HlUSDetJgkfq/w/jI/JolRMrwMrYN86kwrbBuBfFCrb5d9gW8YN01ZUUso7SWVG b6Xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fB4tHrRs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f9si4874348otp.111.2020.01.25.13.42.34; Sat, 25 Jan 2020 13:42:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fB4tHrRs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727893AbgAYVlo (ORCPT + 99 others); Sat, 25 Jan 2020 16:41:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:56546 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726690AbgAYVln (ORCPT ); Sat, 25 Jan 2020 16:41:43 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1024820716; Sat, 25 Jan 2020 21:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579988503; bh=EkoP8mp3H+BuaFmFH9KUtUPs07vqCNs8nUzXWhJ/RHA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fB4tHrRsWahRKd/nvTJ1BEt7XKx37Je0atpPqw5IvDLj/8ZIV8yuGAi78TtadRd0o lXwyikMCVkw8iavUfTkRwpVcQ50vnkb5zWxyiKElaiXX3K6XkkMk3KbF9vCChfRIB3 mGPuRS9Kqx6R8hnDWcbPcNOFdIvEJfOOwNbd+YTg= Date: Sat, 25 Jan 2020 16:41:41 -0500 From: Sasha Levin To: Michael Kelley Cc: "lantianyu1986@gmail.com" , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Tianyu Lan , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , vkuznets , "stable@vger.kernel.org" Subject: Re: [PATCH V4] x86/Hyper-V: Balloon up according to request page number Message-ID: <20200125214141.GK1706@sasha-vm> References: <20200121034912.2725-1-Tianyu.Lan@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 21, 2020 at 04:36:26AM +0000, Michael Kelley wrote: >From: Tianyu Lan Sent: Monday, January 20, 2020 7:49 PM >> >> Current code has assumption that balloon request memory size aligns >> with 2MB. But actually Hyper-V doesn't guarantee such alignment. When >> balloon driver receives non-aligned balloon request, it produces warning >> and balloon up more memory than requested in order to keep 2MB alignment. >> Remove the warning and balloon up memory according to actual requested >> memory size. >> >> Fixes: f6712238471a ("hv: hv_balloon: avoid memory leak on alloc_error of 2MB memory >> block") >> Cc: stable@vger.kernel.org >> Reviewed-by: Vitaly Kuznetsov >> Signed-off-by: Tianyu Lan > >Reviewed-by: Michael Kelley Queued up, thanks! -- Thanks, Sasha