Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Dexuan Cui <decui@microsoft.com>
To:     Michael Kelley <mikelley@microsoft.com>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "sashal@kernel.org" <sashal@kernel.org>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        vkuznets <vkuznets@redhat.com>
Subject: RE: [PATCH v3 1/4] Tools: hv: Reopen the devices if read() or write()
 returns errors
Thread-Topic: [PATCH v3 1/4] Tools: hv: Reopen the devices if read() or
 write() returns errors
Thread-Index: AQHV07lVd95yjtgTiE+JQQ3vMAq0wKf8XnwAgAAEEhA=
Date:   Sun, 26 Jan 2020 04:59:31 +0000
Message-ID: <HK0P153MB014854B3EA48F86C722F1011BF080@HK0P153MB0148.APCP153.PROD.OUTLOOK.COM>
References: <1579982036-121722-1-git-send-email-decui@microsoft.com>
 <1579982036-121722-2-git-send-email-decui@microsoft.com>
 <MW2PR2101MB105256D6229F97FC16DC4735D7080@MW2PR2101MB1052.namprd21.prod.outlook.com>
In-Reply-To: <MW2PR2101MB105256D6229F97FC16DC4735D7080@MW2PR2101MB1052.namprd21.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=mikelley@ntdev.microsoft.com;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-01-26T04:49:13.6387629Z;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure
 Information Protection;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=022339bc-bb50-4127-8274-d3106c3df480;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=decui@microsoft.com; 
x-originating-ip: [2601:600:a280:7f70:67:1cd4:d237:9171]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 542210cd-da45-4596-582c-08d7a21c880c
x-ms-traffictypediagnostic: HK0P153MB0259:|HK0P153MB0259:|HK0P153MB0259:
x-ms-exchange-transport-forked: True
x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr
x-microsoft-antispam-prvs: <HK0P153MB0259E82C6114898EC889FF09BF080@HK0P153MB0259.APCP153.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 02945962BD
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(199004)(189003)(8676002)(8990500004)(66556008)(81166006)(55016002)(4744005)(5660300002)(110136005)(66946007)(76116006)(9686003)(478600001)(8936002)(64756008)(66476007)(186003)(316002)(66446008)(10290500003)(86362001)(7696005)(71200400001)(6506007)(33656002)(81156014)(2906002)(52536014);DIR:OUT;SFP:1102;SCL:1;SRVR:HK0P153MB0259;H:HK0P153MB0148.APCP153.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: AE7MLD+O3Fq9sldYJgfjC2Q4Vi1upypcuJqjjOp+JZtx0TtwVy5SdHxIN9ElhWhl6vvlJ7b6JmqH8jj5XhX2p8+faqli+X9AiEhKa5gC19fGQBD4eSBA+2ibOCroiWFSmHXxYkAfc7JL+Dm92MERl8I4ugUezEY7caYF5JzcSoB0diJAgpq3kfQb4kA6fmAmVRaKTRJ1C+VA59pjPasApU6NoIBu7MXByYkMdvuX3x5MkREkXr8tL/cV/0XS2sxJtjw6c8JukoysOKEaW7LmKxL4MK6BqUh8mcvUo1wsqcAh9ucd7+GRDpYz7WzkKOHIdRI1/7hRs5WRk7XtgOZAQvGWsU8S++RKsJaibluo569iV8Z49oSQ91+36LLo2vNpAjLOKXDy4RG+43adgqBAjGJJNokIRjChAmQ+MWVQSpZp2Ij9IVmdaUn7iuCdf7tn
x-ms-exchange-antispam-messagedata: ur1OYpE15CBt8DlzaZMNu/LFtdoPcc8kbjbSV6hFPMOfIUalMvf3q4fiANjDO1IC98WefdM9prk/GV6SBNVsncIhdHaume8MKA+02lez0f9c/Ho2LmOkbCKRTjGtELqFwUSHE4elsisp1IovaSYLttprNmGTyYo3qhHiOqPyU7N1Ieh5/I/osDc/MBXdBEwLBwi1/Czn9zTVQPbbA4crhg==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 542210cd-da45-4596-582c-08d7a21c880c
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2020 04:59:31.7311
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KWpW0PfMD5GYx3mZ3nMDACFfO2FjPqk9598dCBGKYwgtOW7Ee7buHyWmsQmnen+EyBQyP8mI7R2b3EMS7748ug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0P153MB0259
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Michael Kelley <mikelley@microsoft.com>
> Sent: Saturday, January 25, 2020 8:49 PM
> > +reopen_fcopy_fd:
> > +	/* Remove any possible partially-copied file on error */
> > +	hv_copy_cancel();
>=20
> Since you have removed the calls to close(fcopy_fd) after a
> pread() or pwrite() failure that were in v2 of the patch, I was
> expecting to see
>=20
> 	if (fcopy_fd !=3D -1)
> 		close(fcopy_fd)

I missed this... Thanks for catching it!
=20
> here, like you've done with the kvp and vss code.  And
> remember to initialize fcopy_fd to -1. :-)
>=20
> Michael

Will do it in v4.

Thanks,
-- Dexuan