Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Dexuan Cui <decui@microsoft.com>
To:     Michael Kelley <mikelley@microsoft.com>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "sashal@kernel.org" <sashal@kernel.org>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        vkuznets <vkuznets@redhat.com>
Subject: RE: [PATCH v3 2/4] hv_utils: Support host-initiated restart request
Thread-Topic: [PATCH v3 2/4] hv_utils: Support host-initiated restart request
Thread-Index: AQHV07lWZvLQXaSX3027E1rxrSU606f8YKbggAAD5cA=
Date:   Sun, 26 Jan 2020 05:05:26 +0000
Message-ID: <HK0P153MB01485A90EA8D0D7A8CF5F97EBF080@HK0P153MB0148.APCP153.PROD.OUTLOOK.COM>
References: <1579982036-121722-1-git-send-email-decui@microsoft.com>
 <1579982036-121722-3-git-send-email-decui@microsoft.com>
 <MW2PR2101MB10527D5A3D4F7E52568D119DD7080@MW2PR2101MB1052.namprd21.prod.outlook.com>
In-Reply-To: <MW2PR2101MB10527D5A3D4F7E52568D119DD7080@MW2PR2101MB1052.namprd21.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=mikelley@ntdev.microsoft.com;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-01-26T04:56:57.5354335Z;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure
 Information Protection;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=8bd2cd39-837a-4776-b220-3ec15095a9d8;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=decui@microsoft.com; 
x-originating-ip: [2601:600:a280:7f70:67:1cd4:d237:9171]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 772b5122-b867-4991-7603-08d7a21d5b3c
x-ms-traffictypediagnostic: HK0P153MB0259:|HK0P153MB0259:|HK0P153MB0259:
x-ms-exchange-transport-forked: True
x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr
x-microsoft-antispam-prvs: <HK0P153MB0259B9C8BF037994DCA94534BF080@HK0P153MB0259.APCP153.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 02945962BD
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(199004)(189003)(8676002)(8990500004)(66556008)(81166006)(55016002)(4744005)(5660300002)(110136005)(66946007)(76116006)(9686003)(478600001)(8936002)(64756008)(66476007)(186003)(316002)(66446008)(10290500003)(86362001)(7696005)(71200400001)(6506007)(33656002)(81156014)(2906002)(52536014);DIR:OUT;SFP:1102;SCL:1;SRVR:HK0P153MB0259;H:HK0P153MB0148.APCP153.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: GkX9zpNuL+TL6juu0ZVganajGCyXzxWcqxa8+D3RDkPz4EHu9oPbSoL6hO3X3g+0/b+D2zCTr6MAPn84uk5vwwSTcpbM8tUgHzHdw/osp5nftw2rH9RaTItfiKFCEK37CEwhp/hsehe9WRDXJqVjPhGPHI8mCzwP57Fn3MpQTRCu5zA79Yy43tQXyWmEiK9ip3E7E5dxM0xMZNnRO/La5k71J2Sv4G6WoBPVMXkO7a490PGA1NrnlObU5LMpz+qOA02ZjHR7sPcfIzURwXfyZAj4wb//JqcRjgJ5Sw1WRChUdFVweWdftibpZHFmwYbtxON1nLfalKCFaiigfNVo2uUf4UTN8RniptA9VAbDcATsYwX+mPXvbzFWVdt2MWs1b+akYfhKIYr+Ss8mPKL1OjGxOF2P+kEXI4ZPcgPLxxfsjyqLk0gqYjBqeNvBoNmA
x-ms-exchange-antispam-messagedata: PECizr0kj5GRdJtCslFbAg+Ikil9JrST5dCkZ9lHj3/XXU3WAHnmFC1g0C6aMKgODnCSdW09UCwjKL9sk+CnzTztMVFhCXf0fE2wSRCcuUCrhc+bAwOpbzKgXaIQQlZZlhVj5DctivqWQxE4fl/blc/oNa3fZWhoxHhQORnVSoD/tr99LMzHHV8+XBEDWnTUFwZHnn2wswQJrKfdTaXPwA==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 772b5122-b867-4991-7603-08d7a21d5b3c
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2020 05:05:26.0886
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: A7Lm2beWtcHyeeLg6XMRavq6iRQSli/nkWKbiYI5SEu+ja5G5MI3pCU55ShI+IN3vEhNBJ+UBGfGTwk+ME+2IQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0P153MB0259
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Michael Kelley <mikelley@microsoft.com>
> Sent: Saturday, January 25, 2020 8:57 PM
> > @@ -186,6 +214,8 @@ static void shutdown_onchannelcallback(void
> *context)
> >
> >  	if (execute_shutdown =3D=3D true)
> >  		schedule_work(&shutdown_work);
> > +	if (execute_reboot =3D=3D true)
> > +		schedule_work(&restart_work);
>=20
> This works, and responds to my comment.  But FWIW, a more compact
> approach would be to drop the boolean execute_shutdown, execute_restart,
> etc. local variables and have just this local variable:
>=20
> 	struct work_struct *work_to_do =3D NULL;
>=20
> In the "case" branches do:
>=20
> 	work_to_do =3D &shutdown_work;
>=20
> or
> 	work_to_do =3D &restart_work;
>=20
> Then at the bottom of the function, just do:
>=20
> 	if (work_to_do)
> 		schedule_work(work_to_do);
>=20
> Patch 3 of this series would then be a little simpler as well.

Good idea! I'll do this in v4.

Thanks,
-- Dexuan