Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 26 Jan 2020 17:50:51 +0100
From:   Pavel Machek <pavel@denx.de>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Jose Abreu <Jose.Abreu@synopsys.com>,
        "David S. Miller" <davem@davemloft.net>,
        Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 4.19 587/639] net: stmmac: gmac4+: Not all Unicast
 addresses may be available
Message-ID: <20200126165051.GC19082@duo.ucw.cz>
References: <20200124093047.008739095@linuxfoundation.org>
 <20200124093202.992850194@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="3siQDZowHQqNOShm"
Content-Disposition: inline
In-Reply-To: <20200124093202.992850194@linuxfoundation.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--3siQDZowHQqNOShm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> Some setups may not have all Unicast addresses filters available. Check
> the number of available filters before trying to setup it.
=2E..
> @@ -443,7 +443,7 @@ static void dwmac4_set_filter(struct mac_device_info =
*hw,
>  	}
> =20
>  	/* Handle multiple unicast addresses */
> -	if (netdev_uc_count(dev) > GMAC_MAX_PERFECT_ADDRESSES) {
> +	if (netdev_uc_count(dev) > hw->unicast_filter_entries) {
>  		/* Switch to promiscuous mode if more than 128 addrs
>  		 * are required
>  		 */

Do I understand correctly that 128 in the comment is no longer
accurate?

Best regards,
									Pavel
--=20
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo=
g.html

--3siQDZowHQqNOShm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCXi3DawAKCRAw5/Bqldv6
8qd5AJ42RQ/LLZFhq53sJOEdpGApoFdcEgCgvbFPsqXIs5KT2TgekSFio4UIP/c=
=d7yK
-----END PGP SIGNATURE-----

--3siQDZowHQqNOShm--