Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3303510ybl; Mon, 27 Jan 2020 01:11:27 -0800 (PST) X-Google-Smtp-Source: APXvYqzOi9jsLGv3KWuF+m2srz52ur8w/3YSqO35AJstPXRo4dIoo9LEF4rLC5zG3KD//5yTqnlk X-Received: by 2002:a9d:5f13:: with SMTP id f19mr12196353oti.180.1580116287147; Mon, 27 Jan 2020 01:11:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580116287; cv=none; d=google.com; s=arc-20160816; b=RwDy5JrWgmUb/HeYKMuIF0uX8KI7dD999BKG2r7mKl+QmwG6T3Yf3DF5PNxxXUr3sG KG6TlzHIirfV6sHXBgYZU12f2XXLfNwf7jycaohoYVQP/osQBMOB0YCSGgtNSeWEmNNE vP67JVGciXCYpwDNTyPvY1NJTR7we1Ip929rW0evnN/pmP4GBkv0i/oiU7qqe3lDVKHf h8RNukEVm/29t7ciU6WbuscI+Wq1KCZ6Qo8PrOdrtPvcrwcHrUydqSsYPREC8mpiCuzG iO+RKWOATAaYzhJszckyF1lWDdUqih/szLsaNrRzDUWf+llr6Y8SqOt2lpVkGvVSaI3Z CAig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8+Z6fYD9jnwP4sblY3q/qNPN7drt9aBXH7CbIrllhY0=; b=Md57hDWuKSlFYvUyRyAu4023ZOYajjuU/OUcgOAc2WDhyhuu9fPQ+9WqA1iEsZbnnQ dmBOusK6rn0OjI4yVFeqIKkVhsIZgpVcjstOywhH8FUra9+RpR6t8cM6+4oFkGvMOopk kGwu1+XOGN0LaQG3sgGZ9aNLSnK+0ineDajKuzEbZc6hEKcJ8iaK5x3KZXLKL4V/E6L1 Iqz/jZ1JIrR/3Sr8ygdNZsu+Sv017KaCwfhWI3UbUjXwnXErFioqoPVunyMoByiXTwLK /+8RYAVwKTtAdm7CzYr8gDmuQvq/RXj8NZqd75TWxfTYvo0KUYadYKW6nHVS1hh4Cx1C mmpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=SKCo70V1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k138si3375315oib.49.2020.01.27.01.11.02; Mon, 27 Jan 2020 01:11:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=SKCo70V1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729195AbgA0I3F (ORCPT + 99 others); Mon, 27 Jan 2020 03:29:05 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:39744 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbgA0I3F (ORCPT ); Mon, 27 Jan 2020 03:29:05 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00R8NbFS016585; Mon, 27 Jan 2020 08:28:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=8+Z6fYD9jnwP4sblY3q/qNPN7drt9aBXH7CbIrllhY0=; b=SKCo70V1LKl+3KQfoNW4v6xnDExd86vQCUHCr4gUq0yMMS1cuc/SDc0YdLlPjhnCVuew SVYt0H+RkZ+pExWmglOTyhd9LLAE7lMlZ3LyEHoM0UABygiS9ROKoVPqz+7nAxkkYpJ7 A+BD7ftrpnN53KK4cru9gYJEP+9PqCIn4Uyfuu3nJcLnNA+xaEWq+L5mOnQ2BlIVIbKS nnbWIcCobbMA6GA4Z/9CPD7RWP25W5ZUaQI8dB4m3FnBJNtG4HDQ8kIPX/3TO9z12SD5 dkxox6Ukji/hzSGhiewwKeJeWIDkf8/gVoRrVuWGwCcnjsQeeKm4HGqc/mNEOifK1YJN OA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2xrdmq5rf1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jan 2020 08:28:54 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00R8Ov8O137858; Mon, 27 Jan 2020 08:26:54 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 2xry4tumt7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jan 2020 08:26:53 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 00R8Qqsu013518; Mon, 27 Jan 2020 08:26:52 GMT Received: from kadam (/129.205.23.165) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 27 Jan 2020 00:26:51 -0800 Date: Mon, 27 Jan 2020 11:26:42 +0300 From: Dan Carpenter To: Saurav Girepunje Cc: gregkh@linuxfoundation.org, nishkadg.linux@gmail.com, wambui.karugax@gmail.com, julia.lawall@lip6.fr, benniciemanuel78@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com Subject: Re: [PATCH] staging: rtl8723bs: core: fix condition with no effect Message-ID: <20200127081812.GT1847@kadam> References: <20200125133438.GA4211@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200125133438.GA4211@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9512 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001270073 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9512 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001270073 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 25, 2020 at 07:04:38PM +0530, Saurav Girepunje wrote: > fix warning reorted by coccicheck > WARNING: possible condition with no effect (if == else) > > Signed-off-by: Saurav Girepunje This one looks good. The difference between this one and the last one, is that this stuff looks like documentation but it's just a lot of garbage dead code so it's good to delete it. But unfortunately, these patches don't apply. Please read Documentation/process/email-clients.rst regards, dan carpenter