Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3378912ybl; Mon, 27 Jan 2020 02:57:08 -0800 (PST) X-Google-Smtp-Source: APXvYqwCBkzh7vtwgGoBlPmHvYpQWLM+ECGY3MXzAlMmyLs5QK8zPSQxqQKSi4XBReaJDNuQupvD X-Received: by 2002:aca:4dd6:: with SMTP id a205mr6859013oib.43.1580122628731; Mon, 27 Jan 2020 02:57:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580122628; cv=none; d=google.com; s=arc-20160816; b=nXKEPwR+GMTo281LwpxBKqzyLN977aG5jc1pzl9nYdaqY7PxhJNdMH4T+DLfpV6RxC f4J1kXTuzV+zVRIvpccV6doOVCzEr7aJKlzpmcxhi4qnoE9niOlm5DTKx+tZ5mKLcmus HjQjEhacDMdapnfM+rlqve190V+dqvdMsO7zC4ss48OXivsifmS1HoEkQHGEasNStKx7 6IeJbPnnPRfoUzMgDBvNt3haruTfoUEoWbmY8h5slNdIfit218kSSBLNAG+aYthbZJ0m xLhwTILOJpd6WiTzJUBVCityW4qtNDeL+nPKFpiXGpDh70J27nV31g9OKtb5lEeYFH9f FVnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=kdKSdGaeCBCSRO9oFGnKnV1HVnp/0C0gcmOg/QBwv2M=; b=CsIdkB5+LGWVo49BEVOjFy5tuRIbbC4gjkXjcN7eJurtP33p+XcEj4Nqv3QyZb3yMk Wi07/vCCI97jGP1ju0ZPKvoKWocLG3DAnmKtkfPOwtY+IJG0eyfCLC8mzJS9RDqbAJE0 Wit7qlM2kciSFxetXZuKYmG08h7cgzY7VLG2mzCEhqdOqXc3Dlq6byZLXW6+R4w10Sq1 NRm4cAcJBFU4cE0UUYU3KiA6hAd8sZQIkKCwpERnGmea+aiEHuiWbB5ISxMq2EnI5/5h B8PK3vnFnJjtTl/RNJubnojcNuSYRdDn8xM3Kan2/zybC0ogarXqVFLII7p+s48FXcR7 Ppzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q9si799584otc.86.2020.01.27.02.56.56; Mon, 27 Jan 2020 02:57:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729848AbgA0KOr (ORCPT + 99 others); Mon, 27 Jan 2020 05:14:47 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:37000 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727409AbgA0KOp (ORCPT ); Mon, 27 Jan 2020 05:14:45 -0500 Received: from localhost (unknown [213.175.37.12]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 86F741512894A; Mon, 27 Jan 2020 02:14:43 -0800 (PST) Date: Mon, 27 Jan 2020 11:14:42 +0100 (CET) Message-Id: <20200127.111442.1993972247561151893.davem@davemloft.net> To: christophe.jaillet@wanadoo.fr Cc: jiri@mellanox.com, idosch@mellanox.com, vadimp@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mlxsw: minimal: Fix an error handling path in 'mlxsw_m_port_create()' From: David Miller In-Reply-To: <20200125211847.12755-1-christophe.jaillet@wanadoo.fr> References: <20200125211847.12755-1-christophe.jaillet@wanadoo.fr> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 27 Jan 2020 02:14:45 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET Date: Sat, 25 Jan 2020 22:18:47 +0100 > An 'alloc_etherdev()' called is not ballanced by a corresponding > 'free_netdev()' call in one error handling path. > > Slighly reorder the error handling code to catch the missed case. > > Fixes: c100e47caa8e ("mlxsw: minimal: Add ethtool support") > Signed-off-by: Christophe JAILLET Applied and queued up for -stable, thanks.