Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] arm64: defconfig: Enable Texas Instruments UDMA driver
To:     Olof Johansson <olof@lixom.net>
CC:     <catalin.marinas@arm.com>, <will@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <t-kristo@ti.com>,
        <vkoul@kernel.org>, <alexandre.belloni@bootlin.com>,
        <arnd@arndb.de>, <soc@kernel.org>
References: <20200124092359.12429-1-peter.ujfalusi@ti.com>
 <20200124200811.ytgs66cg5qpugi5c@localhost>
From:   Peter Ujfalusi <peter.ujfalusi@ti.com>
Message-ID: <12f40648-fec6-9179-1f62-0a648996ed20@ti.com>
Date:   Mon, 27 Jan 2020 12:32:11 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20200124200811.ytgs66cg5qpugi5c@localhost>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Olof,

On 24/01/2020 22.08, Olof Johansson wrote:
> On Fri, Jan 24, 2020 at 11:23:59AM +0200, Peter Ujfalusi wrote:
>> The UDMA driver is used on K3 platforms (am654 and j721e).
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>> Hi,
>>
>> The drivers for UDMA are already in linu-next and the DT patches are going to be
>> also heading for 5.6.
>> The only missing piece is to enable the drivers in defconfig so clients can use
>> the DMA.
> 
> Hi Peter,
> 
> We normally like to see new options turned on after the driver/option has been
> merged, so send this during or right after the merge window when that happens,
> please.

Sure, I'll post it later.

> I also see that this is statically enabling this driver -- we try to keep as
> many drivers as possible as modules to avoid the static kernel from growing too
> large. Would that be a suitable approach here, or is the driver needed to reach
> rootfs for further module loading?

We would need built in DMA for nfs rootfs, SD/MMC has it's own buit-in
ADMA. We do not have network drivers upstream as they depend on the DMA.

Imho module would be fine for the DMA stack, but neither ringacc or the
UDMA driver can be built as module atm until the following patches got
merged:
https://lore.kernel.org/lkml/20200122104723.16955-1-peter.ujfalusi@ti.com/
https://lore.kernel.org/lkml/20200122104031.15733-1-peter.ujfalusi@ti.com/

I have the patches to add back module support, but waiting on these
currently.

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki