Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Laurentiu Tudor <laurentiu.tudor@nxp.com>
To:     Andrei Botila <andrei.botila@nxp.com>,
        Stuart Yoder <stuyoder@gmail.com>, Leo Li <leoyang.li@nxp.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Andrei Botila <andrei.botila@nxp.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: RE: [PATCH] bus: fsl-mc: add api to retrieve mc version
Thread-Topic: [PATCH] bus: fsl-mc: add api to retrieve mc version
Thread-Index: AQHV1QNKvLjP3UuObkmXzkCe27o2Qqf+ZGRg
Date:   Mon, 27 Jan 2020 11:48:36 +0000
Message-ID: <AM6PR04MB58788A33BCFD161773375C8DEC0B0@AM6PR04MB5878.eurprd04.prod.outlook.com>
References: <1580123761-19536-1-git-send-email-andrei.botila@nxp.com>
In-Reply-To: <1580123761-19536-1-git-send-email-andrei.botila@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: fd754c66-b5f5-4d03-7277-08d7a31ed842
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2020 11:48:36.8144
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 338bzBq0DVkV3ynOiqaIVaEQYWca4XYzDLSLorl7RUlBKKMKw4PVv1IWOAUjDVsuM8kEiMcLLfi9ppvo0iPeVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5733
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrei Botila <andrei.botila@nxp.com>
> Sent: Monday, January 27, 2020 1:16 PM
>=20
> Add a new api that returns Management Complex firmware version
> and make the required structure public. The api's first user will be
> the caam driver for setting prediction resistance bits.
>=20
> Signed-off-by: Andrei Botila <andrei.botila@nxp.com>

Acked-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>

> ---
>  drivers/bus/fsl-mc/fsl-mc-bus.c | 33 +++++++++++++++++----------------
>  include/linux/fsl/mc.h          | 16 ++++++++++++++++
>  2 files changed, 33 insertions(+), 16 deletions(-)
>=20
> diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-
> bus.c
> index a07cc19becdb..330c76181604 100644
> --- a/drivers/bus/fsl-mc/fsl-mc-bus.c
> +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
> @@ -26,6 +26,8 @@
>   */
>  #define FSL_MC_DEFAULT_DMA_MASK	(~0ULL)
>=20
> +static struct fsl_mc_version mc_version;
> +
>  /**
>   * struct fsl_mc - Private data of a "fsl,qoriq-mc" platform device
>   * @root_mc_bus_dev: fsl-mc device representing the root DPRC
> @@ -54,20 +56,6 @@ struct fsl_mc_addr_translation_range {
>  	phys_addr_t start_phys_addr;
>  };
>=20
> -/**
> - * struct mc_version
> - * @major: Major version number: incremented on API compatibility change=
s
> - * @minor: Minor version number: incremented on API additions (that are
> - *		backward compatible); reset when major version is incremented
> - * @revision: Internal revision number: incremented on implementation
> changes
> - *		and/or bug fixes that have no impact on API
> - */
> -struct mc_version {
> -	u32 major;
> -	u32 minor;
> -	u32 revision;
> -};
> -
>  /**
>   * fsl_mc_bus_match - device to driver matching callback
>   * @dev: the fsl-mc device to match against
> @@ -338,7 +326,7 @@ EXPORT_SYMBOL_GPL(fsl_mc_driver_unregister);
>   */
>  static int mc_get_version(struct fsl_mc_io *mc_io,
>  			  u32 cmd_flags,
> -			  struct mc_version *mc_ver_info)
> +			  struct fsl_mc_version *mc_ver_info)
>  {
>  	struct fsl_mc_command cmd =3D { 0 };
>  	struct dpmng_rsp_get_version *rsp_params;
> @@ -363,6 +351,20 @@ static int mc_get_version(struct fsl_mc_io *mc_io,
>  	return 0;
>  }
>=20
> +/**
> + * fsl_mc_get_version - function to retrieve the MC f/w version
> information
> + *
> + * Return:	mc version when called after fsl-mc-bus probe; NULL otherwise=
.
> + */
> +struct fsl_mc_version *fsl_mc_get_version(void)
> +{
> +	if (mc_version.major)
> +		return &mc_version;
> +
> +	return NULL;
> +}
> +EXPORT_SYMBOL_GPL(fsl_mc_get_version);
> +
>  /**
>   * fsl_mc_get_root_dprc - function to traverse to the root dprc
>   */
> @@ -862,7 +864,6 @@ static int fsl_mc_bus_probe(struct platform_device
> *pdev)
>  	int container_id;
>  	phys_addr_t mc_portal_phys_addr;
>  	u32 mc_portal_size;
> -	struct mc_version mc_version;
>  	struct resource res;
>=20
>  	mc =3D devm_kzalloc(&pdev->dev, sizeof(*mc), GFP_KERNEL);
> diff --git a/include/linux/fsl/mc.h b/include/linux/fsl/mc.h
> index 54d9436600c7..2b5f8366dbe1 100644
> --- a/include/linux/fsl/mc.h
> +++ b/include/linux/fsl/mc.h
> @@ -381,6 +381,22 @@ int __must_check __fsl_mc_driver_register(struct
> fsl_mc_driver *fsl_mc_driver,
>=20
>  void fsl_mc_driver_unregister(struct fsl_mc_driver *driver);
>=20
> +/**
> + * struct fsl_mc_version
> + * @major: Major version number: incremented on API compatibility change=
s
> + * @minor: Minor version number: incremented on API additions (that are
> + *		backward compatible); reset when major version is incremented
> + * @revision: Internal revision number: incremented on implementation
> changes
> + *		and/or bug fixes that have no impact on API
> + */
> +struct fsl_mc_version {
> +	u32 major;
> +	u32 minor;
> +	u32 revision;
> +};
> +
> +struct fsl_mc_version *fsl_mc_get_version(void);
> +
>  int __must_check fsl_mc_portal_allocate(struct fsl_mc_device *mc_dev,
>  					u16 mc_io_flags,
>  					struct fsl_mc_io **new_mc_io);
> --
> 2.17.1