Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3486123ybl; Mon, 27 Jan 2020 05:04:43 -0800 (PST) X-Google-Smtp-Source: APXvYqx/Qj6DewhlMK7/ceGFHu7lOkrBMdBdOiSGfKAQe/siTLwLywjqbXQQp1Llo9ouwn3MMwwM X-Received: by 2002:a9d:6196:: with SMTP id g22mr12668809otk.204.1580130283343; Mon, 27 Jan 2020 05:04:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580130283; cv=none; d=google.com; s=arc-20160816; b=my9pcgSp5v7mA3wi9s0C9BW8/9syJX3inCcQnOhqlTrYjHYumbxwuWbB+xuRPdnd4Y z9Bb+aC25Po8LoO1ozQ/df+CoVzEPLhNB0gZy1z+vkXR6G7CcCDJgAXQf/9OzMNvgtlF /BKu8ibos65qMXoHB9u4SWbK8PBzURrgITf66ABEo409lPAXjpbHXhe2DSl8iDSACw+5 6gdEJ2CkoqMeFAZQT0OEOfFyK8xjWWpgBWFk88GzsBNHrlfZ92exlBc09D+Ep9YX6ron XIE9Bce6bw7mpU6taYMVg0lgqDfGQsIz+wozxePXxI2dXeb1JYwkEZV+ZHrIYzW0sYpL 0M2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Cvm5wMflOToWn70Zao+WVbzFRYZbjzhRZt+uawFCmg8=; b=RWpm+iXIuwWWVQKyt6sOKiSNDiTOUg5iZU7xrhb5Hrvqe6GA7rQs5Gg/HdsGrRt3Km 62/4jrBru8gpfCMOTfo1msh/H9OPf7pX7UIdr9ql6P9/mx8H2FDy/43yTz1uBWxG9fkk ddNC/GsvMYID17WyPDLMjax7yg6i00R5rWIQuz4ZpkcvZ6grbHKQH0sP279jK/Z19gRh eb3XO6ETTb1QAUjF9OGy54wco1y5uVb2b01z69WF4+px5iuq03wxCkH1H7PXV/nUSQWi cYEWIC7OYaOOr8WFjnYG4o1djGLn5SeJekU9nFCPMP3yUKzAg0VbFMPc/50S/s43Np1X ierg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y65si3792895oia.162.2020.01.27.05.04.29; Mon, 27 Jan 2020 05:04:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726571AbgA0NDG (ORCPT + 99 others); Mon, 27 Jan 2020 08:03:06 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:53846 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725807AbgA0NDF (ORCPT ); Mon, 27 Jan 2020 08:03:05 -0500 Received: from ip5f5bd665.dynamic.kabel-deutschland.de ([95.91.214.101] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iw42e-0001Yk-8w; Mon, 27 Jan 2020 13:03:00 +0000 Date: Mon, 27 Jan 2020 14:02:59 +0100 From: Christian Brauner To: Dave Chinner Cc: Mike Christie , Shakeel Butt , Andrew Morton , linux-api@vger.kernel.org, idryomov@gmail.com, Michal Hocko , Linux MM , LKML , linux-scsi@vger.kernel.org, linux-fsdevel , linux-block@vger.kernel.org, martin@urbackup.org, Damien.LeMoal@wdc.com, Michal Hocko , Masato Suzuki Subject: Re: [PATCH] Add prctl support for controlling mem reclaim V4 Message-ID: <20200127130258.2bknkl3mwpkfyml4@wittgenstein> References: <20191112001900.9206-1-mchristi@redhat.com> <5E2B19C9.6080907@redhat.com> <20200124211642.GB7216@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200124211642.GB7216@dread.disaster.area> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 25, 2020 at 08:16:42AM +1100, Dave Chinner wrote: > On Fri, Jan 24, 2020 at 10:22:33AM -0600, Mike Christie wrote: > > On 12/05/2019 04:43 PM, Shakeel Butt wrote: > > > On Mon, Nov 11, 2019 at 4:19 PM Mike Christie wrote: > > >> This patch adds a new prctl command that daemons can use after they have > > >> done their initial setup, and before they start to do allocations that > > >> are in the IO path. It sets the PF_MEMALLOC_NOIO and PF_LESS_THROTTLE > > >> flags so both userspace block and FS threads can use it to avoid the > > >> allocation recursion and try to prevent from being throttled while > > >> writing out data to free up memory. > > >> > > >> Signed-off-by: Mike Christie > > >> Acked-by: Michal Hocko > > >> Tested-by: Masato Suzuki > > >> Reviewed-by: Damien Le Moal > > > > > > I suppose this patch should be routed through MM tree, so, CCing Andrew. > > > > > > > Andrew and other mm/storage developers, > > > > Do I need to handle anything else for this patch, or are there any other > > concerns? Is this maybe something we want to talk about at a quick LSF > > session? > > > > I have retested it with Linus's current tree. It still applies cleanly > > (just some offsets), and fixes the problem described above we have been > > hitting. > > I must have missed this version being posted (just looked it up on > lore.kernel.org). As far as I'm concerned this is good to go and it > is absolutely necessary for userspace IO stacks to function > correctly. > > Reviewed-by: Dave Chinner > > If no manintainer picks it up before the next merge window, then I Since prctl() is thread-management and fs people seem to be happy and have acked it I can pick this up too if noone objects and send this along with the rest of process management. Christian