Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3755206ybl; Mon, 27 Jan 2020 09:47:13 -0800 (PST) X-Google-Smtp-Source: APXvYqwfxtgbJ/vjAnOUS7zNJRJouplzFBPKxheOs8VdipbkUdBQV+T5pRjYX5gCchTeloFcNHfq X-Received: by 2002:a05:6830:1353:: with SMTP id r19mr13726807otq.288.1580147233219; Mon, 27 Jan 2020 09:47:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580147233; cv=none; d=google.com; s=arc-20160816; b=SL1XZZJm1s5Brev28/FRvpO3/5YUhBguDsQ5d/d8c/0yjVAk8qem/Dj0PCoUCiVzDl yQdHs1GUUOtswZeYTIG/+e8hJNPDD/RLscI/UOa7Wa4ylo925+wKsJLu8aHf3UVAH6Vm 5bX3NzwYfZlN6wDbRdXsstensomqME5cpD+H0tPxNRhGFhQU1VaZbVPWAC89P0gWJjPI /Svk+iR5N5LyLDEaP3fjjcWn3Rjcb44wnXfQoipy52FHbHbv83fgHGpLr1H/7eyqRx3N VkmxBOpYIagIFyMSquG4zcjn3GOWDeOq56auZbP7kP4SHO/5z1TdcUoo36/Lu6QSrlwm 4Mag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=FX8kD0L9qov6JUPvvdbzynW/esn7R+NY8dv4X6oArXY=; b=VMoWBmTIrJpvHGr0jCO64sOAYYDa5WeBLa1B5kfs6ADp8lBOZVUka/hktpO6E0YqpS IpbauNPn9/Wdy3ViUMsDBuZkcwESl3Cd7BBJRh48LF/kWxxWJeZQ8fhwJ6SJS4YA2sqC l55Cf87zJW+WQUgDmUdQD2rCM3kHtCz8hpwMUTN5tAEB7AQIpNfIaWBk4U6jcLXpcwEm wtfp5x/nkXqHv9RBEazMxNrTnET2nSF4DM37gZalhLRr7QWp+X6DRNx9p3GgIZ2/KuSW bIqhPRjz3FELTfViGnEEPnsvZYltyrZLkk5tSlZzXzfCXD55R/VYr+NR7IJk+GtIyq6X fK6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Q/o0KiyI"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c21si7533885otr.223.2020.01.27.09.46.59; Mon, 27 Jan 2020 09:47:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Q/o0KiyI"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726029AbgA0RqA (ORCPT + 99 others); Mon, 27 Jan 2020 12:46:00 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:59056 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725893AbgA0Rp7 (ORCPT ); Mon, 27 Jan 2020 12:45:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580147158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FX8kD0L9qov6JUPvvdbzynW/esn7R+NY8dv4X6oArXY=; b=Q/o0KiyIN7fYR0KPmLApw9mvtgE867GKrH88VxNP3wx5pCEA1xas6oL2qitUqNN4HJqp8O u/nXw1XsQrtDMoDj1Lu3fEpOBWK+LUXBmOOPs3wVp1Gbnc/DG0Ys0vpJVIPKSOPcxFq+8d yN9x4hGHGPnWSUuq4dNacfIy1SsVwd4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-21-3bUITg18Mj61EUVl44xXQg-1; Mon, 27 Jan 2020 12:45:53 -0500 X-MC-Unique: 3bUITg18Mj61EUVl44xXQg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2BF828017CC; Mon, 27 Jan 2020 17:45:52 +0000 (UTC) Received: from pauld.bos.csb (dhcp-17-51.bos.redhat.com [10.18.17.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5C4BA19C58; Mon, 27 Jan 2020 17:45:51 +0000 (UTC) Date: Mon, 27 Jan 2020 12:45:49 -0500 From: Phil Auld To: Peter Zijlstra Cc: Kirill Tkhai , Juri Lelli , mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3]sched/rt: Stop for_each_process_thread() iterations in tg_has_rt_tasks() Message-ID: <20200127174549.GD1295@pauld.bos.csb> References: <152415882713.2054.8734093066910722403.stgit@localhost.localdomain> <20180420092540.GG24599@localhost.localdomain> <0d7fbdab-b972-7f86-4090-b49f9315c868@virtuozzo.com> <854a5fb1-a9c1-023f-55ec-17fa14ad07d5@virtuozzo.com> <20180425194915.GH4064@hirez.programming.kicks-ass.net> <9f76872b-85e6-63bd-e503-fcaec69e28e3@virtuozzo.com> <20200123215616.GA14789@pauld.bos.csb> <20200127164315.GJ14879@hirez.programming.kicks-ass.net> <20200127165638.GC1295@pauld.bos.csb> <20200127170010.GK14879@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200127170010.GK14879@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 27, 2020 at 06:00:10PM +0100 Peter Zijlstra wrote: > On Mon, Jan 27, 2020 at 11:56:38AM -0500, Phil Auld wrote: > > On Mon, Jan 27, 2020 at 05:43:15PM +0100 Peter Zijlstra wrote: > > > On Thu, Jan 23, 2020 at 04:56:19PM -0500, Phil Auld wrote: > > > > Peter, is there any chance of taking something like this? > > > > > > Whoopsy, looks like this fell on the floor. Can do I suppose. > > > > > > Thanks! > > > > > > > Thanks. Probably make sense at this point to use Konstantin's new version? > > But they both do the trick. > > Care to send it along? > I think you were on the CC, but here's a link: https://lkml.org/lkml/2020/1/25/167 It's called: [PATCH] sched/rt: optimize checking group rt scheduler constraints It does a little bit more and needs an "|=" changed to "=". And actually looking at it again, it should probably just have a break in the loop. I'll make that comment in the thread for it. Thanks, Phil --