Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932518AbWBCDsm (ORCPT ); Thu, 2 Feb 2006 22:48:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932513AbWBCDsl (ORCPT ); Thu, 2 Feb 2006 22:48:41 -0500 Received: from colo.lackof.org ([198.49.126.79]:44207 "EHLO colo.lackof.org") by vger.kernel.org with ESMTP id S932355AbWBCDsj (ORCPT ); Thu, 2 Feb 2006 22:48:39 -0500 Date: Thu, 2 Feb 2006 20:58:22 -0700 From: Grant Grundler To: Akinobu Mita Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, Ian Molton , David Howells , linuxppc-dev@ozlabs.org, Greg Ungerer , sparclinux@vger.kernel.org, Miles Bader , Linus Torvalds , Yoshinori Sato , Hirokazu Takata , linuxsh-dev@lists.sourceforge.net, linux-m68k@vger.kernel.org, Chris Zankel , dev-etrax@axis.com, ultralinux@vger.kernel.org, Andi Kleen , linuxsh-shmedia-dev@lists.sourceforge.net, linux390@de.ibm.com, Russell King , parisc-linux@parisc-linux.org Subject: Re: [parisc-linux] [patch 12/44] generic sched_find_first_bit() Message-ID: <20060203035822.GA12539@colo.lackof.org> References: <20060201090224.536581000@localhost.localdomain> <20060201090325.497639000@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060201090325.497639000@localhost.localdomain> X-Home-Page: http://www.parisc-linux.org/ User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1105 Lines: 34 On Wed, Feb 01, 2006 at 06:02:36PM +0900, Akinobu Mita wrote: > This patch introduces the C-language equivalent of the function: > int sched_find_first_bit(const unsigned long *b); Akinobu, would you prefer this is a slightly cleaner way? (Not compile tested) static inline int sched_find_first_bit(const unsigned long *b) { if (unlikely(b[0])) return __ffs(b[0]); if (unlikely(b[1])) return __ffs(b[1]) + BITS_PER_LONG; #if BITS_PER_LONG == 32 if (unlikely(b[2])) return __ffs(b[2]) + 64; if (b[3]) return __ffs(b[3]) + 96; #endif return __ffs(b[128/BITS_PER_LONG]) + 128; } If BITS_PER_LONG isn't defined, the link step will fail and point at a some unknown .o as the offender. But it's the responsibility of the header file to make sure it's including the BITS_PER_LONG definition, not the code that calls sched_find_first_bit(). hth, grant - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/