Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751070AbWBCEzl (ORCPT ); Thu, 2 Feb 2006 23:55:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751151AbWBCEzl (ORCPT ); Thu, 2 Feb 2006 23:55:41 -0500 Received: from ozlabs.org ([203.10.76.45]:50079 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S1750967AbWBCEzk (ORCPT ); Thu, 2 Feb 2006 23:55:40 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17378.35622.918387.596756@cargo.ozlabs.ibm.com> Date: Fri, 3 Feb 2006 09:43:50 +1100 From: Paul Mackerras To: "Chen, Kenneth W" Cc: "'Christoph Hellwig'" , "'Akinobu Mita'" , "Grant Grundler" , "Linux Kernel Development" , Subject: RE: [PATCH 1/12] generic *_bit() In-Reply-To: <200602011807.k11I7ag15563@unix-os.sc.intel.com> References: <20060201180237.GA18464@infradead.org> <200602011807.k11I7ag15563@unix-os.sc.intel.com> X-Mailer: VM 7.19 under Emacs 21.4.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 691 Lines: 18 Chen, Kenneth W writes: > Christoph Hellwig wrote on Wednesday, February 01, 2006 10:03 AM > > Because they are defined to operate on arrays of unsigned long > > I think these should be defined to operate on arrays of unsigned int. > Bit is a bit, no matter how many byte you load (8/16/32/64), you can > only operate on just one bit. Christoph is right. Changing to unsigned int would change the layout on big-endian 64-bit platforms. Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/