Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 27 Jan 2020 15:15:08 -0800
From:   Kees Cook <keescook@chromium.org>
To:     Alexander Popov <alex.popov@linux.com>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, notify@kernel.org
Subject: Re: [PATCH v2 1/1] lkdtm/stackleak: Make the test more verbose
Message-ID: <202001271514.345A5CC9C@keescook>
References: <20200102234907.585508-1-alex.popov@linux.com>
 <e8f1b3e9-50ae-2482-3e10-32b21cd7ebb4@linux.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e8f1b3e9-50ae-2482-3e10-32b21cd7ebb4@linux.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 22, 2020 at 02:58:44PM +0300, Alexander Popov wrote:
> On 03.01.2020 02:49, Alexander Popov wrote:
> > Make the stack erasing test more verbose about the errors that it
> > can detect.
> > 
> > Signed-off-by: Alexander Popov <alex.popov@linux.com>
> > ---
> >  drivers/misc/lkdtm/stackleak.c | 25 +++++++++++++++++--------
> >  1 file changed, 17 insertions(+), 8 deletions(-)
> 
> Hello!
> 
> Pinging about this version of the patch.
> 
> Kees, it uses dump_stack() instead of BUG(), as we negotiated.

Yup, this is in my queue -- I've just gotten back from travelling and
will get to it shortly. :)

Greg, feel free to take this directly if you want, too.

-Kees

-- 
Kees Cook