Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4037283ybl; Mon, 27 Jan 2020 15:21:54 -0800 (PST) X-Google-Smtp-Source: APXvYqyn4V5uOxLME+E7CJ8eixsrXAQn++ZBdj/KsoZ5EcNIC3/CLT4Tvam6WSH6BNcvfsUFz75g X-Received: by 2002:a9d:63d6:: with SMTP id e22mr14447727otl.72.1580167314115; Mon, 27 Jan 2020 15:21:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580167314; cv=none; d=google.com; s=arc-20160816; b=p3yb9gTtnKpqjoFCurxLdoBn9xE44aJHWgvQAQgsrJRmFfqyF41eE+jfJaeBSFBig3 J4PiJNA5rUOpIF7lB1TIHebXH/UFoj4AFj4RUrkAWRwfU/EtihrVL1olUdiLV+C3f1jk Hke8Fc82sW399mh05Jsbl3BSYbucCYI6i/yFtdF5XaXz9rdnXlFMJnnUIyqDAOvoMZt0 v38UqDV7TLZVfH2kAMaq+b5V1dyzpjtfa9FfzUaQgxsJ5nJQ7vMrxhzSGbGBxJ6fjrLO nF0vd5d5gjCW8y1ws7WnssqIi4NQP3Hc8bO/vndUiu0CM7ZhoMWezupo+siLBTCatowC 6AbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=QT8O29qq6UX2ERtfMZtIcpjsnZ2zWwc1vGjIRRz0cAI=; b=nQK3+NBeupej8Ib5gkzNy00E858avg6s4SD0EDsQcO9DPygZxlTa94UDsxdVvOl4F/ k1Xmak7Y85GXNGMoDlOCMasmV9MCGft/WUzQdU80xam0+JrRJOAwJT3hmSbZ+ZFd3SXH QFAQjSXPTlt75ZKdjGCHuEfAYpryOamlSthTgwoEwjq+gJ1ytbefUYXwMV42eiS9J+mY QJ+2a+vWe+NeQ5lQkAfA+GwpA1GCcL+BcThgqLccuotEnbuXNy0fhiRURy2Rk/J9oOU+ LqAmFXHQBZsuZDZUTJmKUguqlOkIJFfhTERTCnoYlEt4PdVmE0iELO3YFxPtAACD7SpE eokw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=XawkCOgE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y186si4173027oig.241.2020.01.27.15.21.28; Mon, 27 Jan 2020 15:21:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=XawkCOgE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726296AbgA0XUC (ORCPT + 99 others); Mon, 27 Jan 2020 18:20:02 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:41842 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725955AbgA0XUB (ORCPT ); Mon, 27 Jan 2020 18:20:01 -0500 Received: by mail-pg1-f194.google.com with SMTP id x8so5938371pgk.8 for ; Mon, 27 Jan 2020 15:20:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QT8O29qq6UX2ERtfMZtIcpjsnZ2zWwc1vGjIRRz0cAI=; b=XawkCOgE5DXMC5T4UMCWjNatVuCxPXGElKDJzkypz39qHzpJzBQm4Kjg2Wyc74N8XU ae0RNb4v9jld0zCxnKtoZyL8qTh3A+57E2UqJ/UgP52rejOuyEYKSTX+2MbIBdIK8wvO WFe7hDDB9CBICJzlBnEvr5cP0Jna4twh3KH9c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QT8O29qq6UX2ERtfMZtIcpjsnZ2zWwc1vGjIRRz0cAI=; b=nY6x+kKbu+D/mCTHvbmQbiC3rwlm/TL8LeFFqKN+o/AF4bohJ2a89sRonJP9yFlrOd cXTpsfuhC6C7JPouDuGazrQcSOakmIGmboILa9mrWlSNejKHPVDQNlzhWLLZaOS4wj8w iw4PSBaPlXOaIRrRoamkxb8/I0g8bVAA66DrvMWpPf5tb518W2XPIjZNJJRArkzGE/rr rFx+1lym7JsifEIILVhCmNQwd86QAnrIU8jIIEHWvmOpmX/PFrx+pyrjBnZY8M0y9sco GXl1ombc6/k3Hp5QuJ2jM2SpKuvfJvCfQIk2LEjINVWtx/xIR72KBkcR7wu8+XXxlg0x K1lg== X-Gm-Message-State: APjAAAV2WkxwWuxoGmR4aVPkwvnCFVYwHnerRqrtDQCShdfTJrhM6Puc tOARgGJR54d0pNYYb1oIdaloqg== X-Received: by 2002:aa7:934a:: with SMTP id 10mr1028171pfn.233.1580167201197; Mon, 27 Jan 2020 15:20:01 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m12sm3509886pfh.37.2020.01.27.15.19.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jan 2020 15:20:00 -0800 (PST) Date: Mon, 27 Jan 2020 15:19:59 -0800 From: Kees Cook To: Jiri Slaby Cc: Alexander Viro , linux-kernel@vger.kernel.org, David Windsor , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , linux-mm@kvack.org, linux-xfs@vger.kernel.org, Linus Torvalds , Andy Lutomirski , Christoph Hellwig , Christoph Lameter , "David S. Miller" , Laura Abbott , Mark Rutland , "Martin K. Petersen" , Paolo Bonzini , Christian Borntraeger , Christoffer Dall , Dave Kleikamp , Jan Kara , Luis de Bethencourt , Marc Zyngier , Rik van Riel , Matthew Garrett , linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, kernel-hardening@lists.openwall.com, Vlastimil Babka , Michal Kubecek Subject: Re: [kernel-hardening] [PATCH 09/38] usercopy: Mark kmalloc caches as usercopy caches Message-ID: <202001271519.AA6ADEACF0@keescook> References: <1515636190-24061-1-git-send-email-keescook@chromium.org> <1515636190-24061-10-git-send-email-keescook@chromium.org> <9519edb7-456a-a2fa-659e-3e5a1ff89466@suse.cz> <201911121313.1097D6EE@keescook> <201911141327.4DE6510@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 23, 2020 at 09:14:20AM +0100, Jiri Slaby wrote: > On 14. 11. 19, 22:27, Kees Cook wrote: > > On Tue, Nov 12, 2019 at 01:21:54PM -0800, Kees Cook wrote: > >> How is iucv the only network protocol that has run into this? Do others > >> use a bounce buffer? > > > > Another solution would be to use a dedicated kmem cache (instead of the > > shared kmalloc dma one)? > > Has there been any conclusion to this thread yet? For the time being, we > disabled HARDENED_USERCOPY on s390... > > https://lore.kernel.org/kernel-hardening/9519edb7-456a-a2fa-659e-3e5a1ff89466@suse.cz/ I haven't heard anything new. What did people think of a separate kmem cache? -- Kees Cook