Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4095655ybl; Mon, 27 Jan 2020 16:34:16 -0800 (PST) X-Google-Smtp-Source: APXvYqwsYNyBX6j4blJbgN05JBMFToimgHZMb0KwG9JEY8A4TPjsTHD9PVJABWhyOdNS5lD+ZG39 X-Received: by 2002:aca:190a:: with SMTP id l10mr1255560oii.56.1580171655936; Mon, 27 Jan 2020 16:34:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580171655; cv=none; d=google.com; s=arc-20160816; b=FTH+mHo8zg1nfTVS6Z55sxz9zZULyXYyzAa0M+ihzdEV1ClAGw6J24lxySw2TWUl5d zGyLERr0dFTRVDTtqz3PwJG1HSYun0ICetAIZmjRaTlI4EB62gKdwqZ1kteEbqz6yIun 32ZgJL0kOKDmHjvJlD5ENfU/bwHYsgDa8a4V+HPnmbE9vBGIHamaWWuPK/bqD6YwnIs/ /TR50YPDm8y8VX5HhQ2cMtXCK8IvdxjxGRq39YU+fjw9MPKeTwoIxIi4IHyzCB/S4w2k ilNNinwlTT68TBK/z6X95IPUqVDZzVdQzvMBDHGhFJ2OzesYEueV2Pay/gODFzeIXJh4 Gxkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date; bh=PhIyVbWq73Ahfsggkk/jY0GGChTSFtFPajXkVuULtOc=; b=SsgJ7w+Z13MRMUzzA26Xu2qvwFnVf0sAIY29HfD8Xnnr7uHu2Tg5AlFnQt/jQXifOI dQLAVGNDz5x7M0XAaCBVaGPPFKpZzfmVlU+eNtGNmlhUp96xLQZb8S4IWJ91Wg0p8FtE 7+bvsX0wShJ6AkkiGabXBr5WuGHFuu34HaiFfw6KBvKixvV1hsW10pmt1CVz8PEFtR8i 8JHIqC+t+K82KwbJbZJLflfwX8VxZ+PvtVeiZuNGppIEChzR1dFAg714ol8WN8NsBY5Q PdhzgMogoi89KzOpC5NZVox6zrf7P0l7cSSoZFRS4t/o1Ee6G1p2sS1zieWOHFk1qRPg 088w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k13si3940689oij.118.2020.01.27.16.33.57; Mon, 27 Jan 2020 16:34:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726240AbgA1AbL (ORCPT + 99 others); Mon, 27 Jan 2020 19:31:11 -0500 Received: from mga11.intel.com ([192.55.52.93]:59049 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725955AbgA1AbL (ORCPT ); Mon, 27 Jan 2020 19:31:11 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jan 2020 16:31:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,371,1574150400"; d="scan'208";a="221924501" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga008.jf.intel.com with ESMTP; 27 Jan 2020 16:31:08 -0800 Date: Tue, 28 Jan 2020 08:31:21 +0800 From: Wei Yang To: Michal Hocko Cc: Wei Yang , akpm@linux-foundation.org, yang.shi@linux.alibaba.com, rientjes@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v3 2/4] mm/migrate.c: wrap do_move_pages_to_node() and store_status() Message-ID: <20200128003121.GA20624@richard> Reply-To: Wei Yang References: <20200126102623.9616-1-richardw.yang@linux.intel.com> <20200126102623.9616-3-richardw.yang@linux.intel.com> <20200127093642.GC1183@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200127093642.GC1183@dhcp22.suse.cz> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 27, 2020 at 10:36:42AM +0100, Michal Hocko wrote: >On Sun 26-01-20 18:26:21, Wei Yang wrote: >> Usually do_move_pages_to_node() and store_status() is a pair. There are >> three places call this pair of functions with almost the same form. >> >> This patch just wrap it to make it friendly to audience and also >> consolidate the move and store action into one place. >> >> Signed-off-by: Wei Yang > >I believe I have already acked this one. Anyway >Acked-by: Michal Hocko > Yep, since some change from original code, I dropped your ack. Thanks >> --- >> mm/migrate.c | 61 ++++++++++++++++++++++++++-------------------------- >> 1 file changed, 30 insertions(+), 31 deletions(-) >> >> diff --git a/mm/migrate.c b/mm/migrate.c >> index ae3db45c6a42..e816c8990296 100644 >> --- a/mm/migrate.c >> +++ b/mm/migrate.c >> @@ -1583,6 +1583,29 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr, >> return err; >> } >> >> +static int move_pages_and_store_status(struct mm_struct *mm, int node, >> + struct list_head *pagelist, int __user *status, >> + unsigned long nr_pages, int start, int i) >> +{ >> + int err; >> + >> + err = do_move_pages_to_node(mm, pagelist, node); >> + if (err) { >> + /* >> + * Positive err means the number of failed >> + * pages to migrate. Since we are going to >> + * abort and return the number of non-migrated >> + * pages, so need incude the rest of the >> + * nr_pages that have not attempted as well. >> + */ >> + if (err > 0) >> + err += nr_pages - i - 1; >> + return err; >> + } >> + err = store_status(status, start, node, i - start); >> + return err; >> +} >> + >> /* >> * Migrate an array of page address onto an array of nodes and fill >> * the corresponding array of status. >> @@ -1626,20 +1649,9 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, >> current_node = node; >> start = i; >> } else if (node != current_node) { >> - err = do_move_pages_to_node(mm, &pagelist, current_node); >> - if (err) { >> - /* >> - * Positive err means the number of failed >> - * pages to migrate. Since we are going to >> - * abort and return the number of non-migrated >> - * pages, so need incude the rest of the >> - * nr_pages that have not attempted as well. >> - */ >> - if (err > 0) >> - err += nr_pages - i - 1; >> - goto out; >> - } >> - err = store_status(status, start, current_node, i - start); >> + err = move_pages_and_store_status(mm, current_node, >> + &pagelist, status, nr_pages, >> + start, i); >> if (err) >> goto out; >> start = i; >> @@ -1668,13 +1680,8 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, >> if (err) >> goto out_flush; >> >> - err = do_move_pages_to_node(mm, &pagelist, current_node); >> - if (err) { >> - if (err > 0) >> - err += nr_pages - i - 1; >> - goto out; >> - } >> - err = store_status(status, start, current_node, i - start); >> + err = move_pages_and_store_status(mm, current_node, &pagelist, >> + status, nr_pages, start, i); >> if (err) >> goto out; >> current_node = NUMA_NO_NODE; >> @@ -1684,16 +1691,8 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, >> return err; >> >> /* Make sure we do not overwrite the existing error */ >> - err1 = do_move_pages_to_node(mm, &pagelist, current_node); >> - /* >> - * Don't have to report non-attempted pages here since: >> - * - If the above loop is done gracefully there is not non-attempted >> - * page. >> - * - If the above loop is aborted to it means more fatal error >> - * happened, should return err. >> - */ >> - if (!err1) >> - err1 = store_status(status, start, current_node, i - start); >> + err1 = move_pages_and_store_status(mm, current_node, &pagelist, >> + status, nr_pages, start, i); >> if (err >= 0) >> err = err1; >> out: >> -- >> 2.17.1 > >-- >Michal Hocko >SUSE Labs -- Wei Yang Help you, Help me