Date: Fri, 3 Feb 2006 08:03:30 +0100
From: Joerg Sommrey <jo@sommrey.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, tony@atomide.com,
       len.brown@intel.com, erik@slagter.name, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] amd76x_pm: C3 powersaving for AMD K7
Message-ID: <20060203070329.GA5414@sommrey.de>
Mail-Followup-To: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	tony@atomide.com, len.brown@intel.com, erik@slagter.name,
	alan@lxorguk.ukuu.org.uk
References: <20060202222407.GB896@sommrey.de> <20060202143725.46d218dc.akpm@osdl.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060202143725.46d218dc.akpm@osdl.org>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1349
Lines: 32

On Thu, Feb 02, 2006 at 02:37:25PM -0800, Andrew Morton wrote:
> Joerg Sommrey <jo@sommrey.de> wrote:
> >
> > This is a processor idle module for AMD SMP 760MP(X) based systems.
> >
> 
> Len's comments about loss of cache coherency on some machines possibly
> causing corruption made me drop this patch.   Was I wrong to do so?
> 
You maintain -mm, so it's your decision.  I don't think it is a question
of right or wrong.  If you regard this stuff as too risky, dropping
it is ok.

However, I disagree with Len in two points:
- I cannot see a problem witch cache snooping.  The AMD-768 docs clearly
  states that trying to snoop the cache while in C3 is a resume event.
- Enabling C2/C3 in the BIOS would be a very bad thing IMHO.  From all
  the testing with amd76x_pm I found that is very tricky to go into
  C2/C3 "the right way".  Simply reading the PM register without a
  suitable logic around leads to all kinds of instabilities.  You need
  to implement this logic and then enable the hardware.  The BIOS cannot
  do this.

-jo

-- 
-rw-r--r--  1 jo users 63 2006-02-03 07:43 /home/jo/.signature
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/