Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp131284ybl; Mon, 27 Jan 2020 23:52:20 -0800 (PST) X-Google-Smtp-Source: APXvYqyHCOvmJpXHSCzn08A435idco3rywgjm52BO8zuuZGXjAoC32+sgMkA+nBn3YXq3LcCkXXY X-Received: by 2002:a9d:7342:: with SMTP id l2mr15583347otk.98.1580197940609; Mon, 27 Jan 2020 23:52:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580197940; cv=none; d=google.com; s=arc-20160816; b=pLDUD90cezhwZCuSR4s8ApE6fWIV9sAAn0AYyE99S8sl85F3DVkzYpT3RZekZ1pjlk xW3vsjXD02oCWImckfJkcgep0+q3vJnDSDXkz2vL2riiC2SMUmrOlZKx+Myama904rvK xIpJ4fE367wgfLTxDBFZfQTHPo1ncJxVvhUnTsKDJKVQmwYRqSu0PU+vDFBvVZJ2htJU W4fvIGxGPz8onq7oUicDzkhRIdDakqqX/V9erEA/m51GqKnxhtcjld4ucVWDhVsM5VPY ufJh4Xba5iPPythRHX9Gyb+liP+tMw2YPzIlVNxZlqK5T43PvoRjszoSDLIKmUlh2E9N N5lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=S5T46OkcpLWx0nyNDOt3ECFVVp/D2Y1++NMqEPwwDTM=; b=sKEhlcANsTJaCfIHUzWXjhITzy2oL/XYIQjw5/LhUoDZ71vm30dS0J9jEwSxQFaFb5 AbNR63fflxz59DM8jZo/ArSQ3Pz20t8N2VNGwl/eQzY8Yyt46vGXEvloL6ZNe193s3n5 0BdCn5tMleencR34Er8SCCK8LZ7KiY4fd1Iww+69jWmRjOcQ3govW9KvdJL8TXP1whsy AxaYvppgiDpyKQqyRaTG3qLLve44uTDI8N0q3hioClZ9unsv+PNZt4HYTmY0xiavNbSK NJjOaFzZe0XYkOKolzfcbJRRisDNlqOYCiT3ic1a86UMa+Ke43nbTI9ipiopZqSAUGA8 scpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dyt9jvL5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l132si4075128oib.192.2020.01.27.23.52.06; Mon, 27 Jan 2020 23:52:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dyt9jvL5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725867AbgA1Hux (ORCPT + 99 others); Tue, 28 Jan 2020 02:50:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:54808 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725810AbgA1Hux (ORCPT ); Tue, 28 Jan 2020 02:50:53 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 70EF620678; Tue, 28 Jan 2020 07:50:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580197853; bh=JCv/NyT1mrCMzv4okq1iCXZ4H3lbeVqPn9G8p80jpHo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dyt9jvL5L0NnbDojGspxXNnhsNhkwfABkWI0Z4r7ASOU7AsbfRmykIZJaJ56g6DWJ Np6+0WBmRaH8cp1VdbYbrJkoyFgFQyhoYJ5HGPD7EG4gFeGZsZEGYNjIsquamurMHO +zA1HLMGAxKsUlurc2zGowhd4rL6JzqZEubIQzSM= Date: Tue, 28 Jan 2020 08:50:50 +0100 From: Greg Kroah-Hartman To: Kees Cook Cc: Alexander Popov , Arnd Bergmann , linux-kernel@vger.kernel.org, notify@kernel.org Subject: Re: [PATCH v2 1/1] lkdtm/stackleak: Make the test more verbose Message-ID: <20200128075050.GC2105706@kroah.com> References: <20200102234907.585508-1-alex.popov@linux.com> <202001271514.345A5CC9C@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202001271514.345A5CC9C@keescook> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 27, 2020 at 03:15:08PM -0800, Kees Cook wrote: > On Wed, Jan 22, 2020 at 02:58:44PM +0300, Alexander Popov wrote: > > On 03.01.2020 02:49, Alexander Popov wrote: > > > Make the stack erasing test more verbose about the errors that it > > > can detect. > > > > > > Signed-off-by: Alexander Popov > > > --- > > > drivers/misc/lkdtm/stackleak.c | 25 +++++++++++++++++-------- > > > 1 file changed, 17 insertions(+), 8 deletions(-) > > > > Hello! > > > > Pinging about this version of the patch. > > > > Kees, it uses dump_stack() instead of BUG(), as we negotiated. > > Yup, this is in my queue -- I've just gotten back from travelling and > will get to it shortly. :) > > Greg, feel free to take this directly if you want, too. If I were to take it, it would have to wait until after 5.6-rc1, sorry. thanks, greg k-h