Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [Patch v8 1/7] sched/pelt: Add support to track thermal pressure
To:     Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Peter Zijlstra <peterz@infradead.org>
References: <1579031859-18692-1-git-send-email-thara.gopinath@linaro.org>
 <1579031859-18692-2-git-send-email-thara.gopinath@linaro.org>
 <20200116151724.GR2827@hirez.programming.kicks-ass.net>
 <e5ecad29-11d8-e7ff-27ff-b63ca44fdcd3@arm.com> <5E2B405A.7040405@linaro.org>
 <6232d91d-2603-06ca-0e7c-66ec2a137759@arm.com>
Cc:     mingo@redhat.com, ionela.voinescu@arm.com,
        vincent.guittot@linaro.org, rui.zhang@intel.com,
        qperret@google.com, daniel.lezcano@linaro.org,
        viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
        amit.kachhap@gmail.com, javi.merino@kernel.org,
        amit.kucheria@verdurent.com
From:   Thara Gopinath <thara.gopinath@linaro.org>
Message-ID: <5E3037F3.30507@linaro.org>
Date:   Tue, 28 Jan 2020 08:32:35 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <6232d91d-2603-06ca-0e7c-66ec2a137759@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 01/27/2020 04:28 AM, Dietmar Eggemann wrote:
> On 24/01/2020 20:07, Thara Gopinath wrote:
>> On 01/23/2020 02:15 PM, Dietmar Eggemann wrote:
>>> On 16/01/2020 16:17, Peter Zijlstra wrote:
>>>> On Tue, Jan 14, 2020 at 02:57:33PM -0500, Thara Gopinath wrote:
> 
> [...]
> 
>>>>> +#ifdef CONFIG_HAVE_SCHED_THERMAL_PRESSURE
>>>
>>> I assume your plan is to enable this for Arm and Arm64? Otherwise the
>>> code in 3/7 should also be guarded by this.
>>
>> Yes. I think it should be enabled for arm and arm64. I can submit a
>> patch after this series is accepted to enable it.
>> Nevertheless , I don't understand why is patch 3/7 tied with this.
>> This portion is the averaging of thermal pressure. Patch 3/7 is to store
>> and retrieve the instantaneous value.
> 
> 3/7 is the code which overwrites the scheduler default
> arch_cpu_thermal_pressure() [include/linux/sched/topology.h]. I see it
> more of the engine to drive  thermal pressure tracking in the scheduler.
> 
> So all the code in 3/7 only makes sense if HAVE_SCHED_THERMAL_PRESSURE
> is selected by the arch. IMHO, 3/7 and enabling it for Arm/Arm64 should
> go in together.
Hi Dietmar,
I will have to respectfully disagree here. We explicitly separated out
this stuff (updating and reading of instantaneous thermal pressure)from
scheduler. To me putting all this under HAVE_SCHED_THERMAL_PRESSURE is
equivalent to keeping this stuff in scheduler specific code. But I will
provide a patch enabling the option HAVE_SCHED_THERMAL_PRESSURE in
arm64/defconfig. arm is trickier though as it has a bunch of SoC
defconfigs. I will leave it out for now .


-- 
Warm Regards
Thara