Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp436528ybl; Tue, 28 Jan 2020 06:00:51 -0800 (PST) X-Google-Smtp-Source: APXvYqzLxIRFuyYRamZ33+5BVUkKL2F0YBxNWfaRmwD7KXSDnE22aF0IGOpmilZrgdZL7YHrvrZv X-Received: by 2002:a05:6808:4cc:: with SMTP id a12mr2917489oie.115.1580220051357; Tue, 28 Jan 2020 06:00:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580220051; cv=none; d=google.com; s=arc-20160816; b=JmdKx0KtGooQRn/b3QzPGXyiosO6755ZdTLjB7zDKpcOukZ2hwnTcDDbgT3MS2xJsg elxKfph5/E4YitQ/A2fmEIzQu8P7+K3XR1sASQI/IMXH6RWXaGlLy6awVgYVhgeGKTaS NDPXfBhAGfnlijV5/im5NKir1MpU0btpmZY8MuPsl+RG44lqg3cWsdPMFjVZsYQ2eG0E 2bbx4WddjwAsX9M4M3/q8foSjzmm9GhzOLRcJ08YcL9oJR9nmq5dgeethHra4z3V8XDd nS4af75AlqsVMN42na/6JV3cucRKctSBnDggSnEwegKILzQM8a/c+tNrFCFuDov4cTm5 rtgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=apcUrs/8/DuvCbC3JZrGOxkySOQNWeZcErfcfBm0ggM=; b=olqZwTXYsGBmbRNtuMVhfxmHKHqUG2Gs6b/YCmnhcxxw5OMNnAf4GUOiF7tz42SUOM DPEbBdAhMLWxKMdNrf0f/3sGsz1cBd6Kyp/Jy9M9I3UKHdzXZrsOMQpM+EhUo/mAJzvR hS/Hu5YnW6Sij3Jqmhy/RcmCc+v8bhB+1ZyqOt3pNiGsFYU4HsqatL1dB8F5v2NBntgV YaQoY0UcO1rIuQ7/FoAmzq0Ee9Gjz4gwoohchIdiaMfp3ndh+Nciv0wDuMOdE6BUuCu2 cVbWtA7qqth/o65UFYD31yUjpGYiwJeyHn1+FedGUxZjh8bslB0S6W6jlw8/wFObzSVR RbeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tfpSWcE2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f5si6528487otp.129.2020.01.28.06.00.39; Tue, 28 Jan 2020 06:00:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tfpSWcE2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726821AbgA1N7S (ORCPT + 99 others); Tue, 28 Jan 2020 08:59:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:44520 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726794AbgA1N7N (ORCPT ); Tue, 28 Jan 2020 08:59:13 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A9DAE24694; Tue, 28 Jan 2020 13:59:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580219953; bh=OEsGfAD1Z+hIdPREY+MSLf1P6cwvF10/s8/wQSWnvaQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tfpSWcE2GL08L3iKLD58/fdNkfzQvDHYIzhF0lcmE5QysajWq04KuEx42m86x8R0I TUH85O7pirTM2r0eFKxMepU02R/0TI+4j0VVp1NG4ekUewAmpxIi1fj0LguFLhlW/E N1eo3OUrnIwaw/moDvocGtUyFFXU4LaK3BZHew6M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Dumazet , Jouni Hogander , "David S. Miller" Subject: [PATCH 4.14 10/46] net-sysfs: fix netdev_queue_add_kobject() breakage Date: Tue, 28 Jan 2020 14:57:44 +0100 Message-Id: <20200128135751.442708030@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135749.822297911@linuxfoundation.org> References: <20200128135749.822297911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet commit 48a322b6f9965b2f1e4ce81af972f0e287b07ed0 upstream. kobject_put() should only be called in error path. Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject") Signed-off-by: Eric Dumazet Cc: Jouni Hogander Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/core/net-sysfs.c | 1 + 1 file changed, 1 insertion(+) --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c @@ -1339,6 +1339,7 @@ static int netdev_queue_add_kobject(stru #endif kobject_uevent(kobj, KOBJ_ADD); + return 0; err: kobject_put(kobj);