Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp439249ybl; Tue, 28 Jan 2020 06:02:49 -0800 (PST) X-Google-Smtp-Source: APXvYqwx2xHYH6bOMwCmTwehRFxhEXWeTPUkzhPo4xeftyrXhsKz8NVj1MdPWkhm7o2d9XyG43D4 X-Received: by 2002:aca:b4c3:: with SMTP id d186mr2754167oif.131.1580220169013; Tue, 28 Jan 2020 06:02:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580220169; cv=none; d=google.com; s=arc-20160816; b=DtiepxthMYmXIBlWONT68dI/olTbhCc5xvtjCWLiJak40ZBiDp3dCXSuSM65sWLwyr rNaKrg0J8B/BJvF+OlugSNK16rLtAS3tUpFXFL8kCxlvstz0XyE9maXJgarnvfHi0EhI AF5X9dOJytTGPsSn8jJcEU142ydRDoDGbfo96knyC0sm1jwtyp2ZwoJhtFzI/66AXaYw iGL/nuyTSAAflFprzjvwMH+QmmntT+bTUuSDMlqOLRGBMi0voet2eK+14X8OMSRJaGv8 e8qTAEwrQeiIFM2rylg0J1DQXG4bEbZVxbiJs9mFqLQhzly4AVYpCLbDXz8hmdTwK+xy Rnug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5JtIZLqeBpK4TveaWZLyZKO04ipkKnROzsgw7msRz5s=; b=BiOCo4feHf2CcAXclURViAhyguLPKhWNC6CBSX0BCYWPk0LnfRj3chSTyLBiEx0zFj DYgoUQ+bKF6ubRNwgLK5KvuFqksO5m63KzEE/EXOoHXR5IVbZc7fKQ1kLJua68aJc4Zf 9TmwWjxDKjP6Te0nFkWfelOGKZY5dMZIlanJwcm6ZzeHfLVwufFoAihQTpTlIXFwEeg0 nL1n2mSjafBYdFreya+nWqIQ3OLIii3iQmxV/DL/aZ1VKKv4Qzm5Dw+tAOnYiBHHdczX jcgOrPDXEUtdl6FDybmJaLWa06PhvnvjpMjOyPn81A1KMQsZjco5HTTcYUbqsf9v5tP2 vYNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=U3LgxbHn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v25si2086807oiv.144.2020.01.28.06.02.28; Tue, 28 Jan 2020 06:02:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=U3LgxbHn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726742AbgA1OAd (ORCPT + 99 others); Tue, 28 Jan 2020 09:00:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:45816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726273AbgA1OAK (ORCPT ); Tue, 28 Jan 2020 09:00:10 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3A7EC2468A; Tue, 28 Jan 2020 14:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220009; bh=TWHetQeApuPwWwnFAnNwR4s/mLNZZaOaZdJP3JYknWg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U3LgxbHns+4Nw2wK0uMOD7HlllTF2hB68Ie+LukC2/bQ+pZFVlWt8Vpr50NeP532a rORpn4gt5Y2lEop/Tu7a7MFcVlJuz05EL4sZuafpA1XNJjlwTV3vn+V88+gnwsvHjP PVW54M9RaYsiZwMkQgkdEtB9STFIQnwcwsKVBPnI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Dmitry Torokhov Subject: [PATCH 4.14 32/46] Input: sun4i-ts - add a check for devm_thermal_zone_of_sensor_register Date: Tue, 28 Jan 2020 14:58:06 +0100 Message-Id: <20200128135754.144302291@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135749.822297911@linuxfoundation.org> References: <20200128135749.822297911@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan commit 97e24b095348a15ec08c476423c3b3b939186ad7 upstream. The driver misses a check for devm_thermal_zone_of_sensor_register(). Add a check to fix it. Fixes: e28d0c9cd381 ("input: convert sun4i-ts to use devm_thermal_zone_of_sensor_register") Signed-off-by: Chuhong Yuan Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/touchscreen/sun4i-ts.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) --- a/drivers/input/touchscreen/sun4i-ts.c +++ b/drivers/input/touchscreen/sun4i-ts.c @@ -246,6 +246,7 @@ static int sun4i_ts_probe(struct platfor struct device *dev = &pdev->dev; struct device_node *np = dev->of_node; struct device *hwmon; + struct thermal_zone_device *thermal; int error; u32 reg; bool ts_attached; @@ -365,7 +366,10 @@ static int sun4i_ts_probe(struct platfor if (IS_ERR(hwmon)) return PTR_ERR(hwmon); - devm_thermal_zone_of_sensor_register(ts->dev, 0, ts, &sun4i_ts_tz_ops); + thermal = devm_thermal_zone_of_sensor_register(ts->dev, 0, ts, + &sun4i_ts_tz_ops); + if (IS_ERR(thermal)) + return PTR_ERR(thermal); writel(TEMP_IRQ_EN(1), ts->base + TP_INT_FIFOC);