Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp442480ybl; Tue, 28 Jan 2020 06:05:17 -0800 (PST) X-Google-Smtp-Source: APXvYqw+BM3fY0WgijxtCL5/RgnCVeyl2KdHpCDpcCc1RtWQzypoa79iOkCiN0t7uHs/IetopC/H X-Received: by 2002:a9d:138:: with SMTP id 53mr3514093otu.230.1580220317716; Tue, 28 Jan 2020 06:05:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580220317; cv=none; d=google.com; s=arc-20160816; b=VOsjCjRWfMqLBQAqlGKNbcqJ1YZ63sfrcafnU9R0ZhtoASwNfbuIoB/OgD2POaTT9y fIBSmwZLEPZemMP48B+GrlAElmlDyHR1DF/PEulZE6osROThqc9GnWrw6ASDyzla82fP 3+a0Z1sKginiMjSt5jk2jiCEi6J6iWNQxYZp7kdPc+1kslOIXs3l+F/MMELSrzZCJZKE 2dzChQlmuvHl1wzb9NcL884tHM3ZVx6o1wUgA0pVukvLLy6oPrHcH0UaKiJZUayGid0Q xRe8cJ+bD9uqSMXkdhffdjTl1c79n1S56vxg2ZSgesmWrOvR8gk7OFRdn5j6iWEehfqH VGiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jHyVEanlWeOc1wp+JdyAjFWXX3NNNTEZsrZwj5R9lZE=; b=WlEfEJo+GUa4RqZJtpmWIdxp2GvNDUPWNs7GCGl5/RQK5rvQz9L8MqEA9nETY5entr v580iqZ0Ir6gJtSnbnkUIRCPOYi9HLkoRyIK+ZK8afRzWhAQsLGcOPcqi7c8bNXiCh0G FQaZSH6xfIAuaXRrqz4wnZ4rp0BJt0I3gkfV9M6OjA8k5qlh70LeSTsxAdEl6f2C2X32 dZ9DiV8meDPYrMPg3rEJY3QolZUgEkKW3l+9Zu1zhX/mYK9FSkw8VjkcizPhOws1Yrrh IUh2TsBiVVbdVwGhamjcMCE8f+zWg2MtO3PL4vWzVKIpDg5QCD1VeFu5iSdXGZT9oiqq 0w1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=l+xvT8RP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j13si7967529otq.146.2020.01.28.06.04.51; Tue, 28 Jan 2020 06:05:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=l+xvT8RP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727615AbgA1OCX (ORCPT + 99 others); Tue, 28 Jan 2020 09:02:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:48632 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726967AbgA1OCV (ORCPT ); Tue, 28 Jan 2020 09:02:21 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E2D4024683; Tue, 28 Jan 2020 14:02:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220141; bh=gw2aZ1LbbeRJTTJCpYwXXL2rPlgmBOh3zKCfCJdZV6g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l+xvT8RPZTqAUrevFiFsN6X2kZGQwY7yqmHAHOLr1UhpE/jPiC/FjShWSYYtLdclk jXlGMYCcVYRKEcGWJhsUa+pcjuPM1YU3qIBsPNexyt0pXgxUPMr6XzMk95ZEcSfjfU 5bn0u0iWFuE6gly9o8z5HcqtvD/1Ew2spjsp8CFs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andres Freund , Jens Axboe Subject: [PATCH 5.4 033/104] Revert "io_uring: only allow submit from owning task" Date: Tue, 28 Jan 2020 14:59:54 +0100 Message-Id: <20200128135821.839050866@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135817.238524998@linuxfoundation.org> References: <20200128135817.238524998@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jens Axboe commit 73e08e711d9c1d79fae01daed4b0e1fee5f8a275 upstream. This ends up being too restrictive for tasks that willingly fork and share the ring between forks. Andres reports that this breaks his postgresql work. Since we're close to 5.5 release, revert this change for now. Cc: stable@vger.kernel.org Fixes: 44d282796f81 ("io_uring: only allow submit from owning task") Reported-by: Andres Freund Signed-off-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman --- fs/io_uring.c | 6 ------ 1 file changed, 6 deletions(-) --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -3716,12 +3716,6 @@ SYSCALL_DEFINE6(io_uring_enter, unsigned wake_up(&ctx->sqo_wait); submitted = to_submit; } else if (to_submit) { - if (current->mm != ctx->sqo_mm || - current_cred() != ctx->creds) { - ret = -EPERM; - goto out; - } - to_submit = min(to_submit, ctx->sq_entries); mutex_lock(&ctx->uring_lock);