Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp442656ybl; Tue, 28 Jan 2020 06:05:25 -0800 (PST) X-Google-Smtp-Source: APXvYqwHa5jhYo0tZxzburx4yyCxxOjPi8mAZj9Nxfi1wRYKAFtNQaWtUzosLgBJzYxwelAA7kHh X-Received: by 2002:a9d:6745:: with SMTP id w5mr16958267otm.52.1580220324852; Tue, 28 Jan 2020 06:05:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580220324; cv=none; d=google.com; s=arc-20160816; b=tBXZWFMkwRR2n9GUphDGRT3LLKfVbihPqNAAj/6EdY46M3HqbxhBvBFRJHXUZx1qd3 cu/z1Zm22SX/QLWDYqcik8hfAHL+NgAcC8XlaMvY7AfEBwumRaGM/xQy7Q5T6KhYsoKP tH1pEwCiBW8hScW/eu56I5AI/skv1zD8b46BNmPX5UON9IJJ6Mu3VOHm27vHcACuMcBt 2Hxu/DUhJignHyLDg1TU7lquaD6kFhGv7ywi/cjCfMvPjJRi6CPDbHHcMtqY9P8ywusK OeTx0aGnWviPjQaEM2in2LnUpLbUXNHLolUV3f5T4XzPOG0O5EPpp+QLPe2vSRaDFtJK EXCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=73sf0w2vGn8z+elmHrrr/LvKMcrxy8iIoDkcJpVt0UE=; b=jy2mnu5o9B7t7TsFZT3egWLOe4jBiaUOhhAjUcMgVJmlHico5cD6xPwt3+ZZWrxjFn oMxRYz7LnyvNZLsrf4HBlfvDbTSkU04YVVY/uLea7cb17WmXnOvBfm0Vv2yH6llL69Wt 4NtWgRCxmZOXTqzXWCjMToAvuedYWzOva6073kkCXh7I5P7pzKuEkBLjWbJ3Qb6yfFd8 Bj/ip4P49lOylp2BpwlHcn+amybBuA1d0XP54ZRQ9PRKSzabfAAMhTqpv1Ck8OgBCgpD ejBy4a7bL/QVTTCb/ltJP2gTL7SDezUF/aZdVKJ1URzuapffCE5UxncvCU/1agoN8paE 5M8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eMeEG6Of; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x186si5048303oig.209.2020.01.28.06.05.00; Tue, 28 Jan 2020 06:05:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eMeEG6Of; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727611AbgA1OCR (ORCPT + 99 others); Tue, 28 Jan 2020 09:02:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:48522 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727590AbgA1OCO (ORCPT ); Tue, 28 Jan 2020 09:02:14 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A4A7724683; Tue, 28 Jan 2020 14:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220134; bh=kzoeI0KGtDBmmy5T6mosoSPAI094vzMh7ao939kS9b8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eMeEG6OfAWpEPq+wMLM3XMVsyrp5Cs/7tdGOi1Puj5dIZrK3hg/tUpFRmCOmCKWri JNqioo1ygZ1AnY4ThCI82SD3/mRHyL4eG/Hif/Pe+mlQwi+BtCPk+JnHLFxfxH+c3m Ekul8RqVFxC0iIJRyEHFpVqzw4LqtoAgV0yRDWvY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tariq Toukan , Boris Pismenny , Saeed Mahameed Subject: [PATCH 5.4 030/104] net/mlx5e: kTLS, Remove redundant posts in TX resync flow Date: Tue, 28 Jan 2020 14:59:51 +0100 Message-Id: <20200128135821.437418563@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135817.238524998@linuxfoundation.org> References: <20200128135817.238524998@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tariq Toukan commit 1e92899791358dba94a9db7cc3b6004636b5a2f6 upstream. The call to tx_post_resync_params() is done earlier in the flow, the post of the control WQEs is unnecessarily repeated. Remove it. Fixes: 700ec4974240 ("net/mlx5e: kTLS, Fix missing SQ edge fill") Signed-off-by: Tariq Toukan Signed-off-by: Boris Pismenny Reviewed-by: Boris Pismenny Signed-off-by: Saeed Mahameed Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c @@ -383,8 +383,6 @@ mlx5e_ktls_tx_handle_ooo(struct mlx5e_kt if (unlikely(contig_wqebbs_room < num_wqebbs)) mlx5e_fill_sq_frag_edge(sq, wq, pi, contig_wqebbs_room); - tx_post_resync_params(sq, priv_tx, info.rcd_sn); - for (; i < info.nr_frags; i++) { unsigned int orig_fsz, frag_offset = 0, n = 0; skb_frag_t *f = &info.frags[i];