Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp443824ybl; Tue, 28 Jan 2020 06:06:18 -0800 (PST) X-Google-Smtp-Source: APXvYqxS/6P8H+DTrnKHEVnGtLrEE8D3ZViQX4tZNqjW1XPhDLG/TAlvaesyfZxB7XhxdPf6xrq4 X-Received: by 2002:a05:6808:4c7:: with SMTP id a7mr2942444oie.83.1580220378320; Tue, 28 Jan 2020 06:06:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580220378; cv=none; d=google.com; s=arc-20160816; b=ubDNBivKvv9Rmmw5yBpwdNfX1OTxiBb+m1PH1gONzt7asElmbd8hzlS4FQbUFd9EoY 6z8mEEzej+chP9Q5hg4lq7iYeTZ0XTmuSZDBRdqTD+jCSJDSaZjLXbOjV6eTxSE4Xj9Z G4rQUqHuFKuofWVPwnNni784RyVi8yNZlbgGo8Tm2sB+4ThrlJpsoTLawv7OMfC1yG5k BsT58SCqEYGv2jGshSMhGSiiLcxzT+FptRDchSbk3x1MQdBBtfEYUwZXVSJml8FJnaGe cTgo6Key62uYk4pA0rOUExl+TYjr+t5sm1khzjqN0+34SNN9m0ikFkGC78Bu332rslmN EWBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qlcDfn7TlpcLi1ENP2hr2h/67yly3KW57tPRYUjlr1I=; b=iZvfIF8jFBExlZLEyF9EC8yqxGaruvF0IfpzbBL2BuooU7tO5B4M8wn6NQVjeY8NM6 eZ9HbbMoXF3dlucJ5A8nOE8WgT0MeIxO4Bon8glBrjRnfirFeL80x9C4WuzJXoZQd/4B q5kh5GpmRiOEobVste/+1Yg8RlfJJ/HLyvdDDOmPcwjxVOHeXN0vpGIAvum34/8L0Ttl xvNAh2Y0kRtGxR7Bt4h1NSCAkxdZquJ+5KUHe6VLupS1Gb2TMij5iI12kb2zl3NcFv8w ATBWbIf00OAEW5Mubx2FFpTEe2bJzovqvLhzN7qctWcUETeM5RptE2J4sJONFOJQ1nH8 kBqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=R2mxzsOO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l20si8687976otd.292.2020.01.28.06.05.58; Tue, 28 Jan 2020 06:06:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=R2mxzsOO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727888AbgA1ODd (ORCPT + 99 others); Tue, 28 Jan 2020 09:03:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:50240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727877AbgA1OD3 (ORCPT ); Tue, 28 Jan 2020 09:03:29 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE5FF2468D; Tue, 28 Jan 2020 14:03:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220209; bh=A24LsO0d3DuD+wDWWl1ud8hGDPwxevJPgWeuw9uy1A4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R2mxzsOObio9PlkHRsDcOQfq+SkcQSjKawmyRD+C/EzeU2Qn4iGSK/9n29CtIbF8C cfhYAo2yjnjX7tvgKM0lp4AsS+jKFvNW1dW5Rw4ZLBpxqtcvUEk91SCsseywSLEH/Z 1/6sAqQ8lS+GhvLatsde++E/QcRQINKXOgAF8PWU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Faiz Abbas , Adrian Hunter , Ulf Hansson Subject: [PATCH 5.4 060/104] mmc: sdhci_am654: Remove Inverted Write Protect flag Date: Tue, 28 Jan 2020 15:00:21 +0100 Message-Id: <20200128135825.883055904@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135817.238524998@linuxfoundation.org> References: <20200128135817.238524998@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Faiz Abbas commit 4d627c88546a697b07565dbb70d2f9f46a5ee76f upstream. The MMC/SD controllers on am65x and j721e don't in fact detect the write protect line as inverted. No issues were detected because of this because the sdwp line is not connected on any of the evms. Fix this by removing the flag. Fixes: 1accbced1c32 ("mmc: sdhci_am654: Add Support for 4 bit IP on J721E") Cc: stable@vger.kernel.org Signed-off-by: Faiz Abbas Acked-by: Adrian Hunter Link: https://lore.kernel.org/r/20200108143301.1929-2-faiz_abbas@ti.com Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/mmc/host/sdhci_am654.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) --- a/drivers/mmc/host/sdhci_am654.c +++ b/drivers/mmc/host/sdhci_am654.c @@ -249,8 +249,7 @@ static struct sdhci_ops sdhci_am654_ops static const struct sdhci_pltfm_data sdhci_am654_pdata = { .ops = &sdhci_am654_ops, - .quirks = SDHCI_QUIRK_INVERTED_WRITE_PROTECT | - SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, + .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN, }; @@ -272,8 +271,7 @@ static struct sdhci_ops sdhci_j721e_8bit static const struct sdhci_pltfm_data sdhci_j721e_8bit_pdata = { .ops = &sdhci_j721e_8bit_ops, - .quirks = SDHCI_QUIRK_INVERTED_WRITE_PROTECT | - SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, + .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN, }; @@ -295,8 +293,7 @@ static struct sdhci_ops sdhci_j721e_4bit static const struct sdhci_pltfm_data sdhci_j721e_4bit_pdata = { .ops = &sdhci_j721e_4bit_ops, - .quirks = SDHCI_QUIRK_INVERTED_WRITE_PROTECT | - SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, + .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN, };