Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp451214ybl; Tue, 28 Jan 2020 06:11:53 -0800 (PST) X-Google-Smtp-Source: APXvYqzd2zAns4YiY1ITVUYtBTIIx507kROmUWQ0SrnbUe3oRf4bIwKdBDbwbciSv4jRC7oEW5Yo X-Received: by 2002:a9d:75da:: with SMTP id c26mr16774070otl.40.1580220713344; Tue, 28 Jan 2020 06:11:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580220713; cv=none; d=google.com; s=arc-20160816; b=YbkeA/IOF0xxpirzvzP5ZQNg83xat4KrwRC72zliPVhxNWOIOhsczUoki0r/U3d6Sm desX9s3PFWPPKPbw5yBTOgLzwxXDpVL+JJTOhP5Kh2AeLiNJUGlTz32Pox3NjsvjmDV1 +yTfqCyomyaKlCW6r4iVNUY1A0729WfODLLRU0twOXHODUBibdqkpBkT9OVI/cDNa3ZZ 0vyZq8xgR6jG6DXQQTz4iFyKlhMwg3BcFp/wyW8+Ns2A1cjZhvyS8J47EG/yJr5S9mhL 2v44wdyOEeXPIChLA2OKw9DpgTB32BLnpPFHegMTyMEJnNXdUsNIvHHsy/EwbYoVT5cD su4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=yQ1IdSUe1s+PYp5DqalyDXBKv91O1F8KFv3nYtLgcGM=; b=J3KFOmc4YXejdzh0b9/gEVyMfoeRhoq2NV/lD3RjFpg8jHo8bVDoEkQoOCoeXHxKtz q5I7zrwZ2JjiWIRK1SUxE2iZBOqb+y3VSHN80G0m4l5+YTvVS6kio4mAbhL5SxOgjy3A my0rZjiUtagoWRjxKYHuIDSvP8obH42xlyJEKOxW4GJdKW2+JF6Fu7K8mVqgx7tPvJQM I4Nw4tjVLcyj7H+wMnUFW6FZKSXTB/FHxs3FQNeZbgBwLpUhV5KQMPtGb/Pnk5TeRQWC IqlzxqLEbSHDSH0d0cHMSTa4y5wOjdyCKY0iDfbRs/WICiDuLxXRqUV7ys699mthLwv3 g/Jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Z2dCgyrH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t25si5455186oic.183.2020.01.28.06.11.38; Tue, 28 Jan 2020 06:11:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Z2dCgyrH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729167AbgA1OKb (ORCPT + 99 others); Tue, 28 Jan 2020 09:10:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:59344 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729151AbgA1OK3 (ORCPT ); Tue, 28 Jan 2020 09:10:29 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F236824685; Tue, 28 Jan 2020 14:10:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220629; bh=64tjRuPo32NZZurslVMyoDVjsRyc8RxmUOy72LQs6fE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z2dCgyrHIL+kjVwRX/ZDd0mWZbbp0RS11Q5OS8q7PIwnt0wQuy3MR2RT7mWRltxTL TQJI6tK1OuhBiwer9q609kVSaWlQiy1aN0Idns9WykY9qyXw2gjRdoT6kckiyZuGwz QXouOvtjJxGzRaMJIrQVDvo2syxEzZWj5XyA6l/E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jerome Brunet , Mark Brown , Sasha Levin Subject: [PATCH 4.4 084/183] ASoC: fix valid stream condition Date: Tue, 28 Jan 2020 15:05:03 +0100 Message-Id: <20200128135838.343775756@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135829.486060649@linuxfoundation.org> References: <20200128135829.486060649@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jerome Brunet [ Upstream commit 6a7c59c6d9f3b280e81d7a04bbe4e55e90152dce ] A stream may specify a rate range using 'rate_min' and 'rate_max', so a stream may be valid and not specify any rates. However, as stream cannot be valid and not have any channel. Let's use this condition instead to determine if a stream is valid or not. Fixes: cde79035c6cf ("ASoC: Handle multiple codecs with split playback / capture") Signed-off-by: Jerome Brunet Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/soc-pcm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index 78813057167d7..dbdea1975f90c 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -48,8 +48,8 @@ static bool snd_soc_dai_stream_valid(struct snd_soc_dai *dai, int stream) else codec_stream = &dai->driver->capture; - /* If the codec specifies any rate at all, it supports the stream. */ - return codec_stream->rates; + /* If the codec specifies any channels at all, it supports the stream */ + return codec_stream->channels_min; } /** -- 2.20.1