Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp451997ybl; Tue, 28 Jan 2020 06:12:32 -0800 (PST) X-Google-Smtp-Source: APXvYqwZab5epszujOXQF5SH7zdQ74tp8HIr2vK3iKZ5nTSsNXdbzCLrv6j3aYWzN8Zr2ySTNEJx X-Received: by 2002:aca:59c2:: with SMTP id n185mr2979683oib.170.1580220752021; Tue, 28 Jan 2020 06:12:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580220752; cv=none; d=google.com; s=arc-20160816; b=R7vrSKd/DxMnr9jSaN7L9v/Z0ydZZU1o2KbvU9RR/jgXAbIvrWnDNbhqph3X9RSdVg RofTPhZMavK/BZUZetsghQq4BcY6tSpct6O9eTC2Zjcj0u7kGYtEzbHO7IAtJfPPGv7T ajcCCW0zN4sfu91C8VlqO+TZfs2EzFLqWYO/dEyzOCDyM41uEad0c7gTJxVMLD02xAUB vGfxDXi1z0wCuoTe5FVFg/yWNy4EDc80hF4XN/+Ku6Q2Kb/CZerBjRiNyenI/Tx281jx WUQiiOGLY3xtWKU3IsOnAZ5t8luQqGbxBWMIimQN4ycWYUhSa6ZtWBjIqSjuO4iPxMEZ GAug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7dQW252pAitxvNltTXj/FOVoYSPvQ1DntZvh+WpbXd8=; b=mI9PKgbLDd5JDjHOsUyj6hNOJiowhBJM4KSFixazS7K3d8XQC7UdhTmX0J7iYhgmk1 o6JskUtJaGd8BKHlu/BO/2VbeCkoEbyef6bdgEPdeKk+8/yg/w1n6G8faSeLpho8zGhG tn8j6620D7s0/xuaWP4neHunn7jNBvjd8yvBaviHwzRkzAeAhxzuQSpmlx89RBDI8TXP 55J47RXsE31p8Bd9UP6ZuG8N4tDKOZwXpSJ/x5wpGGU4jbBuBtRlK1BzTgEv9B9FBfnO FxSz+lU2HNTJfggM9dtEicfOZ00QRlB5Mrn9Okg44YyJ5vngeCEwwnoVqI43tszj2mxz aSPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mPyGn1qJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f194si5473557oig.243.2020.01.28.06.12.18; Tue, 28 Jan 2020 06:12:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mPyGn1qJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727725AbgA1OKF (ORCPT + 99 others); Tue, 28 Jan 2020 09:10:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:58610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729075AbgA1OKC (ORCPT ); Tue, 28 Jan 2020 09:10:02 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 525F724685; Tue, 28 Jan 2020 14:10:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220601; bh=FjKs7kj1QyIdMdGW6JMz6tb12uo0pJoik3pgWS1XT2M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mPyGn1qJH7Zdm69iOGFH3P0OO7wgyr4rsiRWQhmS80VU5m5p4M6GWJT5PpQtqXWZZ tum0G4CWQHbn7mSanbHduZw21oyFrogLIEe5saCdssqFXIMKrxDZ5FKM2+JWIPHqnY X/QvdZbKQGjQEt2DTIUGsOibc0V5eKkV8rHATgms= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Biggers , Herbert Xu , Sasha Levin Subject: [PATCH 4.4 035/183] crypto: tgr192 - fix unaligned memory access Date: Tue, 28 Jan 2020 15:04:14 +0100 Message-Id: <20200128135833.524246053@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135829.486060649@linuxfoundation.org> References: <20200128135829.486060649@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Biggers [ Upstream commit f990f7fb58ac8ac9a43316f09a48cff1a49dda42 ] Fix an unaligned memory access in tgr192_transform() by using the unaligned access helpers. Fixes: 06ace7a9bafe ("[CRYPTO] Use standard byte order macros wherever possible") Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- crypto/tgr192.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto/tgr192.c b/crypto/tgr192.c index 321bc6ff2a9d1..904c8444aa0a2 100644 --- a/crypto/tgr192.c +++ b/crypto/tgr192.c @@ -25,8 +25,9 @@ #include #include #include -#include #include +#include +#include #define TGR192_DIGEST_SIZE 24 #define TGR160_DIGEST_SIZE 20 @@ -468,10 +469,9 @@ static void tgr192_transform(struct tgr192_ctx *tctx, const u8 * data) u64 a, b, c, aa, bb, cc; u64 x[8]; int i; - const __le64 *ptr = (const __le64 *)data; for (i = 0; i < 8; i++) - x[i] = le64_to_cpu(ptr[i]); + x[i] = get_unaligned_le64(data + i * sizeof(__le64)); /* save */ a = aa = tctx->a; -- 2.20.1