Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp453587ybl; Tue, 28 Jan 2020 06:13:50 -0800 (PST) X-Google-Smtp-Source: APXvYqyxPoshC0omNq9edXXPbsObU2thsNKwCEQZVo7JwnpcpgQrhebi0pjvYFAyfAdCSpfy/K+k X-Received: by 2002:a05:6830:1d55:: with SMTP id p21mr16513492oth.145.1580220830442; Tue, 28 Jan 2020 06:13:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580220830; cv=none; d=google.com; s=arc-20160816; b=Kos2yNRxYvbT2V+9rFN+8/IMg3fNqdx51boXKGPp6f5qSsEWs2N7I/MY8BA6hGz3GV srJz9j/XV8VRO5mogzvhOdJiOCKXzc6WoIdT5XvhBb5XpagyX+sHbyb8ZaXMZIMcf5vV pwokNanwDqnK+xxXzsLRoV588yQK+NNDAkKJKSeGinSgeKElEZYVpeJWxdS1x0m7RTQU MQt4ol8wQYdSX0AxNm3HsFmch9voFxwhmTZW3OzPv3L822ajSNm6Lvxco0PIJ9QoDALZ CPF4CETVWKx3vsIQvg6HmqpGb09Au+62EH0QAL8rEVC403oNsJYqI6Mmn/u3a3U7aEmZ 5sqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3EI6RO20rVRuCRMPH7aqjdIMvsCHZ7PyMBO+yhY3R+4=; b=jH/Mo86VRXXqy+RCRG2FRWRcX4CoPZSEDr6fBAwUNocsswSybr216HbknY8f7ggyLc Xeq3ftesmJNCHRdHY7Rf3QEJ1f9Va/W1G4ivWFBZeXuMcUHzvAlA1x66APOw7ziZNWAb LqUk5EWffA242AERSQrkmN7+vgbQsy9Y/Te7T3UXXPoJtePcxVBCLRmILdylIYgKuEbv rMx4aT1WD5ZUz5Syag6ASXc6Kf1RaoWA5uXIhqKQEopgm2SywQJu4Jweg7+X90+ucVBF sqHIsXx8gffChRgAfmnK80CAz0rstBp7tuBqvF77bq5aPIar2Ic6UPLrADmyS2ruNjtF YVxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pNivBqOb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z66si5411457oia.265.2020.01.28.06.13.37; Tue, 28 Jan 2020 06:13:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pNivBqOb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728159AbgA1OMq (ORCPT + 99 others); Tue, 28 Jan 2020 09:12:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:34158 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727611AbgA1OMo (ORCPT ); Tue, 28 Jan 2020 09:12:44 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5013D2468D; Tue, 28 Jan 2020 14:12:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220763; bh=nyI/6SjcakQKzoISggYuKG9ogY0kdS9qt0vhf/o1DP0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pNivBqOb9Kp7GM+KMn+2P7taw9jqCEu4fwJTNeWNF/t2aO7N486XtUSkSjXB0Ewxk XwT8XCYf7Sa/FKhW4KCS6G68Pam8JEWjCuSTGXkQKsZ4grXLVMWS01P8oqz+g/CftE tw6QY+SX5MhodOGvVbZJ24qxwm2Wa9SxPdcqIhpo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mao Wenan , "David S. Miller" , Sasha Levin Subject: [PATCH 4.4 137/183] net: sonic: replace dev_kfree_skb in sonic_send_packet Date: Tue, 28 Jan 2020 15:05:56 +0100 Message-Id: <20200128135843.437284531@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135829.486060649@linuxfoundation.org> References: <20200128135829.486060649@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mao Wenan [ Upstream commit 49f6c90bf6805948b597eabb499e500a47cf24be ] sonic_send_packet will be processed in irq or non-irq context, so it would better use dev_kfree_skb_any instead of dev_kfree_skb. Fixes: d9fb9f384292 ("*sonic/natsemi/ns83829: Move the National Semi-conductor drivers") Signed-off-by: Mao Wenan Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/natsemi/sonic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/natsemi/sonic.c b/drivers/net/ethernet/natsemi/sonic.c index b5f1f4ea9d4a3..6679005782499 100644 --- a/drivers/net/ethernet/natsemi/sonic.c +++ b/drivers/net/ethernet/natsemi/sonic.c @@ -222,7 +222,7 @@ static int sonic_send_packet(struct sk_buff *skb, struct net_device *dev) laddr = dma_map_single(lp->device, skb->data, length, DMA_TO_DEVICE); if (!laddr) { pr_err_ratelimited("%s: failed to map tx DMA buffer.\n", dev->name); - dev_kfree_skb(skb); + dev_kfree_skb_any(skb); return NETDEV_TX_OK; } -- 2.20.1