Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp459940ybl; Tue, 28 Jan 2020 06:19:03 -0800 (PST) X-Google-Smtp-Source: APXvYqy9nHaG/D5h8XZ97/vqEovKTehvo7FMhjM6+04l3xw6DVx7yfG0M57UFnHRxb5aPRGQU32B X-Received: by 2002:a9d:7489:: with SMTP id t9mr8660457otk.205.1580221143297; Tue, 28 Jan 2020 06:19:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580221143; cv=none; d=google.com; s=arc-20160816; b=ez/6yYMiW0siH0fhlHGjKiPaS5khj72kaUxRGlBQl4WUqZAATTP1Va9a/xhimffcg6 1/AReCJSQUsFFw2Sm4pbOtRURKtnbHgf9eGM+nulcEOA4fawr1+VL0YENSdslKumxv+1 wO1fF7n8eyWsP9vBA0lV4NRYWp1LCzfqt/l0o0/0W4CEQxXHI7ZYl8w+rno4xOPYuD/w E+eklgurPSB1kY7LNovxb/IwpKY8ZVedsz8DE4j2dBzADle/cdzt/WVaTvbY4n3ql9UT Ns/lSpwdThPTzh9YEpqwKuDE5FdpLY/3AHJoBnxRWKgnpQrrfRYL8+DVYKw7gCxxdpJW eTLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=nXv28+0NTyLMaPpJyZL3L7i/e9ULaIfEM5PLs9kStYE=; b=cRtnXAzr80jmlQ6UE67yD/tvGtbgBTXRPOxEMbo6oFuE0H4H1LQG4CIjIgyyHvyCZd pkcixF3e4W9yRE4GswWgBHSLvSS5UN168Fq+eOohbacnkl0CuVoiCQFOemTePWKsKOH/ dfQtK8qI0j1EUUwbV9H0sf735BocYhJmCixJ2ItE68dWH7a9qPIt9ID1GPf7Q17fbZyy ABuWwas+fTKwrCf1dp8pP85yY7JAVptSlGryT0WjIyKmXAYBKDWSeeL3q3CHWoHKF6D2 JVbi+dIx+d65W2IsSLVID5S/1f7FIxcKie0eGkDFqCi9HK/ejJHIp7JTpdf9vWVPG/ls dtAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WsufZDps; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2si4497385ote.9.2020.01.28.06.18.51; Tue, 28 Jan 2020 06:19:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WsufZDps; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730350AbgA1OQj (ORCPT + 99 others); Tue, 28 Jan 2020 09:16:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:40096 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729880AbgA1OQi (ORCPT ); Tue, 28 Jan 2020 09:16:38 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B73921739; Tue, 28 Jan 2020 14:16:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220997; bh=LQyTRAzmlUIN12w2DP3qjermEG78dwAp9YevblvP35k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WsufZDpsoB20XzLuM/aXL4q72W7TXzOn39rYlpbBalDqWFnVscpWeuweQpeHyL56i iJrHo5c2SMivDsIOVmiKzmyOWe+5oinbBwIY/qbN0r995sxglbt/8U7RScNu6Fbo/s hm6enIiHVT63uH5hqtrny0WOCM/aGjR5ri1Ea2hg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yangtao Li , Stephen Boyd , Sasha Levin Subject: [PATCH 4.9 030/271] clk: imx6q: fix refcount leak in imx6q_clocks_init() Date: Tue, 28 Jan 2020 15:02:59 +0100 Message-Id: <20200128135854.926970695@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135852.449088278@linuxfoundation.org> References: <20200128135852.449088278@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yangtao Li [ Upstream commit c9ec1d8fef31b5fc9e90e99f9bd685db5caa7c5e ] The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount. Signed-off-by: Yangtao Li Fixes: 2acd1b6f889c ("ARM: i.MX6: implement clocks using common clock framework") Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/imx/clk-imx6q.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c index 14682df5d3123..d83f6221f1b00 100644 --- a/drivers/clk/imx/clk-imx6q.c +++ b/drivers/clk/imx/clk-imx6q.c @@ -174,6 +174,7 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node) np = of_find_compatible_node(NULL, NULL, "fsl,imx6q-anatop"); base = of_iomap(np, 0); WARN_ON(!base); + of_node_put(np); /* Audio/video PLL post dividers do not work on i.MX6q revision 1.0 */ if (clk_on_imx6q() && imx_get_soc_revision() == IMX_CHIP_REVISION_1_0) { -- 2.20.1