Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp462265ybl; Tue, 28 Jan 2020 06:21:00 -0800 (PST) X-Google-Smtp-Source: APXvYqzCSbIemzNiIDQE17vasy07ebN+Jr1t622k6vB7KbXvqUHRrIAt+EUyVyqVGhpjeG0s1qDH X-Received: by 2002:a9d:7696:: with SMTP id j22mr17334951otl.188.1580221260201; Tue, 28 Jan 2020 06:21:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580221260; cv=none; d=google.com; s=arc-20160816; b=sLcZev4nQYsXUM7zYrkAz80jPzzec7aQkpALPaTQXQLhTlqQIuy9u0yy83k2/X0GHh +KG/OKIevQqX1LyR6exOMT09DH/3h6l8imjIaqVXZUP7XxSuxzt4Nj3jaOGqxMoxuvwz WH83V87qtnlSkXkHXS6O6HpscoU9qtgreLMdejjSI5g4X0D9ayxBPFafV1gTRu/yAeDa 5CDl/+wAG4HBiHHG2knh046gZG3xwYZC7uAC7D03Klp7RdXCf1waaR5tvQfKLvPYwU3p bod98ZHk3TfnQzwun9g42o+Zi5O1kNlfEoooaXgPiI0u3Ahq1v7O2EnhDT6ByxGEv7gX PlKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=64u2DpeR1k1SwjmAgf7b73XLO9ukZ+eVNVR7ErpEm/Y=; b=nA9xMwbf6OFbw5W9GL5upPHcUxZk9BgAJTIVOT/f4cZE3znAtd0InCqc3heKtth8bh GSIeX3mLztmttWpiLdG8/LFkrmkbzUneX+qFDXxEhWaUv7IbaMv5nWg/TdD8jv+OnMtt qfmr/3CA5UAt1fSMNRrow2K4tjMFoPWe8srrKUfh6cmJ5+wxO0DZNHOy5S7zjTf7S/PR s+maDPjz7gvGo7aiDPAcSR24m2W7fi/+OplsiT5afwoLHdN3obp6PW/2fCirGPPUj1Xa 5CdYNOH6zqW2XI9wi//fE0zcVnrURsar+AVTeHADIDp7d3XJYZBnCC7xOvxufSR3DjqK bzaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DDYVAu07; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r202si5249618oie.247.2020.01.28.06.20.48; Tue, 28 Jan 2020 06:21:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DDYVAu07; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730965AbgA1OTz (ORCPT + 99 others); Tue, 28 Jan 2020 09:19:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:44406 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730951AbgA1OTv (ORCPT ); Tue, 28 Jan 2020 09:19:51 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 83F8024681; Tue, 28 Jan 2020 14:19:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580221191; bh=Oib6y4GU4rzaCn9AhuQjfgeSuoiUMJQL0ZwShrBJF4k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DDYVAu07rPZ44RQXPCodmZ9Os8DAmtj7aVNDgXkPNYbjIj09EJwhafHxfP09sg7j+ 7cLIiRVM1XYVAoz1dHjG8KHqj9on1/Ap4m0IR8TvsLTv/PM19ih1nKRZ2RturKFY3n 61Du96lnrIxGpjJCi5Nc3DubZbvA47WVlkmjId54= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Felipe Balbi , Sasha Levin Subject: [PATCH 4.9 126/271] usb: gadget: fsl: fix link error against usb-gadget module Date: Tue, 28 Jan 2020 15:04:35 +0100 Message-Id: <20200128135901.975479865@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135852.449088278@linuxfoundation.org> References: <20200128135852.449088278@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit 2100e3ca3676e894fa48b8f6f01d01733387fe81 ] The dependency to ensure this driver links correctly fails since it can not be a loadable module: drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_set_peripheral': phy-fsl-usb.c:(.text+0x2224): undefined reference to `usb_gadget_vbus_disconnect' Make the option 'tristate' so it can work correctly. Fixes: 5a8d651a2bde ("usb: gadget: move gadget API functions to udc-core") Signed-off-by: Arnd Bergmann Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index 19ce615455c1b..de70e70d02bed 100644 --- a/drivers/usb/phy/Kconfig +++ b/drivers/usb/phy/Kconfig @@ -19,7 +19,7 @@ config AB8500_USB in host mode, low speed. config FSL_USB2_OTG - bool "Freescale USB OTG Transceiver Driver" + tristate "Freescale USB OTG Transceiver Driver" depends on USB_EHCI_FSL && USB_FSL_USB2 && USB_OTG_FSM=y && PM depends on USB_GADGET || !USB_GADGET # if USB_GADGET=m, this can't be 'y' select USB_PHY -- 2.20.1